Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 26 Oct 2023 10:01:18 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, andrew@lunn.ch,
        Jose.Abreu@synopsys.com, fancer.lancer@gmail.com,
        UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get
 state for XPCS drivers
Message-ID: <ZToq3n26jDqiueTB@shell.armlinux.org.uk>
References: <20231026054305.336968-1-Raju.Lakkaraju@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231026054305.336968-1-Raju.Lakkaraju@microchip.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Thu, Oct 26, 2023 at 11:13:05AM +0530, Raju Lakkaraju wrote:
> +	sts = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_STS);
> +
> +	state->link = !!(sts & DW_VR_MII_MMD_STS_LINK_STS);
> +	if (!state->link) {
> +		state->speed = SPEED_UNKNOWN;
> +		state->pause = MLO_PAUSE_NONE;
> +		state->duplex = DUPLEX_UNKNOWN;
> +		return 0;
> +	}

You don't need this. If autoneg is enabled then these are initialised
prior to calling this by phylink using:

                state->speed = SPEED_UNKNOWN;
                state->duplex = DUPLEX_UNKNOWN;
                state->pause = MLO_PAUSE_NONE;

or if not using autoneg:

                state->speed =  pl->link_config.speed;
                state->duplex = pl->link_config.duplex;
                state->pause = pl->link_config.pause;

so you don't need to touch them if the link is down.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!