Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <090b1631-6baf-96b8-3039-0e769c261cab@intel.com>
Date:   Thu, 26 Oct 2023 11:14:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH iwl-next] i40e: Remove queue tracking fields from
 i40e_adminq_ring
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Wojciech Drewek <wojciech.drewek@intel.com>,
        <netdev@vger.kernel.org>
References: <20231026083852.2623216-1-ivecera@redhat.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231026083852.2623216-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0lvbm0wcDlzK0lsTW5ZdVpINFA3RkJCMThEUU5CeVZzUEdXQzRzTFFQZlVL?=
 =?utf-8?B?SVk4Uk00bDh5bUxNVEVGY0ptdldHQWhaWnQ0eGFFK1NhR1NGQ2E3YzJxbzI0?=
 =?utf-8?B?ekRua01JMFR5V0VnUTZIdlpyTUFPb1pFYmhOYTQxZmhwa21LbGt3RVcwWUlz?=
 =?utf-8?B?ZVkrck40WmNqc1lFYlY3U3lERHR1a3FqZEtNbWJ0eGw4TXZxeEpBa1FOYTUz?=
 =?utf-8?B?Rm1VeXNpQXdjLzlocjZQazkzcVBLS3YwdTJrenNHdmVCNm1abmp3YmZ6dTVt?=
 =?utf-8?B?MU1vd042bW43bUtTanNtb0V3clNsL1dwWUNKNVpDSmZIZmJhK0Y5NHNpS0hl?=
 =?utf-8?B?WmlQNjAzU1VheHQzblhVSEcyR1hMSEJwOUxzc2FwQmtwalFtbmFSUjBIUFVH?=
 =?utf-8?B?QWZtVmRSeWlTbTdnNCs3dzM4UHVtT2VVWHFVSmg1dUpzdE04K0lTb0hFMHZa?=
 =?utf-8?B?MlVVaDl0SFlsM3BRdmNwenNZVXd1UWdUQ1h0N0NzQWNGYzRXUVd6c253SjJq?=
 =?utf-8?B?N09vandzekdxSm1Ub2gzV3B0Witlck5lNWs5NzVVeDFwS0xNRmQra3RvN3F2?=
 =?utf-8?B?dXRVR3ZCNDJFR3VxbEhLTjUzc1M0MUNDSzdKQy83dGQ1NUhJQ3c4K2R1L2Er?=
 =?utf-8?B?Z3A1Q2FIL0xjRHBoRi9sdjBKTUtlSkZNeFVIUjhzSTdWWGc1VXpyWUF4TGM2?=
 =?utf-8?B?OFNpaFhvc2ltdzVSblVaUGFxdXhOalArU3JYSVRSRnZYNlFvMGthS09makk2?=
 =?utf-8?B?OHR4NitOTlBzTmxId1EzektuNUFoNW4vNzVPemR3eDNOOUZJL1BKcFV3bGdP?=
 =?utf-8?B?S2hObGdYeVNxNHh6NDB1SzZQbjM5TktPN2lydFZUblJHTWVZcDQrdmc0T0hh?=
 =?utf-8?B?S2kxdytsWVZIVmY4MFFPeGFQZk1iMXhGZi9VdkRyVUl6ZGpSb1Y5Z3RqdVZQ?=
 =?utf-8?B?bHc2dmRpSUIwWnBCUlcrTWhlb3JDQlh1bEI3NHM5YTl2RzBFTmpGNGtNTTNy?=
 =?utf-8?B?QjRPS08wd1U1RjBhWGFJMmNnbW4zRFU1Vm1mY2V3aTVlUFJMd2JkN2ZETVpj?=
 =?utf-8?B?SW1hbjhmUWFYMFlqcGhZa1FrSmMzUVdWSkluaTBpNzR0T0J0MWl5aytxbG92?=
 =?utf-8?B?NjhQVU9UaUxXWGYwcnFKL1ZuWjM4TXBSYUdlRzdkNnJxV1RQUFk2cXRUTTJT?=
 =?utf-8?B?d05vaC9hL2EvcjU3d1BYMXJBbGZibWl0VGhLa0xNa1UwVFY1aGtpUTArVll6?=
 =?utf-8?B?Zm03UE9PazVEVHRiN3VNTjNPZjVyQnkzUUxVblFTV0VJM2Q5N2JyWWhmMlZR?=
 =?utf-8?B?Q21veU9ESzYrZTJNQTc4b0ZKandwYzl4UjJDanBLU2FNdnRacy9oNU92V0py?=
 =?utf-8?B?NktIeFBUeVhzZHB4bHdsMnovU1FUWnR6czRqMmQ5b0Y3Qzltb0RNUWVaQTUy?=
 =?utf-8?B?TzJ0V1lUWjBwLzJ6amJ3TjZUa3ozSU94MGxKRDZETGdaWnNxOEdXMDdqVnp2?=
 =?utf-8?B?Z0srSGJRMGZzb1Q5MDZEUmYrR1l2MUJ3MGdqTTBQelliU3Y5ZDlJbDUxWDJN?=
 =?utf-8?B?U01adnFsVGRKS3plV1JWV3VDcjJMajVEZ0psZmZ3bmo5UE9XSG1jOFpXTEhS?=
 =?utf-8?B?clVTaUNUd20rVjNhVVBhU1FoVGoxclNrR055RGNYVERDakQ1eUdyTmgvV3Z4?=
 =?utf-8?B?ckc4c1NtaGg1WnFPdGo2Q3BmRGRQbEpDYnN6ZHF1M3dqcE8yd0dIWVhHZkFJ?=
 =?utf-8?B?L0tLdXgzbHNaMWtQQWNySjM2dWx6ai9WN2dObnFpK2g0ekY1amRPN08yV0Vh?=
 =?utf-8?B?cEtZWHNROXVkbG5lN2J3UDRXNjVZSENPODFiSGtBa0xvOW9FMGNyQ3QvSkVG?=
 =?utf-8?B?SkpxK3lmdTJzQW82RjNDU2UrUEtiRVl3Z2NBMXZkUmM1aG9MTDdNclFzV1FK?=
 =?utf-8?B?YTlsWnJmdGQ3SnVERFZZUGNQYjkzVU5zL3BlNVdDbGdXenF5RVEyNU1XelZu?=
 =?utf-8?B?b05nQ2FoM3ZWL3FwdHQzRG5SZEZ2b0lvenU3aGVWOU44RjFySFR5MG44eG1M?=
 =?utf-8?B?Q2FvdWFzL1BmRzFVSnIxcWVVdlRqUmJ5VVRkUHpzV3hQaHN1eGpHMDEzeGxM?=
 =?utf-8?B?d3VYMU5iTXdlVVQybHNxVmZMMFNzWFdETDdDT0YvQmRaeFl2Qk5GMzhYb0VL?=
 =?utf-8?B?YWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 16226824-595b-45f8-9ff2-08dbd603f96c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 09:14:36.3375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fF6KV1sfHpKPDdDVXCcWsr730Os7HbLOXunpIrCwv12taSMMYcMwBz2gsAz4MGktZpeqI/69hNJ65M3VkdQj3uBOnypuZ3o4iGGSPy3IWAw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5396
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 26 Oct 2023 02:14:54 -0700 (PDT)

On 10/26/23 10:38, Ivan Vecera wrote:
> Fields 'head', 'tail', 'len', 'bah' and 'bal' in i40e_adminq_ring
> are used to store register offsets. These offsets are initialized
> and remains constant so there is no need to store them in the
> i40e_adminq_ring structure.
> 
> Remove these fields from i40e_adminq_ring and use register offset
> constants instead. Remove i40e_adminq_init_regs() that originally
> stores these constants into these fields.
> 
> Finally improve i40e_check_asq_alive() that assumes that
> non-zero value of hw->aq.asq.len indicates fully initialized
> AdminQ send queue. Replace it by check for non-zero value
> of field hw->aq.asq.count that is non-zero when the sending
> queue is initialized and is zeroed during shutdown of
> the queue.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_adminq.c | 86 +++++++------------
>   drivers/net/ethernet/intel/i40e/i40e_adminq.h |  7 --
>   drivers/net/ethernet/intel/i40e/i40e_common.c |  8 +-
>   drivers/net/ethernet/intel/i40e/i40e_main.c   |  8 +-
>   4 files changed, 39 insertions(+), 70 deletions(-)

Huh, our code is so self similar :F

as with iavf, asq change is semantically different from the rest,
anyway:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

BTW,
unless you want this applied directly by netdev maintainers (so skipping
intel), you should use "iwl-next" tag and set to: IWL, cc: netdev