Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <5b9282c7-f2a0-a853-e1f9-a6e27e57aa11@intel.com>
Date:   Thu, 26 Oct 2023 11:17:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Remove AQ register
 definitions for VF types
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Wojciech Drewek <wojciech.drewek@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        <linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
References: <20231026083822.2622930-1-ivecera@redhat.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231026083822.2622930-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2t4ajJvUjB2UXRvZHNyOTJ2VEowM1RjbVdLTFp5WTZFSFNpRDgvSW1uSFZ5?=
 =?utf-8?B?N2pVcmRHalZIMTdtYnRxZko2RkllZG1COStoRU1TOVpTOGVHL0RmTGY4aGR6?=
 =?utf-8?B?SmM1ZDVjR2VHajJHOGxXcmtIQlR5S1Qvckc2MzNWRHZ4bHhGQlZlaURSNlhB?=
 =?utf-8?B?TGx3WFJ0Zkh6WkZVVVBxbW1DVVVzTkk0QUd5RVFuTHFkcFNqMkMvSDRtUlRp?=
 =?utf-8?B?MjFvYjV5ZUsyQk1TbVRFSUNWNm9nSHNjR0ZRVkZyQ0ZvMjFtdTVCV0w2dGlH?=
 =?utf-8?B?K24yS21VeS9XYzcwNTYyYno4NHdVSWNUdFJOenNOSGZMM3c5emhUR2c5eWVH?=
 =?utf-8?B?d3pOTzRRNHU1dFc0c0swbGdBVk5sMlB2TWc1YnVPMmFGSktDM2F0d1dhU05N?=
 =?utf-8?B?MW5iRnJFUWErQUZjaElNR2xjV2VpNHljSVhyT2xWZXRZZ0owM0FKaE96KzFu?=
 =?utf-8?B?Mk9aVGNIRnYvTEg0TTA1dGpWdm5kNUR4MG1zOU42Y3lZa1NXR2pHQkxic1d4?=
 =?utf-8?B?ZDU3NkVTY2dEdmU4YnZhcW9lczh3NVJjSVY3aGV6ek5uVFhuSk1IS2cxODJR?=
 =?utf-8?B?RFJMSzlZaUVFWEJrWEljRDliU2poc1dIa2FNcGtqZ291c2Izd2xWeDNiTnZr?=
 =?utf-8?B?dVVWY3JGYW10N0RIN0lqUW84S2NPSERKSkpsRFpzbUdxQmRWOWRzWEVpRzB5?=
 =?utf-8?B?b3BjM3gvRVZnZkRhK3BxNXJaL01mdVNpMkhEVFVSQkFNaktYVFBrOUVnYVpu?=
 =?utf-8?B?d1hKSk5YTDUwYTNYTDBxRklFQmhJZFNVZlVuS1p3YW9zUUUyOFhaVkVDNmtv?=
 =?utf-8?B?UmlXMVNlRjFBamZBUTRwV00vNjZFNjJScC8xcVVLRDhXbkxwbEMvZEZlaVJw?=
 =?utf-8?B?NklPK1V1Q0Npb0NMR1NobzhtWmlxQjV5MHJnQk00UkVpR3lGeG91VHRIR1Z3?=
 =?utf-8?B?NTNBYnpmM0tpUXA4NDlJQkNUQjJzakxKbW5VVGxJSFp1NTBxWjFCQjlqZzA0?=
 =?utf-8?B?YmN6VDBsSkRiZk5JenBsVzBZREJHNkhuSjZhKzlBV3ZkaUdSQjF0OEsveVY3?=
 =?utf-8?B?Tm0xd2hRWVdqZUVpbThmL3V0czZvZE1lVVd2NFdNQUtrMHpPNDY2eGZnWkZD?=
 =?utf-8?B?NjRlZEpSdTZKSHVQVVQ4ZTFURFUzTHhQaXIxUkFOeEdrTzRwN2lMY2N1aTE3?=
 =?utf-8?B?TGI1cWpmLzRqeFBlWW1sRzdtV2pUR1UzaCtkY3lGVzVVRDZ4OTJvVDYrUjhV?=
 =?utf-8?B?aVR6S05JMTJzbzJtb3Fuemo4Z2NGUjFwZzBhVGFnYVhDbDFHY0NlNGgwa3oz?=
 =?utf-8?B?Qm5lbU84UExVQ1BVMXJjOUZxcXQ1QWRCUUN5bVMzRGcrMldSQXJGQ3ZTWU9O?=
 =?utf-8?B?OXY0WHU0TWhlT3pzTkcwZDcwYnZVbFNuTEpUcUpWQ0cvUko1NW1CWTRkOEdB?=
 =?utf-8?B?dTQwR0pGU0ZCVGFRS3picUpuY0xNVllIYTkxdmNxTVIxLzd5RUJQV2lRVmpr?=
 =?utf-8?B?SWtHb083MFJiVTZDOHdpdGxwL3JlMTVRZnhnWWkrTTVYVU5MN3Vrbksya0Rr?=
 =?utf-8?B?WjA4cGdqYVluTTBUMG82b0tiWnptcXkxL25WV2ZhNmIxc2VISGpVU0twTDBV?=
 =?utf-8?B?TVBjblNjbWJ0Y3E5UnBOV1BicHNPemU4VWJwS3hEaGRUUjJBa0xqVytvWFE0?=
 =?utf-8?B?WnpWUUhrZHRrVHV5b1lIZFUxSmVRRGRYN3oyWlhXY3Q0dUwvNXVoZFFFU21x?=
 =?utf-8?B?THUwRTliTGM4MXUrRHRaWW0rSzNlTW1jR1Y4NytIN1l5elRuL1QxaFZiR0Ru?=
 =?utf-8?B?UEI5M1VkSGlUcTZzdEhsNkxaZGJUQ0x1MEhGQU5kUDhRWjluajFjVHRsUU1T?=
 =?utf-8?B?Nm10MnVZMUVwQXQvWnFqSEdHSTBZUG84b0NWK0hvMFUxOTRGMG1ESGlLRlF4?=
 =?utf-8?B?amY0VVY0b3pJbnFXNzRIa1Q4MEJnYnBKOHY4QzhRck0rZnZXSTN4UGVkQ0cv?=
 =?utf-8?B?c244aGpURUMyV2tPQ08zRDhTMk4zd1NHeHo5K0JGdlVoOHhmRmMveXpuR01O?=
 =?utf-8?B?YkdkM05YSjdKcU9GQXBlVzErSVFXcGhGVDZKQndZc2tFUjJKNm1pbWcwaXIz?=
 =?utf-8?B?N1BOQUN0c1o2VVh2K1FHcGhkOFR1a1JoMkdhTnFybUxyQjBUL3VZL2xIQ081?=
 =?utf-8?B?dUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 18e88bb3-a57f-4bb6-d8a5-08dbd6045bcc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 09:17:21.3716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ecgW5L6DCoAw4J0T/Uk23Im1zkHHp1BdphXmX7rvDYHbxC1ROefdajcBjq7HIGorNVhFLWctdnQoJAOBpipAmxlO+7OQo4ZSgOo9Wzen5hY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5396
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 02:17:48 -0700 (PDT)

On 10/26/23 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
>   #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
>   #define I40E_PFPM_WUFC_MAG_SHIFT 1
>   #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
>   #define I40E_VFQF_HLUT_MAX_INDEX 15
>   
>   

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>