Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <1c87106e-c889-06d6-dab9-67f96f5ba044@intel.com>
Date:   Thu, 26 Oct 2023 11:33:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH iwl-next] i40e: Delete unused and useless i40e_pf fields
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Wojciech Drewek <wojciech.drewek@intel.com>
References: <20231025145937.1873040-1-ivecera@redhat.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231025145937.1873040-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTdqRXR4cFJCMHRONG4wNFI3b3RVUFpVMmxhdkJLMFFnTkpCbFd0aWVlUy8y?=
 =?utf-8?B?M3VzU0lJRlhoY1o0V3hETVF1QVhMbUJEU2o1Q1o3cmVSQ3prb0FKUDhJZW1h?=
 =?utf-8?B?Qms1clk4a1RPVFRXNGxTZlM1UHZ1d2c3VW5YdDJHSnFEemEyUlc0dEp5MnZN?=
 =?utf-8?B?ZGVoOWRnaEgvR2JLQ2cyUGdueEJKWTI0bUMzOEhMMEh2bG44dnh0Q3NBVkdr?=
 =?utf-8?B?b3dGSFdBdlZ2NENpUnNXOHMzdmZVL1dvMFFrQWhmNnd2NUxEU2wySW1DLytW?=
 =?utf-8?B?RW9BS1lqT2xmaWgzV3NWVWZzbGpNbVlkMTFCcW5OTUt2eHZzM294NGNWamJW?=
 =?utf-8?B?ZkNPNU44TmIxcU9tait5RjJ3ZlVQbEFTYmI0NjVucU93cFp5cStEdnRPS1JR?=
 =?utf-8?B?S2dXUGRSRkl1bmkrenFPclhpcUxUSHlYMHR4QmRyYjU2RGRPa1FGVFZRVGFQ?=
 =?utf-8?B?U3ZWdGpKTGdMWlJaYlVTUXhPay8rcTNHTUgybWxJSFJoU2ZxdnVmNHNxbmY2?=
 =?utf-8?B?d2tvK2t3UVpBYjF5YWFjVGxxcTdyb0lQV0lYZktvTVRkc1AwNmpDTkN2VGd6?=
 =?utf-8?B?LzVzUzErdXl2R0czUmdHb3hpMWpKL2ZXQXJXM3V1WU5vK2pUeVppUWFOYnRi?=
 =?utf-8?B?UDJDUk54VXJ4aUhMMVNmdVJhMVd3K00zK2ZSUHFZMlZpeWJMckExUWZ3d0V5?=
 =?utf-8?B?b3B6S3ZuNG1lRFlneGxGTmJpMGtNcVNRdE9pWUZobCtBaDhuMWMwc1hrVGFv?=
 =?utf-8?B?SGcrV0wxTm1mbE1QeWEya054VVN3cGc4bC9seURVTkpyUUhCZldiWW5DRXhO?=
 =?utf-8?B?aE1IZEZQbnEyS3RoSlJLQ0x4RlF2eEt2YU91Y1EwSEorazQ3UnJuVGUxS3VW?=
 =?utf-8?B?ODBmaVlLZnZqeUc5aXgxV3VsVUM3S3BLSkpGMDFMUWxoc1NQS0hUcnJCOWFh?=
 =?utf-8?B?U2pHeUUvZHVmVHMzbHdaUHJTVGU4dHR0N1FjNE5wNTdaRFF6MXRwSnZFSTlm?=
 =?utf-8?B?R05DV3dGYmtwQ2JUdkUyUXlYWDNJY3dwOWZPS2oyTEJOMG1tZUpzUm1YY3B0?=
 =?utf-8?B?cnd5RjBpeWZJdURrbFFWVXZMQlRqVVgzbzAwbDIxQStPTm1ZUlUvbU1qSkIv?=
 =?utf-8?B?L2dqRjEvbDFJM01HbWQ2TXQzT0Y5V1U5dDdJTVhZb0Jua0p4QTU0L2RFQWVt?=
 =?utf-8?B?TWdsK2F2dWsxOG42bzZhNW9qSldlY05VbExkU2IwMWgzNFhPTFFUTTNPaXdw?=
 =?utf-8?B?b0xEeWVqRVpSTDFCaktwVXU3T0ZCWGJTS28zTVR2NzRmMmxjMzJCR1kvenVI?=
 =?utf-8?B?SnV6aklwTVh4a0tsUllyMW1sRWYxM3NNTDdERkNITitrUFlVbkN4OHFOM0R4?=
 =?utf-8?B?NXJteVRibWJwYzRDeVpuancrZVVaY1lTWmdTYVBJTGtmWDd0QUY5T25OL1VF?=
 =?utf-8?B?VCtNUUsyKzZyOVJaK0Y0anZIb3NERmo2QS9yMHpSZ2dGMkJRZjNQS1dUSnRx?=
 =?utf-8?B?WGE1cklTa0Y0Y3RmZ3dnWGg5c1NkaXpDTnVPVjVjdXl0UlhSd2JFeCtpUEg0?=
 =?utf-8?B?VEN3ZG9IK0hSeVpybG55dTNyVlcwVUtqMWFkc2tzMVBsZm1wbHpWYzc5eStr?=
 =?utf-8?B?eDhkTmhndGxYVjMrM1FkL3c1RDl0UHk1V0dleDkyY0hZQmsxRWgvMlRzQUVp?=
 =?utf-8?B?REg2R2FtbFBibzVOU05qeHRmSjdVV1gwNmdaN1BXRHhRNGxDTitjYU4zYVJr?=
 =?utf-8?B?SW1CL0N1NksvcjFQeUJjY0crZ3V2TWRNMEZsVTVWTUg3ZGg1NmJROHRwUzVw?=
 =?utf-8?B?K0Z4czNRSnc1QjA1NloyUG1rbm5nZTNDak9LV3pockE5cjYrTzdINitxMjNi?=
 =?utf-8?B?YjlQY2gzZnI0M3Rxc2h1dy83WitETXh3cGVMNjQyZFByenJ5YzBtRnNza0pK?=
 =?utf-8?B?Lys1VFdybTBYMDU0QVVoSHJqSWhSOVJ1dmczNEx4WDBJZ08xc2tmS3oxTUI2?=
 =?utf-8?B?dmIxd2JxQkJRSlU2Q2MvR1VWMTArWXMvUWNmNVp6RG00Ritkd0J3S3dWUklo?=
 =?utf-8?B?cUMwcm1XYWo0MktFQVV3cHh3ZlR3YkE1Z1hQcHZWV0Y1SDl0UGNhTlJSYStr?=
 =?utf-8?B?N2ZGQkFyQ29uSThSQzNjVUV6OE5Yc3RscldETllkTWFNMXNCcjJpK1UrenNl?=
 =?utf-8?B?Y1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: be797f07-415d-4662-029b-08dbd606acf1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 09:33:56.3742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0fQ/wL5GkTt07aR1+ymb3Glo+WrvOkN0J1kUkqfYYMLlAWz2fnUZWVZ32sWi1YaXwg+hlDo+czgro+K0wpmEl09AUI1R33H2to8o/zN9+r8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8077
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 26 Oct 2023 02:34:13 -0700 (PDT)

On 10/25/23 16:59, Ivan Vecera wrote:
> Removed fields:
> .fc_autoneg_status
>      Since commit c56999f94876 ("i40e/i40evf: Add set_fc and init of
>      FC settings") write-only and otherwise unused
> .eeprom_version
>      Write-only and otherwise unused
> .atr_sample_rate
>      Has only one possible value (I40E_DEFAULT_ATR_SAMPLE_RATE). Remove
>      it and replace its occurrences by I40E_DEFAULT_ATR_SAMPLE_RATE
> .adminq_work_limit
>      Has only one possible value (I40E_AQ_WORK_LIMIT). Remove it and
>      replace its occurrences by I40E_AQ_WORK_LIMIT
> .tx_sluggish_count
>      Unused, never written
> .pf_seid
>      Used to store VSI downlink seid and it is referenced only once
>      in the same codepath. There is no need to save it into i40e_pf.
>      Remove it and use downlink_seid directly in the mentioned log
>      message.
> .instance
>      Write only. Remove it as well as ugly static local variable
>      'pfs_found' in i40e_probe.
> .int_policy
> .switch_kobj
> .ptp_pps_work
> .ptp_extts1_work
> .ptp_pps_start
> .pps_delay
> .ptp_pin
> .override_q_count
>      All these unused at all
> 
> Prior the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>          /* size: 5368, cachelines: 84, members: 127 */
>          /* sum members: 5297, holes: 20, sum holes: 71 */
>          /* paddings: 6, sum paddings: 19 */
>          /* last cacheline: 56 bytes */
> };
> 
> After the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>          /* size: 4976, cachelines: 78, members: 112 */
>          /* sum members: 4905, holes: 17, sum holes: 71 */
>          /* paddings: 6, sum paddings: 19 */
>          /* last cacheline: 48 bytes */
> };
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e.h         | 16 ----------------
>   drivers/net/ethernet/intel/i40e/i40e_debugfs.c |  3 ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c    | 18 ++++--------------
>   3 files changed, 4 insertions(+), 33 deletions(-)
>

[...]

> @@ -12831,7 +12830,6 @@ static int i40e_sw_init(struct i40e_pf *pf)
>   					I40E_MAX_VF_COUNT);
>   	}
>   #endif /* CONFIG_PCI_IOV */
> -	pf->eeprom_version = 0xDEAD;

haha, dead indeed!

[...]

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>