Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <5ef0961b-fd69-4fc5-8212-d5f502e42a50@intel.com>
Date:   Thu, 26 Oct 2023 11:51:36 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next] i40e: Remove AQ register definitions for VF
 types
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>
References: <20231026083822.2622930-1-ivecera@redhat.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231026083822.2622930-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDVwa2d1a0NINTNHYXFqeVpYTUhkbkxKK2pPWTBld1Ztdmg5L1pjekE0ZVZD?=
 =?utf-8?B?QzNLaUdPLzY1NWlDK0xlNUp2TitOZmlwT04rRkNwK3QxNDF5WGhRbjRaOGJG?=
 =?utf-8?B?MnZPYlV5T3F6Y29ta05uOUNGTFZ5ZmhIZXhkRDFaZTMvWkx4eXQzdi95ZGxN?=
 =?utf-8?B?TUxBWlBkUUJsY08yTUFscEovZzAvbldOaTVmS0pvQWZYT3pJemdOYWFlK3k2?=
 =?utf-8?B?RE5EQ3pWSTY1amgvN2p3NVhQVFg4WjJ4cmtiY0taNU9FaTYxWi9OVy9SRlZB?=
 =?utf-8?B?YnVqeDJGb2dPU25NQUUvRUFSZkQzT05pSjQvSmhDUW1Hb1IzS2dwMktvK05y?=
 =?utf-8?B?RkpoSHZWMCtKMWV4TnRYMXFsRjgrQlJPa3dONStLRmlRbFlqN2phVFlLTHZ3?=
 =?utf-8?B?WHp6eklrcktJTGpmT1hkV0ptekRFZG9JbmxRbWhYUUJsME1mc0lsdlBpQXM2?=
 =?utf-8?B?VksxN0g0MTQxVDNmeklDaWhMdXYzVGl3YkJndmZvWHArby9tMUJvNVI2NkxG?=
 =?utf-8?B?Mm9NNEFnelhYeVd1SXpJb2tLNnpSVGsvR0pBbElUWDRxM01JQ0dCeStwWkZj?=
 =?utf-8?B?N1dBOHAzVXZXNnJLd3FIS0JqNXg3RUV1SHlJc3JUcVVsMTYyNlgyUy90cTVw?=
 =?utf-8?B?b3RVQ1ZrYm1qcnlxdERROThoeWJJNHRWN1dxOVpMWDFINVZJRXBHaWgyajdE?=
 =?utf-8?B?cXFSN3BWbE1YTk5WV2tCdjcvTjRsRjNXMldVVGpSbXg5Rk5vUGxRc3NXZ3l4?=
 =?utf-8?B?YmJCaDZPZXVqZFZFLzhBQ1NLZEF1dzdlRVF2Z2FyQWxwSHhUS1pzRUx4S0Zx?=
 =?utf-8?B?QTEzQzU5K2EzVzJQQVI1ZkMyOXc4WDczNEMxMXM0RmFoNkJPaGhVT3Mrc2NW?=
 =?utf-8?B?RUcxNDRPclU4Qys3YU5JZmEwT2trejBvbkRRcy9EeUF1Mzl1RER3Z0QzcXRt?=
 =?utf-8?B?aElja3BTZ3padnpYZlgzNXhxTXBCMVZNMEVJSjZuT2JBK0NtYm53cDNuSEEr?=
 =?utf-8?B?QWZ1NlE5VUkvNStMSTdQMGRLSDBPR0d2VHZmUmF6Ky9zUWxWdk54a1lUV1Rx?=
 =?utf-8?B?QU42Nm9TUXZNYUkyZytMczJKTDl6U1NNMnoyRHlLM0RlQ0N4ZlNwU0FSNDB5?=
 =?utf-8?B?aS9uZnMyYmlRL3ljcnFoL1NvRGIxQkFyNCtEaHZFQ3M3d0xNbTgrSDYyYUsr?=
 =?utf-8?B?ZG4xRmFCaWp1c1dQMXk0bE1ZN2tXL2hiajZxb3NVTGlGSDltSzdMc29uTkVF?=
 =?utf-8?B?RlAyRURLZ3czVUZQaUk4dDhhN1NTWGFxZjNpMWdZK2RLVEg3WVNERGVCZ3pz?=
 =?utf-8?B?ejQ4UlRSZWFabVRuREJ5czljK2lINTlhVTJUUXVrUlN4RGxOTlpreFdlUlFS?=
 =?utf-8?B?VXdPNGR2NWljN0JNWElTeHVENzQ1M2llaUx5RUgxRmRMWGplMW5RdHdqSnZi?=
 =?utf-8?B?dHVtWTRKR0NIOVQwa3J0NnpVeFliamIwdDZYQVlGOGZmWFNYNEFBVjZyRGth?=
 =?utf-8?B?ZFRWWWFKQkJzYkIyZjdYZVF5aW56YnBidDhsYmd4VU8rNDI5WWxieTNQWldk?=
 =?utf-8?B?L2ltcG1pbUgrUHBvM0xka0JJdlVEVTVhYnJ2c25USWpRcG1ZK0d6Mk5IdC8y?=
 =?utf-8?B?dkQ2c05yVzNJb0RHMHk0UzVJVUZhcjY4MVRMOER0QlN1WTlJSnA1cUFIQS9U?=
 =?utf-8?B?cXI0aW1CV0FVbXJocStMdkEvM0dRWDVDZmJ0Ly9iUGxsZzBiRHVXUWdnQTlO?=
 =?utf-8?B?bjJ3TmJxWDE2OExLTkdVVER3R09oVnk0U1FyVXdxdkEwdDdEVzNaVHVHQndO?=
 =?utf-8?B?bG1sS0E2QUlKOHI4TFhpVWFLNUkrZVNMb21kVXdOcStQb2JsQmlOZm9nNjdz?=
 =?utf-8?B?SXU0bEo1Tks0M0J2ZllQWU9aeFl1WTJBN1FBSU42Tlh6andwb1V2Mis1UHlS?=
 =?utf-8?B?Z3FKSWJnRTRDZ1J2VDZpazh5enZHQUxOOTJwcnNmMklOQnFCSHVhek81OVNs?=
 =?utf-8?B?Z3JkZUx0VXROUmo4WmNVdUlyTmp1RDM2cThuWFY5c2FKS0dPNHI4aGtMSWhN?=
 =?utf-8?B?TDk5SXlaM1c1MTk0ejJQeUNmRHBWdis0SEpVL25UN3JaUVlYTWh1TmNicTBZ?=
 =?utf-8?B?QkZtUWNCL3ptTTUzV3VlS0VnaGE0WnVadldGSzBoQ1RZVk40Q0VSZkttUkhU?=
 =?utf-8?B?b2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a7e8d5d6-7b16-4c1a-32b9-08dbd6092661
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 09:51:39.3463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CLWAG40ucIq3K6JamSsbFaxBGVzYzib4XsE2uMQ5DOHh3u9EJq5QRjUvmnI8ulj/60Q9iqU7CdV7vHAgnZ7K8QbC7RKewVuCNTrDJsW0cec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8307
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 26 Oct 2023 02:52:03 -0700 (PDT)


On 26.10.2023 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---

Thanks Ivan!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
>  #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
>  #define I40E_PFPM_WUFC_MAG_SHIFT 1
>  #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
>  #define I40E_VFQF_HLUT_MAX_INDEX 15
>  
>