Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231020102901.3354273-1-mszeredi@redhat.com> <20231020102901.3354273-2-mszeredi@redhat.com>
 <3ab474953c734d0bbf0177bf5d208799@AcuMS.aculab.com>
In-Reply-To: <3ab474953c734d0bbf0177bf5d208799@AcuMS.aculab.com>
From:   Miklos Szeredi <mszeredi@redhat.com>
Date:   Thu, 26 Oct 2023 11:52:34 +0200
Message-ID: <CAOssrKd2tO9a18qEUPnxnoWzD0WSvT2G7_kcJr=uunCd1xKXYA@mail.gmail.com>
Subject: Re: [RFC PATCH 1/2] add list_for_each_entry_del()
To:     David Laight <David.Laight@aculab.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Takashi Iwai <tiwai@suse.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        James Bottomley <James.Bottomley@hansenpartnership.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Oct 21, 2023 at 12:00=E2=80=AFPM David Laight <David.Laight@aculab.=
com> wrote:

> Adding a list_del_first() function that returns the deleted
> item or NULL to optimise it might make more sense.

Something like this?

- list_for_each_entry_del(entry, head, member))
+ while (list_del_first(entry, head, member))

This allows the compact loop condition, and I always hated having to
pass the type to list_*entry()...  Disadvantage being that the
assignment is now implicit (just as with all the list iterators).

Thanks,
Miklos