Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <5819e6c8-d887-40ca-9791-07c733126e64@intel.com>
Date:   Thu, 26 Oct 2023 12:14:29 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] octeontx2-pf: Fix holes in error code
Content-Language: en-US
To:     Ratheesh Kannoth <rkannoth@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20231026030154.1317011-1-rkannoth@marvell.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231026030154.1317011-1-rkannoth@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2RxMnJJTVNEeHNiaEl0QkdlV2d6ZXFLTmM2TzE5V1YxenpoZ09WWGhWS001?=
 =?utf-8?B?UUsxTCtaODBQcEcwTWR5TFFrL2lEb0JWbG5LRmJocnFSQ085dGM3akF6S1pF?=
 =?utf-8?B?S0RKNFZGdk9XV2hGS1lXVGRBNTA5SDVwV2ppUCtjUmZJcnR3SjRrdDhDbWRF?=
 =?utf-8?B?NjI2amdqckYrSDNTL2g2aU03bWNydFVxa3NtcVBYUUM2MU1SVTRlUjJyaTR2?=
 =?utf-8?B?Q0R6cVZ0UENjeDdvWitodktMVUFPZTFaSGw2Zk5YcXZWcWZqZXpRR3hJRm5n?=
 =?utf-8?B?Y1FxRnJ4bnVUZUZKZ0NSZFFOUkhvTUQyRDluNVZnU01iSXFCNzZFUDE4aFVu?=
 =?utf-8?B?Z1RFdmNCdU9za2dSN1Q4R1lrTkg5VHVVZWFlOHpLeFI5V0g2SDVTRE8wa1dW?=
 =?utf-8?B?dTE3Z21Demc1UUJWWlhJMG9WZEpFcFQxRnI4cXNzOU1Qd29YUVVGRFpxL1Vs?=
 =?utf-8?B?b3pYNk00Y3RyNDNPalhRdkg3R0lwQWFua1phc3p5VUZWdVlwNlRIRlpMb21O?=
 =?utf-8?B?N3hqRDMxdnVHN1BCVFdKc0drMEZ1TFc4K1NYQnMzYi9ieWtJa05YTnNpM0s4?=
 =?utf-8?B?TXI4WXdUWUx1TkdHS2h3ZExyVVVxZ0FBcXRsTUIvendBaG1hWjVxVms0NDFh?=
 =?utf-8?B?QVMrSDBUUWplWWNTbVUweVRFcW54aEdJeFVWdmMxcStlLzJGN0RiQ25BWnFz?=
 =?utf-8?B?SExkMDFIWkRZVzJ1QUIwblFaQndtTHFTU1gvRU51K2JqZnhBQnNtMmZqeEN1?=
 =?utf-8?B?d3FJY3Y3MlAzcHEydlRBVXVmazRVdmFZOG5CQmtrZjlJOVlic0txN3hVeXlV?=
 =?utf-8?B?VFFWZ0tnN3FoVk9XVGZDOTF5OFllbFRNTndzdm91VzRZUS82MXlkdUNBVVFl?=
 =?utf-8?B?ZmRKc3UxdzQ2TmFCakE4OVM0OUNPTkN0TktsL21WZW5Wdm1yOVNIZ0x1eDZz?=
 =?utf-8?B?aUMzbDZLcVVEcy9lUGJhTXRYejV3ZFZPY3Z2dXNkZFFLNkpWeEpzaWNJTko1?=
 =?utf-8?B?Zk9GY2hpa2s2RFN2Vktzd0V2OUl5V0xsSmRFYW1xREo2OFVzVFR0M3lxSTB0?=
 =?utf-8?B?MEE1cnhwZXRoYXkrTFRpUkZoTm1ocWxQYVhiUnVRTmhKcUJQU0pYUDJiR2lX?=
 =?utf-8?B?Y21obTViQ1VJd1ovUzNUQXlpUVJnS1BYUWxFc2hPcmJWYVA4YzVIK2l1b2c2?=
 =?utf-8?B?QVQ0UW1uZ28rSW9XNitodnpzMnRzY050TjVuODdqK1hTNTRiSC83c0xiVS92?=
 =?utf-8?B?ZHdDU3o2bDgrSUFNK0NQdFhtcDRyakg0WnpoOEowOW0xYnhxWkthQnJobEto?=
 =?utf-8?B?cFQ3ZDFSVFE4VjJRS2JTNnhVeG4wZVpMVkpaeWNNZDFiSDVzWDlvS2ltT2M0?=
 =?utf-8?B?S2NxS2lIeSsvMys1SnlFR0VKTTBCRVhNL0VDeWF4Lzk0OXJBZmpxSFhlUE1D?=
 =?utf-8?B?aFdGbVE1Q0xIS2ozQVBTcndnM2pCUmVRY0piQjZVUzZYU3dyNnJ3VjJhcUVS?=
 =?utf-8?B?WTBDWXVDT0JKcmt6bTdPN1lqeExwZndJTmxYZEhEekZqdFJqWFdUUDJoWnlB?=
 =?utf-8?B?NmMwRUhCOUYvNGYyUlVEa2ZodUVna0hCelJvd2xES1BDT0R2U2ZJZFBFOERS?=
 =?utf-8?B?VTFaY0hjUmZjLzMzY3MxamxybjZtVGVaWW9SWktPVURHbEpBSm1PcFZjbnFz?=
 =?utf-8?B?S0JqVzlQUS9HdWtCejBnYU8xKzVTTW9DVkZBLzdub1hmbWlSL000di9PUE1T?=
 =?utf-8?B?Q0VIeSt1WUE5d1RRNEdnaEZQVnRwWWoySWFaYzBvSzQzYzNzUWcvRlJXa2JM?=
 =?utf-8?B?amx0MGp2YzhwdFZaYjFhZ0F6V3kwa1lVN3ZjeWdDYW5jU25vRUgxRkxpUHF3?=
 =?utf-8?B?Tm85ZS9UelExSUR3TFpWNlpzWTRER3BRbU8zQ3lTb1FCcGUwRE5wSURDakNk?=
 =?utf-8?B?aHdTR1A5bjNBdXljVzR4WUc2V2NxcXRMcUhZaEZrWUtmQ0RCNmg1YVY3dldL?=
 =?utf-8?B?M3I2eWpVMk4rOWlEb09RNVd0Q2lPVmR1ZlhUVmtmbkVwSzRJRVlaaklVNWZD?=
 =?utf-8?B?VTBYMkM4cU9iaGk3ckcxdVdzVFFjMUJhOVEyaHJRU0xsWE5rQ29uVEpxaE5n?=
 =?utf-8?B?ZmVlek5ibDB6QUMxSldkZHN1SHV1bTRFdFJINGlPNHMyZ1JFVFBiQmV4Wnk0?=
 =?utf-8?B?bmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a116aab-f637-4ea3-fffb-08dbd60c5ab8
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 10:14:35.5705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lrmT9G/LFR4pemTZ3B2k3BoUMxkjyQd5kGvcAF6GJdc/wakeoyQBSstEcEGf0inkkPJP3Gr2DCMLdES3teT67lTvXruQMFn6Ne8WbxR5MEc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5832
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 03:15:27 -0700 (PDT)


On 26.10.2023 05:01, Ratheesh Kannoth wrote:
> Error code strings are not getting printed properly
> due to holes. Print error code as well.
> 
> Fixes: 51afe9026d0c ("octeontx2-pf: NIX TX overwrites SQ_CTX_HW_S[SQ_INT]")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  | 65 ++++++++++---------
>  .../marvell/octeontx2/nic/otx2_struct.h       | 34 +++++-----
>  2 files changed, 51 insertions(+), 48 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 6daf4d58c25d..e82724f69406 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -1193,31 +1193,32 @@ static char *nix_mnqerr_e_str[NIX_MNQERR_MAX] = {
>  };
>  
>  static char *nix_snd_status_e_str[NIX_SND_STATUS_MAX] =  {
> -	"NIX_SND_STATUS_GOOD",
> -	"NIX_SND_STATUS_SQ_CTX_FAULT",
> -	"NIX_SND_STATUS_SQ_CTX_POISON",
> -	"NIX_SND_STATUS_SQB_FAULT",
> -	"NIX_SND_STATUS_SQB_POISON",
> -	"NIX_SND_STATUS_HDR_ERR",
> -	"NIX_SND_STATUS_EXT_ERR",
> -	"NIX_SND_STATUS_JUMP_FAULT",
> -	"NIX_SND_STATUS_JUMP_POISON",
> -	"NIX_SND_STATUS_CRC_ERR",
> -	"NIX_SND_STATUS_IMM_ERR",
> -	"NIX_SND_STATUS_SG_ERR",
> -	"NIX_SND_STATUS_MEM_ERR",
> -	"NIX_SND_STATUS_INVALID_SUBDC",
> -	"NIX_SND_STATUS_SUBDC_ORDER_ERR",
> -	"NIX_SND_STATUS_DATA_FAULT",
> -	"NIX_SND_STATUS_DATA_POISON",
> -	"NIX_SND_STATUS_NPC_DROP_ACTION",
> -	"NIX_SND_STATUS_LOCK_VIOL",
> -	"NIX_SND_STATUS_NPC_UCAST_CHAN_ERR",
> -	"NIX_SND_STATUS_NPC_MCAST_CHAN_ERR",
> -	"NIX_SND_STATUS_NPC_MCAST_ABORT",
> -	"NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
> -	"NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
> -	"NIX_SND_STATUS_SEND_STATS_ERR",
> +	[NIX_SND_STATUS_GOOD] = "NIX_SND_STATUS_GOOD",
> +	[NIX_SND_STATUS_SQ_CTX_FAULT] = "NIX_SND_STATUS_SQ_CTX_FAULT",
> +	[NIX_SND_STATUS_SQ_CTX_POISON] = "NIX_SND_STATUS_SQ_CTX_POISON",
> +	[NIX_SND_STATUS_SQB_FAULT] = "NIX_SND_STATUS_SQB_FAULT",
> +	[NIX_SND_STATUS_SQB_POISON] = "NIX_SND_STATUS_SQB_POISON",
> +	[NIX_SND_STATUS_HDR_ERR] = "NIX_SND_STATUS_HDR_ERR",
> +	[NIX_SND_STATUS_EXT_ERR] = "NIX_SND_STATUS_EXT_ERR",
> +	[NIX_SND_STATUS_JUMP_FAULT] = "NIX_SND_STATUS_JUMP_FAULT",
> +	[NIX_SND_STATUS_JUMP_POISON] = "NIX_SND_STATUS_JUMP_POISON",
> +	[NIX_SND_STATUS_CRC_ERR] = "NIX_SND_STATUS_CRC_ERR",
> +	[NIX_SND_STATUS_IMM_ERR] = "NIX_SND_STATUS_IMM_ERR",
> +	[NIX_SND_STATUS_SG_ERR] = "NIX_SND_STATUS_SG_ERR",
> +	[NIX_SND_STATUS_MEM_ERR] = "NIX_SND_STATUS_MEM_ERR",
> +	[NIX_SND_STATUS_INVALID_SUBDC] = "NIX_SND_STATUS_INVALID_SUBDC",
> +	[NIX_SND_STATUS_SUBDC_ORDER_ERR] = "NIX_SND_STATUS_SUBDC_ORDER_ERR",
> +	[NIX_SND_STATUS_DATA_FAULT] = "NIX_SND_STATUS_DATA_FAULT",
> +	[NIX_SND_STATUS_DATA_POISON] = "NIX_SND_STATUS_DATA_POISON",
> +	[NIX_SND_STATUS_NPC_DROP_ACTION] = "NIX_SND_STATUS_NPC_DROP_ACTION",
> +	[NIX_SND_STATUS_LOCK_VIOL] = "NIX_SND_STATUS_LOCK_VIOL",
> +	[NIX_SND_STATUS_NPC_UCAST_CHAN_ERR] = "NIX_SND_STATUS_NPC_UCAST_CHAN_ERR",
> +	[NIX_SND_STATUS_NPC_MCAST_CHAN_ERR] = "NIX_SND_STATUS_NPC_MCAST_CHAN_ERR",
> +	[NIX_SND_STATUS_NPC_MCAST_ABORT] = "NIX_SND_STATUS_NPC_MCAST_ABORT",
> +	[NIX_SND_STATUS_NPC_VTAG_PTR_ERR] = "NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
> +	[NIX_SND_STATUS_NPC_VTAG_SIZE_ERR] = "NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
> +	[NIX_SND_STATUS_SEND_MEM_FAULT] = "NIX_SND_STATUS_SEND_MEM_FAULT",
> +	[NIX_SND_STATUS_SEND_STATS_ERR] = "NIX_SND_STATUS_SEND_STATS_ERR",
>  };
>  
>  static irqreturn_t otx2_q_intr_handler(int irq, void *data)
> @@ -1282,8 +1283,8 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			goto chk_mnq_err_dbg;
>  
>  		sq_op_err_code = FIELD_GET(GENMASK(7, 0), sq_op_err_dbg);
> -		netdev_err(pf->netdev, "SQ%lld: NIX_LF_SQ_OP_ERR_DBG(%llx)  err=%s\n",
> -			   qidx, sq_op_err_dbg, nix_sqoperr_e_str[sq_op_err_code]);
> +		netdev_err(pf->netdev, "SQ%lld: NIX_LF_SQ_OP_ERR_DBG(0x%llx)  err=%s(%#x)\n",
> +			   qidx, sq_op_err_dbg, nix_sqoperr_e_str[sq_op_err_code], sq_op_err_code);
>  
>  		otx2_write64(pf, NIX_LF_SQ_OP_ERR_DBG, BIT_ULL(44));
>  
> @@ -1300,16 +1301,18 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			goto chk_snd_err_dbg;
>  
>  		mnq_err_code = FIELD_GET(GENMASK(7, 0), mnq_err_dbg);
> -		netdev_err(pf->netdev, "SQ%lld: NIX_LF_MNQ_ERR_DBG(%llx)  err=%s\n",
> -			   qidx, mnq_err_dbg,  nix_mnqerr_e_str[mnq_err_code]);
> +		netdev_err(pf->netdev, "SQ%lld: NIX_LF_MNQ_ERR_DBG(0x%llx)  err=%s(%#x)\n",
> +			   qidx, mnq_err_dbg,  nix_mnqerr_e_str[mnq_err_code], mnq_err_code);
>  		otx2_write64(pf, NIX_LF_MNQ_ERR_DBG, BIT_ULL(44));
>  
>  chk_snd_err_dbg:
>  		snd_err_dbg = otx2_read64(pf, NIX_LF_SEND_ERR_DBG);
>  		if (snd_err_dbg & BIT(44)) {
>  			snd_err_code = FIELD_GET(GENMASK(7, 0), snd_err_dbg);
> -			netdev_err(pf->netdev, "SQ%lld: NIX_LF_SND_ERR_DBG:0x%llx err=%s\n",
> -				   qidx, snd_err_dbg, nix_snd_status_e_str[snd_err_code]);
> +			netdev_err(pf->netdev,
> +				   "SQ%lld: NIX_LF_SND_ERR_DBG:0x%llx err=%s(%#x)\n",
> +				   qidx, snd_err_dbg, nix_snd_status_e_str[snd_err_code],
> +				   snd_err_code);
>  			otx2_write64(pf, NIX_LF_SEND_ERR_DBG, BIT_ULL(44));
>  		}
>  
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_struct.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_struct.h
> index fa37b9f312ca..4e5899d8fa2e 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_struct.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_struct.h
> @@ -318,23 +318,23 @@ enum nix_snd_status_e {
>  	NIX_SND_STATUS_EXT_ERR = 0x6,
>  	NIX_SND_STATUS_JUMP_FAULT = 0x7,
>  	NIX_SND_STATUS_JUMP_POISON = 0x8,
> -	NIX_SND_STATUS_CRC_ERR = 0x9,
> -	NIX_SND_STATUS_IMM_ERR = 0x10,
> -	NIX_SND_STATUS_SG_ERR = 0x11,
> -	NIX_SND_STATUS_MEM_ERR = 0x12,
> -	NIX_SND_STATUS_INVALID_SUBDC = 0x13,
> -	NIX_SND_STATUS_SUBDC_ORDER_ERR = 0x14,
> -	NIX_SND_STATUS_DATA_FAULT = 0x15,
> -	NIX_SND_STATUS_DATA_POISON = 0x16,
> -	NIX_SND_STATUS_NPC_DROP_ACTION = 0x17,
> -	NIX_SND_STATUS_LOCK_VIOL = 0x18,
> -	NIX_SND_STATUS_NPC_UCAST_CHAN_ERR = 0x19,
> -	NIX_SND_STATUS_NPC_MCAST_CHAN_ERR = 0x20,
> -	NIX_SND_STATUS_NPC_MCAST_ABORT = 0x21,
> -	NIX_SND_STATUS_NPC_VTAG_PTR_ERR = 0x22,
> -	NIX_SND_STATUS_NPC_VTAG_SIZE_ERR = 0x23,
> -	NIX_SND_STATUS_SEND_MEM_FAULT = 0x24,
> -	NIX_SND_STATUS_SEND_STATS_ERR = 0x25,
> +	NIX_SND_STATUS_CRC_ERR = 0x10,> +	NIX_SND_STATUS_IMM_ERR = 0x11,
> +	NIX_SND_STATUS_SG_ERR = 0x12,
> +	NIX_SND_STATUS_MEM_ERR = 0x13,
> +	NIX_SND_STATUS_INVALID_SUBDC = 0x14,
> +	NIX_SND_STATUS_SUBDC_ORDER_ERR = 0x15,
> +	NIX_SND_STATUS_DATA_FAULT = 0x16,
> +	NIX_SND_STATUS_DATA_POISON = 0x17,

There is a gap here, is it intended?
And in general, why error codes were changed?
Starting from NIX_SND_STATUS_CRC_ERR which was 0x09 and now it's 0x10.

> +	NIX_SND_STATUS_NPC_DROP_ACTION = 0x20,
> +	NIX_SND_STATUS_LOCK_VIOL = 0x21,
> +	NIX_SND_STATUS_NPC_UCAST_CHAN_ERR = 0x22,
> +	NIX_SND_STATUS_NPC_MCAST_CHAN_ERR = 0x23,
> +	NIX_SND_STATUS_NPC_MCAST_ABORT = 0x24,
> +	NIX_SND_STATUS_NPC_VTAG_PTR_ERR = 0x25,
> +	NIX_SND_STATUS_NPC_VTAG_SIZE_ERR = 0x26,
> +	NIX_SND_STATUS_SEND_MEM_FAULT = 0x27,
> +	NIX_SND_STATUS_SEND_STATS_ERR = 0x28,
>  	NIX_SND_STATUS_MAX,
>  };
>