Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp333447rdh; Thu, 26 Oct 2023 03:42:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOpD9ptkB2F9ppWoCfbmQBaWSlT8RJYvo+OA50sZQGD4bip0MsbsvTH9kn9z/ZF0gF+pxq X-Received: by 2002:a0d:cd05:0:b0:5a8:1d18:a16 with SMTP id p5-20020a0dcd05000000b005a81d180a16mr18544223ywd.36.1698316940899; Thu, 26 Oct 2023 03:42:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698316940; cv=none; d=google.com; s=arc-20160816; b=zMPrKZ0dmOKj9k6x/0UgP4juF/XSRgUAI6WMckwWq7IYKKJt3GdmRYBGWTyaq0CD+h YfI6lR3XGIEhgV6gfHSrQr5f62kf/3ZttnGCSc+1CxJFeIN5d/qPzFaHQb1Mccfut2Uu EpSbFopZeuod2F1R+s3aq6ncF0XfF1rJ3rtmfohS1H7g7g4vZanjUmvxjktZV5rq54De qYcATrzLRwXOjcK4xZvo69364Z6lnXIJTIcF2vH4tDHmX7RNkF0UiDQKFHqa+2RfbHRY mNsCdneWkBn7vatzgMmmrV4ore3l2SKpjuJbYJXezSZ+8pY4H4/G75Wttqs3Z45lxYSt jrbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=7FO3bXg4jaYqWVw7SUw9GVHbeVNPGlx4JKNogiekb4w=; fh=0GQDSxykeLgRwmrHkUZ9jyOse/Zvi+zOzBe9zh1Wo7Y=; b=1LCJ1miXvsblatU6tl4ZAMO7piEE7Dj9ZoHu3xzUF50SDpB6XZVNUvu/gCPpSnfuIU JnK73cATssnZVNyA3KLKYvR/hb51th9OOhpemBALN6oiLxpnsUJ4yHdO4zf/O8FoyYNp hLc8pqDjxfepsCPVxAZB4eyUmy6w/csnvQVly0XA0xpIGFnqwTtO27Z66BwquaODbjQt a3BNGtYc6L1J33J9H/Y/n40jSdWO2A63imtsVTD5fgtaYKnmq8j6KTaNrYVS08ytKUHL AvrypmuqeIjVzgmG9YL2tVd8DNeusoCGoE79GAKogkGQpG4pCogCt0SZ/w77Lec5e0AK kmmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=nuNiebBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id eh27-20020a05690c299b00b005a9167cc4eesi15181351ywb.123.2023.10.26.03.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 03:42:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=nuNiebBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 47CD382C2DAC; Thu, 26 Oct 2023 03:42:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235016AbjJZKl5 (ORCPT + 99 others); Thu, 26 Oct 2023 06:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234902AbjJZKlz (ORCPT ); Thu, 26 Oct 2023 06:41:55 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4DF91B2; Thu, 26 Oct 2023 03:41:49 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id F20F824000B; Thu, 26 Oct 2023 10:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1698316908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7FO3bXg4jaYqWVw7SUw9GVHbeVNPGlx4JKNogiekb4w=; b=nuNiebBs72L1ynsy2Kldz2/h12GOsQYrI8XbztCaRZlHCO+74uJ1qjaiLXX9heZSnEvVf3 AJPBvI8zVv0oqF/xzmyHPW0kpZSW+x9Jvv/CuOn5DBTMpDsR5IuLjazzEHqMQvsQgD/QM1 BE97roaofc9OeBsJXP537pvNtmv8WSVgGb5rjcBi9kBuZqZ/AD/I6SVe6MLMXexaLybEuM v+jl67/WdATJFIwE1fWNF8INxAltZF6dHD+4bGkATvgYGzDoP+y7oig8xRl4sFMv8i8vvF o/OpRYGoY8ADus4Q2dCxDuNn57XTLgpnaGp2exuR60E7A1e6wYTkwDqmWiqwRA== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: [PATCH 0/6] Cleanup AMBA PL011 driver Date: Thu, 26 Oct 2023 12:41:17 +0200 Message-Id: <20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAE1COmUC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2NDINbNTcqp1C1NLCrRTUxLTkxOSrK0SLNIUgKqLyhKTcusAJsVHVtbCwB 74cndWwAAAA== To: Russell King , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij , Gregory CLEMENT , Alexandre Belloni , Thomas Petazzoni , Vladimir Kondratiev , Tawfik Bayouk , =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: b4 0.12.3 X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 26 Oct 2023 03:42:12 -0700 (PDT) Hi, While adding upstream support to a new platform (Mobileye EyeQ5[1]) that uses the AMBA PL011 driver, I took some time to look at the PL011 driver and ended up with a few patches that cleanup parts of it. The line-diff is big mostly because of the checkpatch-fixing commits. The driver hadn't received any love for quite some time. A single commit changes the code's behavior: see "tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options". See commit messages for more information. [1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@intel.com/T/ Have a nice day, Théo Lebrun Signed-off-by: Théo Lebrun --- Théo Lebrun (6): tty: serial: amba: cleanup whitespace tty: serial: amba: Use BIT() macro for constant declarations tty: serial: amba-pl011: cleanup driver tty: serial: amba-pl011: replace TIOCMBIT macros by static functions tty: serial: amba-pl011: unindent pl011_console_get_options function body tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options drivers/tty/serial/amba-pl011.c | 238 ++++++++++++++++++++-------------------- include/linux/amba/serial.h | 192 ++++++++++++++++---------------- 2 files changed, 214 insertions(+), 216 deletions(-) --- base-commit: ad582615776e62e365ab2dfa7a7a3806ada28b30 change-id: 20231023-mbly-uart-afcacbb98f8b Best regards, -- Théo Lebrun