Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765449AbXKUA7w (ORCPT ); Tue, 20 Nov 2007 19:59:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756637AbXKUA7m (ORCPT ); Tue, 20 Nov 2007 19:59:42 -0500 Received: from idcmail-mo1so.shaw.ca ([24.71.223.10]:34441 "EHLO pd3mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910AbXKUA7l (ORCPT ); Tue, 20 Nov 2007 19:59:41 -0500 Date: Tue, 20 Nov 2007 18:59:04 -0600 From: Robert Hancock Subject: Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode In-reply-to: <473BA4D8.508@gmail.com> To: Tejun Heo Cc: linux-kernel , ide , Jeff Garzik Message-id: <474382D8.1050507@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit References: <473A7628.3010907@shaw.ca> <473BA447.6090909@gmail.com> <473BA4D8.508@gmail.com> User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 25 Tejun Heo wrote: > Tejun Heo wrote: >> If so, can you please add that switching into register mode is okay as >> long as there's no other ADMA commands in flight and add >> WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)? > > More accurately, link->sactive test can be substituted with > (ap->qc_allocated & ~(1 << qc->tag)). Unfortunately we only get the ata_port and ata_taskfile in the tf_read callback, so I'm not sure if we can do the equivalent of the qc->flags & ATA_QCFLAG_RESULT_TF test (i.e. distinguishing between the error-handling case where we care if we abort outstanding commands and the normal case with a RESULT_TF command where we do).. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/