Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231025142609.2869769-1-vamshigajjela@google.com>
 <7e7eb495-8e54-49f3-bab7-0de72b2cf7b6@kernel.org> <b86df0e0-ba54-232-1854-bf3d1cbbe479@linux.intel.com>
 <3bd3d362-94c5-4d50-9404-0e4f6a3dec21@kernel.org>
In-Reply-To: <3bd3d362-94c5-4d50-9404-0e4f6a3dec21@kernel.org>
From:   VAMSHI GAJJELA <vamshigajjela@google.com>
Date:   Thu, 26 Oct 2023 18:00:01 +0530
Message-ID: <CAMTSyjoE+3B=ACLW4=Pz-otu4q7fMU1OXE-fmTdvVu569906Tw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] serial: core: Update uart_poll_timeout() function
 to return unsigned long
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, manugautam@google.com,
        Subhash Jadavani <sjadavani@google.com>,
        Channa Kadabi <kadabi@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 26, 2023 at 3:19=E2=80=AFPM Jiri Slaby <jirislaby@kernel.org> w=
rote:
>
> On 26. 10. 23, 11:24, Ilpo J=C3=A4rvinen wrote:
> > On Thu, 26 Oct 2023, Jiri Slaby wrote:
> >
> >> On 25. 10. 23, 16:26, Vamshi Gajjela wrote:
> >>> From: VAMSHI GAJJELA <vamshigajjela@google.com>
> >>>
> >>> The function uart_fifo_timeout() returns an unsigned long value, whic=
h is
> >>> the number of jiffies. Therefore, the function uart_poll_timeout() ha=
s been
> >>> modified to use an unsigned long type for timeout values instead of a=
n int
> >>> and to avoid truncation.
> >>
> >> Hi,
> >>
> >> there is no truncation possible, right?
> >
> > That's very likely true (I didn't run the calculations), thus it's corr=
ect
> > to not have Fixes tag.
>
> Good. I would remove that "and to avoid truncation" completely from the
> commit log. I would only say that we are getting things consistent.
>
> "avoid truncation" can lead to -> we should backport it to stable. And
> neither is true.
I will drop "and to avoid truncation".
>
> > It's more about having consistent typing since
> > we're talking about jiffies, so unsigned long as usual.
>
> Yeah and that's of course fine by me.
>
> thanks,
> --
> js
> suse labs
>