Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632
MIME-Version: 1.0
Message-Id: <a7e3fdcd-d5e6-4261-85be-3ec1221edf24@app.fastmail.com>
In-Reply-To: <20230921110424.215592-1-bhe@redhat.com>
References: <20230921110424.215592-1-bhe@redhat.com>
Date:   Thu, 26 Oct 2023 13:36:13 +0100
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Baoquan He" <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-arch@vger.kernel.org, linux-mm@kvack.org,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Arnd Bergmann" <arnd@arndb.de>, mpe@ellerman.id.au,
        "Geert Uytterhoeven" <geert@linux-m68k.org>,
        "Luis Chamberlain" <mcgrof@kernel.org>, hch@infradead.org,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Florian Fainelli" <f.fainelli@gmail.com>, deller@gmx.de
Subject: Re: [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82023=E5=B9=B49=E6=9C=8821=E6=97=A5=E4=B9=9D=E6=9C=88 =E4=B8=8B=E5=
=8D=8812:04=EF=BC=8CBaoquan He=E5=86=99=E9=81=93=EF=BC=9A
> This patchset tries to remove ioremap_uc() in the current architectures
> except of x86 and ia64. They will use the default ioremap_uc version
> in <asm-generic/io.h> which returns NULL. Anyone who wants to add new
> invocation of ioremap_uc(), please consider using ioremap() instead or
> adding a new ARCH specific ioremap_uc(), or refer to the callsite
> in drivers/video/fbdev/aty/atyfb_base.c.
>
> This change won't cuase breakage to the current kernel because in the
> only ioremap_uc callsite, an adjustment is made to eliminate impact in
> patch 1 of this series.
>
> To get rid of all of them other than x86 and ia64, add asm-generic/io.h
> to asm/io.h of mips ARCH. With this adding, we can get rid of the
> ioremap_uc() in mips too. This is done in patch 2. And a followup patch
> 4 is added to remove duplicated code according to Arnd's suggestion.
>
> Test:
> =3D=3D=3D=3D=3D
> Except of Jiaxun's efficient testing on patch 2/4, I also did cross co=
mpiling
> of this series on mips64, building passed.
>

For whole series:

Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Hi Arnd and Thomas,

I've got some work pending based on this series, however I'm unclear abo=
ut
which tree this series will go since both of you give acked-by.

Given that there are some tree-wide modifications, I guess it should go =
into
Arnd's asm-generic tree?

Thanks
--=20
- Jiaxun