Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <7ccf21c4-511c-4de6-bc02-4a936b020a10@linux.ibm.com>
Date:   Thu, 26 Oct 2023 09:16:42 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/3] s390/vfio-ap: unpin pages on gisc registration
 failure
Content-Language: en-US
To:     Christian Borntraeger <borntraeger@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     jjherne@linux.ibm.com, pasic@linux.ibm.com, frankja@linux.ibm.com,
        imbrenda@linux.ibm.com, david@redhat.com,
        Matthew Rosato <mjrosato@linux.ibm.com>, stable@vger.kernel.org
References: <20231018133829.147226-1-akrowiak@linux.ibm.com>
 <20231018133829.147226-2-akrowiak@linux.ibm.com>
 <c6951c45-b091-11a6-5684-ba2ef0c94df3@linux.ibm.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
In-Reply-To: <c6951c45-b091-11a6-5684-ba2ef0c94df3@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/26/23 08:18, Christian Borntraeger wrote:
> 
> 
> Am 18.10.23 um 15:38 schrieb Tony Krowiak:
>> From: Anthony Krowiak <akrowiak@linux.ibm.com>
>>
>> In the vfio_ap_irq_enable function, after the page containing the
>> notification indicator byte (NIB) is pinned, the function attempts
>> to register the guest ISC. If registration fails, the function sets the
>> status response code and returns without unpinning the page containing
>> the NIB. In order to avoid a memory leak, the NIB should be unpinned 
>> before
>> returning from the vfio_ap_irq_enable function.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> 
> Where is Janoschs signed off coming from here?

Janosch found this and composed the patch originally. I just tweaked the 
description and posted it.

> 
>> Signed-off-by: Anthony Krowiak <akrowiak@linux.ibm.com>
>> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
>> Fixes: 783f0a3ccd79 ("s390/vfio-ap: add s390dbf logging to the 
>> vfio_ap_irq_enable function")
>> Cc: <stable@vger.kernel.org>
>> ---
>>   drivers/s390/crypto/vfio_ap_ops.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/s390/crypto/vfio_ap_ops.c 
>> b/drivers/s390/crypto/vfio_ap_ops.c
>> index 4db538a55192..9cb28978c186 100644
>> --- a/drivers/s390/crypto/vfio_ap_ops.c
>> +++ b/drivers/s390/crypto/vfio_ap_ops.c
>> @@ -457,6 +457,7 @@ static struct ap_queue_status 
>> vfio_ap_irq_enable(struct vfio_ap_queue *q,
>>           VFIO_AP_DBF_WARN("%s: gisc registration failed: nisc=%d, 
>> isc=%d, apqn=%#04x\n",
>>                    __func__, nisc, isc, q->apqn);
>> +        vfio_unpin_pages(&q->matrix_mdev->vdev, nib, 1);
>>           status.response_code = AP_RESPONSE_INVALID_GISA;
>>           return status;
>>       }