Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <04a9185e-070e-48fb-ae54-65bf63dd1ed1@amd.com>
Date:   Thu, 26 Oct 2023 09:21:29 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-kernel@vger.kernel.org, bp@alien8.de,
        mchehab@kernel.org, Muralidhara M K <muralidhara.mk@amd.com>
Subject: Re: [PATCH 0/7] Address Translation support for MI200 and MI300
 models
To:     Muralidhara M K <muralimk@amd.com>, linux-edac@vger.kernel.org,
        x86@kernel.org
References: <20231025073339.630093-1-muralimk@amd.com>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231025073339.630093-1-muralimk@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUlTbG03K1I0cDNON1Z6bi9vOUpKOHU2cGNVdHJYaWw5d0w1RUU5NVNkdXlP?=
 =?utf-8?B?ODJXRFZ2UFFzTmFZNGNjQWVYdzZhVXdvMFZqQStPNEoramdXV25QRFZhT00z?=
 =?utf-8?B?WFZsQldQbFVWMWNWV2tGSmJoeC9NVXZlSElhSEhYbmJqVzdmbkNEMzNJbGx6?=
 =?utf-8?B?eUxMVC9hdDV6U2dFU0VnN0UyczJ1ZXF0Q0tMRFFLZ245WUdqcTJxTXZhdGpU?=
 =?utf-8?B?aWNwU0tPMzBEVjA3SlhLdGVEYytMMEZpOVRaU2N5aEQwNlF6NkpyM2Q0alFG?=
 =?utf-8?B?U0FPOTA0dFVLdFJvUUpJakpiRlNmVFRmOWtDTitTSmRsSWh6dU9DeEUvNU1w?=
 =?utf-8?B?K3hzbXlFR29QUkxXYTZBMGtoU08vUEgrTm0yUVE1R0U0c1BVcTNRWldqNmg2?=
 =?utf-8?B?bmVwbVViVUUreG14OGZUanNLOWt4Mll0TS81SnExbVpMZThsRnE3OTBlUE1F?=
 =?utf-8?B?OHZWeFJPMVFRVmNTckVpZGZqZGQvYjZaWGFMTXVxbWdWT3VyVWRDWDY5SlVr?=
 =?utf-8?B?em5rRWUzbWlyallxc3hlblBoaS9pT0pDOEprMXd0eGlMVDJidjYyOWFaMVpa?=
 =?utf-8?B?NTdhR3FmZDVIWDJtTXN3Qm9OTDJyQU1rN09FWmZRZTBRdXBKbGxEMVA0STRT?=
 =?utf-8?B?aTFYVm5iN205elNjU1dscHNHK044RWE2aXJPVzVlZDIvR2dKNDNPc2tPYUI4?=
 =?utf-8?B?dmhCMXR6TkFBb2thV0lCYlQzdFJuQk9MT1dYaUlPamRJS1VUR0R2SnRTTnlM?=
 =?utf-8?B?SDdjNGRRbEh2RVNPUXhKTXhaQUx6VmUvbDRaMUQ4NW5WUzFFMktXaXVFUWZ3?=
 =?utf-8?B?TjdSSnRMbFU4Q0IwRFBkOUxBT3F3SmpnV0h4eUF0eHVWVTJIUExjNDZIUmFG?=
 =?utf-8?B?c2djeFZNYzVuM3FNam1YWXJXblJIdXYyanlWTkY0cUJqVDNKU3Vuc1Znek1B?=
 =?utf-8?B?VDVYd3c4ak1aanBpT3NsTTE5NEdlQ1ZvQThxMzArWjdVcHlrbjg5Y0g5VkRk?=
 =?utf-8?B?UG0rempzNDdVTG5KVjZGc1BIUFRLdVdrVGxsM3BoejVnejFBWm9kUXJKbFUr?=
 =?utf-8?B?VkRGUDR0d3dhdmovSW9BVzhoTEhTOHNLSDhjSnlPUVJuM284U3hKMTdPaGRZ?=
 =?utf-8?B?Zms5NjJ6YXZlNk9RV003b1lZZHExSHpTcDVyQWxMWTg3NmxrNVJzSUkwNkZ3?=
 =?utf-8?B?TzJ5SENZTU5ab0U0UnAvNXFNdHUzQll4U25oaFpQVzNBa2Q3UkxRTnQzZVBU?=
 =?utf-8?B?NEhyZWdBU1NuL25HZDZpcWVxbHkyK3BCWVhQS2IySVNFOU5FdzdTS1NrRVQ3?=
 =?utf-8?B?M3p0RWpPTGVnTU04Q28vS01tZjVidlZNbTE3RXMvL1BDd1BUYjhYZzJGdnFv?=
 =?utf-8?B?aGgwelNqK0dSMnZ3aFZzM1IzK0FNUVFMdndhWDFZRzhnb3hTdUhsanRRb0Mv?=
 =?utf-8?B?MVIwTUVFdEhBc0RFWGo3NUVTUUk5L0E5S0JWS3lpa3Y1a3hiQTRWd3MycFBO?=
 =?utf-8?B?YUdKM1BYK2M0WElpMlJyMFlOSDhrdUNiZWxRY1JPeGU0K0ZmNHB2TitXL3VH?=
 =?utf-8?B?NUdsVWNZMW5UMTVScG1vb1d0U0kxSTlIVnc4UVZSamJ3dXlpSktiaytOaXZm?=
 =?utf-8?B?U2NobDZ2eDhCNllEYzRiNGkvNzlrMi9RSDlZOWk1djRyNFpwK0Y2bWxNSkFK?=
 =?utf-8?B?cEJnSDRaTjA5aUdIVGxiM3dYTzZyMGxpc3NGMW9zVWlwU3NZQ0srSkxhR3I3?=
 =?utf-8?B?YnJkWTdPcUlORHVIWEpJTmUxMjNuZkFXYXhSSldxQnVVNmFMbVBmVGJzcEEr?=
 =?utf-8?B?WWpOS0NzUldpRnUxcFZzZmYvSVZOVWJXQTNpZjZIOFpuZmo4bm94WnlMcGJH?=
 =?utf-8?B?N3B4RXh4NXc1SzNGeTZtVWJmbVdIRUpLenUrZ0lCUDBFcXNWWWlIdUticVZX?=
 =?utf-8?B?cjRmc3Aycm1QRDRzSjRKWHBmaEQ4UWlhcUtHa0hXcHM4b2pYQjhQYUdBQTFW?=
 =?utf-8?B?bXl5bmFkVXFuVnVDNDlnQlFSdnAvdXdKYlNZd0lIMS8zVFJqTnVKemtvenJS?=
 =?utf-8?B?cUtlemFPWll6d3lZZlJ0aGNhTFFsN2FCanE4eDlyOU1uYTNNQTZSSWhyWlNO?=
 =?utf-8?Q?dxRUVvFBhmVI7CTQ5bpmKY/K2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56499a20-3f6c-466f-1139-08dbd626787b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 13:21:32.4052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VIS/UQkTHo8xgvchqv1a4IoOEB9LHqk068t7hUjl7N0dBPaphfsKeLsaaUk4R4TskLu+EMlttm8WGl7vVRg+CQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6308
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 06:21:41 -0700 (PDT)

On 10/25/2023 3:33 AM, Muralidhara M K wrote:
> From: Muralidhara M K <muralidhara.mk@amd.com>
> 
> This patchset adds support for MI200 heterogeneous address translation support
> and MI300A address translation support, fixups on HBM3 memory address maps.
> 
> The patch set depends on the Yazen's patches submitted
> "AMD Address Translation Library"
> https://lore.kernel.org/linux-edac/20231005173526.42831-1-yazen.ghannam@amd.com/T/#m4a9ddb63b334f367219ab0002a9a133e891f6aac
> 
> The patchset does following
> 
> Patch 1:
> MI200 heterogeneous address translation support.
> 
> Patch 2:
> MI300 heterogeneous address translation support.
> 
> Patch 3:
> Convert HBM3 MCA Decoded address to Normalized address.
> 
> Patch 4:
> lookup table to get the correct cs instance id for HBM3.
> 
> Patch 5:
> Convert physical cs id to logical cs id by static lookup
> table.
> 
> Patch 6:
> Reading correct bit fields to get cs_fabric_id.

I expect some of these patches to be functionally out of order.

> 
> Patch 7:
> Identify all physical pages in a row to retire all 8 columns
> of pages when the error is injected to avoid future errors.
> 
> 
> Muralidhara M K (7):
>    RAS: Add Address Translation support for MI200
>    RAS: Add Address Translation support for MI300
>    RAS: Add MCA Error address conversion for UMC
>    RAS: Add static lookup table to get CS physical ID
>    RAS: Add fixed Physical to logical CS ID mapping table
>    RAS: Get CS fabirc ID register bit fields
>    EDAC/amd64: RAS: platform/x86/amd: Identify all physical pages in row
> 
>   drivers/edac/amd64_edac.c         |   5 +
>   drivers/ras/amd/atl/core.c        |   5 +-
>   drivers/ras/amd/atl/dehash.c      | 149 ++++++++++++++
>   drivers/ras/amd/atl/denormalize.c | 110 ++++++++++-
>   drivers/ras/amd/atl/internal.h    |  27 ++-
>   drivers/ras/amd/atl/map.c         | 158 ++++++++++++---
>   drivers/ras/amd/atl/reg_fields.h  |  42 +++-
>   drivers/ras/amd/atl/system.c      |   4 +
>   drivers/ras/amd/atl/umc.c         | 309 +++++++++++++++++++++++++++++-
>   include/linux/amd-atl.h           |   2 +
>   10 files changed, 778 insertions(+), 33 deletions(-)
> 

This set doesn't have any changes in arch/x86, so it's not necessary to 
copy the x86 list.

Thanks,
Yazen