Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <06f701e6-f74e-1dbd-d021-07a78523900c@amd.com>
Date:   Thu, 26 Oct 2023 08:37:29 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] x86/mm/cpa: Warn if set_memory_XXcrypted() fails
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "Reshetova, Elena" <elena.reshetova@intel.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "Cui, Dexuan" <decui@microsoft.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "mikelley@microsoft.com" <mikelley@microsoft.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "bp@alien8.de" <bp@alien8.de>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>
References: <20231024234829.1443125-1-rick.p.edgecombe@intel.com>
 <e30560cf-cb88-45de-963f-f99f9b06db75@linux.intel.com>
 <2a5e4fdb3f2d9f32262c0ba23f5535cf09559fc1.camel@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <2a5e4fdb3f2d9f32262c0ba23f5535cf09559fc1.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG13bzRVamdDSkdJTHlqWkZrQlNnbXRUdHZjN2tmSWxKYWcxS2RsYnFZY252?=
 =?utf-8?B?NSsxYjM0eGNTaWExVDlTYVVYVUNMSGhDdjIrZXlEN0hRTlpETXpxelVHUjBU?=
 =?utf-8?B?ZXZXbmx3bEZ1Q0JFTzVXL3JzVEJndGU1Nzh2cm40MXM1R0hPSXN2K291QzJm?=
 =?utf-8?B?TndDZFNybmZVeU5RWUpLR3Q3WVluVVBVck92Qkl5Vm5WcjdGSnVyNngxZXJX?=
 =?utf-8?B?VG5CeXdTSlRKQWFPRitmODdOa1o3OTA1YkpVWFlhWU1NRlYrMDJVTThmWUV5?=
 =?utf-8?B?d05qTW5Ua3RGMUwreFZxZ3UzSFZxUDI0Z2dIcmRzZDlHODJNQUJ0R1VHcU95?=
 =?utf-8?B?cE00SDZ1K3k5clZXNzdzSmdZUFRqS09ieWduRjVZYXI5ZllxQy9pWHJ3L3dH?=
 =?utf-8?B?Y1pyeEhqQzJ0cEFPS1MzOXJwTWhNZ0MwVElqREZVYWZqVjBjQThNZDhhR1VM?=
 =?utf-8?B?b01UR1h3aGZaR3NFazdlMStWUWtSMUVHS0xwNnh5VGVOWlAzeHEyUXZZZVZB?=
 =?utf-8?B?MXdNSEZYWGxSUmYwdmtMd3VEaCs5WGVDTlNhTTZla2FROTZCYnl1QlZxcVZu?=
 =?utf-8?B?Rko3T1c0Tmt1c2dZdStYMm44VjRLdUFxb1VSck9BVU1WTE92QjZOWnRyYVZQ?=
 =?utf-8?B?ME5Fb2ZXOXdRUGNJZGJDUStxWVVzTkFUd200dHJZbDVqV0pOVzZVR2lBbHQ4?=
 =?utf-8?B?bDUyOThKUm1LTk1rMjIrNldFQ1dDQXQ4NzBIb0VYT3hnbDVvSWJSdmw5TWlO?=
 =?utf-8?B?T2k1cHNzUS8wdGI0N05EWUVOYnNleVVzMjA0S0M0WTFTRk45UUcrTVFadmZo?=
 =?utf-8?B?b2xkb01VY2pHeXAyZ1JzeG1xc3FvaGlQSGpjam5kaG1jZkVGUTE5djdGVDV0?=
 =?utf-8?B?bStmQXg3cTl0N21tUHFSZEU1WkFobjcwZ2o4NTNaVnJZeG5PNHNpWElnS2Qx?=
 =?utf-8?B?ZmlmWUM1NjZZdFArZHlxMjJHRHErQjhzTlJkUXNlSU1PNVFoQTZDRVkxTUFE?=
 =?utf-8?B?VGFjMERHeWs5MC9qa2h6aE9IaWZqcUJVU3FkU3RuN044Y0NvRjYwb2wrUjlI?=
 =?utf-8?B?SXp6dEVGN0Vnd0JKMTZmT3g5SGFtMXBrMjNRYVJkcGJ2eEhGZ0VOVlVtVzFD?=
 =?utf-8?B?UEo4UzRlQ2oxNVprMy80bzRyQ1c0YkNtMUd1YVI4Z3I2Sm5JMnNMWW5VY1FJ?=
 =?utf-8?B?eVVQOWp4SXRaRjVwRGhEdkswT29ST2d0U1kwdER6YzF3aGZaM05iMkk4ZHNq?=
 =?utf-8?B?bDNmQVBUd28xN2w3UTVMNzIvc21KbU5tZFViWHJVdVo1ZWpJK3FGdEhvNjBG?=
 =?utf-8?B?UHh6clhhY2JudndIWEIzTGxDL0RXL25Ba1lMdHMvd2VDbFNjbzRPYnVkeVpC?=
 =?utf-8?B?NzZlcWxUNmluWlArZTd6SzJIZU9MeXlBSFlIdURWbkk4MTlRVTZLV3ZkZTUw?=
 =?utf-8?B?OFVBQStSN1B3anhYOG45VGxzYWdUSEg0di9rV05CdjYrc1UwNzFCL2ZiaVRV?=
 =?utf-8?B?bHJMcW11S2hwU01LL1BQcmRXSFRKbkhSV2NHcHgzTDAyVzlCdXd1Mm5TUG13?=
 =?utf-8?B?VGdtYy9PYWFqb1hFbWs4OVNmdG0yNXI0R2xSTk1Bb2I3TnRHdk9GNXFmNC9P?=
 =?utf-8?B?eWdsYUZCaitEb0pLb2V0cVFxV1lIVkIxVitmaUJIRmpoVzA5WUtucTFiQlJC?=
 =?utf-8?B?c1VMTERIMTdhVFpkWUdRMVZPVjZ3TGNwUkhDUjN3ZXJnOEVpcnBTdERWMWFK?=
 =?utf-8?B?R3VQNmMyd29qMlpBd0owcTdhNDBBd3BVdUlMdnVwSk5KTzVYc2VqWS92eWU3?=
 =?utf-8?B?UVpPYTBzOHJQL01aYlQ0cWluT0hlZWxjMmdTYmM3VjgzbEgrNUdGRU1ySnBM?=
 =?utf-8?B?NTEzQWRRMVZOM0Roa29obk9mdjFDY2VRbzF3RERXbTU5YjJpTmQ4Njk0TnRq?=
 =?utf-8?B?aHVaRjY2dndkalRFTm9CWENOZjZWQTVzK0tEQVBQSnErZ04xNjMxOU1rYy9C?=
 =?utf-8?B?ODl6Ri9mUEw2b096N0VselFxd2tUa0pVVElSWlVWQ0FhQzdGTXpEMitPU1BQ?=
 =?utf-8?B?bkVNem9udEQ5KzVWZ1Fmd05iL3dFdE8xS2JCdFdrcENVbW5OMjhUbDI3dG5J?=
 =?utf-8?Q?iwN57FTYanqtGNvR1gWIqxbZ0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2331988-395d-46e0-8f77-08dbd628b625
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 13:37:35.1693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pMA/OsXIm9rbR8czwEARuRhoE/0UXL9ECtDSyGlMKodp7JrINplM1h1sqW+XpZ4Vef3qwoFquemrYrvIONks0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7554
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 26 Oct 2023 06:38:07 -0700 (PDT)

On 10/25/23 21:04, Edgecombe, Rick P wrote:
> On Wed, 2023-10-25 at 11:10 -0700, Kuppuswamy Sathyanarayanan wrote:
>> Looks good to me.
>>
>> Reviewed-by: Kuppuswamy Sathyanarayanan
>> <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
> 
> Thanks!
> 
>>
>> IMO, you can avoid "out" label with (!ret && !x86_platform....)
>> check. But it is upto
>> you.
> 
> Hmm, yes it could. I think it's a little easier to read as is, but just
> my opinion as well.

It might be even easier to read to just have:

	if (ret)
		return ret;

	if (!x86_platform...)
		goto vmm_fail

	return 0;

since jumping to the out: label just does a return anyway.

Thanks,
Tom