Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <b9e88e33-7276-1930-5d85-9bbd740f06c8@amd.com>
Date:   Thu, 26 Oct 2023 08:43:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] x86/mm/cpa: Warn if set_memory_XXcrypted() fails
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "Reshetova, Elena" <elena.reshetova@intel.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "Cui, Dexuan" <decui@microsoft.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "mikelley@microsoft.com" <mikelley@microsoft.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "bp@alien8.de" <bp@alien8.de>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>
References: <20231024234829.1443125-1-rick.p.edgecombe@intel.com>
 <29564bbe-b7a0-fcc5-47ee-093a032a11b6@amd.com>
 <15e8b03ef471514d9347e8bffba4fdfa1ef4f3d7.camel@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <15e8b03ef471514d9347e8bffba4fdfa1ef4f3d7.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTlJZHdMZ2lteWJRNG1iMm04dkNmZk9mUFFoa1hici96dXhOb2xuMTRCbUZz?=
 =?utf-8?B?alFNdVZaME9SWWV0d1lWQUVjU29JZjJxRVF6YitlSFJpQlhOdU1Fd3dOR0Z1?=
 =?utf-8?B?Nndld0NjQTh4TUJlTUphY2wvUmQ4VHlJUVkyNmloRi9wcm1PNnQ5L3ArR2ZH?=
 =?utf-8?B?ZzBQUjZpNGVwS2NzdVN1eFVpSjNYeGRYWHhUaVBhcFUvQy9xSkdCdWFVZVJa?=
 =?utf-8?B?bnhXTUxKbTBnSXNIKzVpY2JEWUtLbVdUUVZQY2ZOejFabmxHZSttd3c0VURt?=
 =?utf-8?B?M1dxQnNYZ3FBNnVLdHowTmpZaWpVd3o3SUorbTdHRHJha1llRE1xSGVQdmhH?=
 =?utf-8?B?VlpZc2oxS2l2T0pNMFFMMHR5R1cydGFYRzRvaHFvNXdIUXJ6Q052LzdHVVls?=
 =?utf-8?B?V2NDeTR6Y0xlZTJQRWZkZWZVTkZmU290Uy9mN2ZmN3NTSTVJWlVyS3VONHl0?=
 =?utf-8?B?UjYrR3BCWE53WEcvWGtLOEM1bnBTdW0xVTNGMURzcXpDSGw1V0JUcllOU1Nm?=
 =?utf-8?B?S05xQjZpMkdkbXQwcHp4eDhBMFZhMVZxOFpkZW1WR1pjaTdBTU9zMWxoWTZ4?=
 =?utf-8?B?TytkRm1aNHVYOGl0aFZFcThmNU8zM08wWFlkdG9DcVVVYVlIa2JhelNlU1Av?=
 =?utf-8?B?WEI3M0s3TVNYdTRLZ0JDUVlyYzFPYlhZWEtMM0FjVS8zOGFsQ0ZtRWdWamJC?=
 =?utf-8?B?ZHhESk5HMzFJZnZFQ1pFbFpnQ1RScmRFaDZRQm05b2ticWZzcWFSU0RLcmk0?=
 =?utf-8?B?a1FsUDNzb3UvN0lRVSswREVETEdOeW1YSTVRMmVVN1NSN0IyQnU0SVg5NHlS?=
 =?utf-8?B?a2RMbXNxWENSSEQvVEVxd0sydnpnelJFanM0bXhiK0U2WjFPcHpoSkNiNkk3?=
 =?utf-8?B?aHROZGE1VVdSR0tiVWlYaUxmTUpNenJ2eHAvYXY0STM2czlrNjJLREVYWU1E?=
 =?utf-8?B?OVRUdmIxS044ekhGbjJQUFhXbk40VkZsVzFPYk5Tb00rdWx5c1lBQ0JNSE96?=
 =?utf-8?B?N3dwZ2NGSjB4WDlaa3IyRWl2Uml3RXh1dWhCd1R4OHdxakNWMm14SEVtWUdW?=
 =?utf-8?B?V2toYU4wSE1DQisycTcycjh0TDJLbDFUU0RJQ3ZyVE9abXBPVVJxTG9qSWd1?=
 =?utf-8?B?eno1ZW1WWS9TMGpKSXZKeGlkVFVlTW1ROVd3Smh2amtpTFRmYUpxYkNZZXo1?=
 =?utf-8?B?dlUrSkFZTVZFRFZDS0RubkVOQVVyU01ac09HRUdzaXhZRysyajhEU3p1NW9Y?=
 =?utf-8?B?QTZOU0I2UTdSKzBla1l3QndKUTVPeHFvSVErRndta0lHdnhnRU1NczNDZys1?=
 =?utf-8?B?YUxzRVJuWHMrM1RONG54eXMwZ0dWNktNS012b2hZbmNZUzBQRkpKdWkyT25F?=
 =?utf-8?B?S3VhSk1nSmlsYWNpNU5qb00ySy9qWk1MTHJncGZyUFllM3hQMlpHM2twVW9Y?=
 =?utf-8?B?Sk1wMi9Sc29XNkNHMVJiRDdoSWJxUldaZkdJQTBMbnJXZjF1bmNnQzd6aTNx?=
 =?utf-8?B?Q002c2xFclNYWjl1MWpVWEdTTjBxQ29JTHA3SWNFSDRaQnVMT0piSzgwckI4?=
 =?utf-8?B?cXJBbGVDbzhzSllpZEhIUnd5Y0hvd0dFS2ZKRU9wQjNvVEpYUFQxSHk5SFd6?=
 =?utf-8?B?dHVva1RtTEF0eStXU0N4KzREa3phM1ljUlhSVHpJaldGZXR1RlE4MXZsY3R6?=
 =?utf-8?B?RDVpNzhuM1pTRzg2MjJMSFhsczF3LzNqZWsrZHAxY0V5NkRydHdJcDNSbURN?=
 =?utf-8?B?L2Irc1E1ZEVCYXlNRWhqZTcxd0syL1pKTENmK0RldWpHQkd3b1FiU2JkWXlu?=
 =?utf-8?B?U2xyYXR6eDYxa2xqWC92NEZhVlVqdDVYNnZnSkR0dHJRdnZuOWhuU2J4SkZR?=
 =?utf-8?B?bFVta1BxL3dJUG1tSEpRK25vMjd5VmJjeFNDellHSHFmUUFSRHI4YmZKaFRw?=
 =?utf-8?B?T0xHVEkyb0t4MlZUV2NRUk1UeEduRmRoS0p1WFlyQXFEWDh6SDhhZXhpeU4r?=
 =?utf-8?B?LzhPc20xREU0WU5BN1lPTC9IbUE4eTF5a1I4cmQ1QWJScUNaKytCOUJtV2I4?=
 =?utf-8?B?NkprdExqQ1FSQzRwWlFsTXVVTHE2RExsNHdLeDA1cUYvR0h2MHVNV1Z1RHYv?=
 =?utf-8?Q?EeGL/w9ty5tMtdft2bPyXFYHg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 240e19b4-e88d-43c3-efa9-08dbd62990ea
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 13:43:41.7276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cTHnbNibd8w4IDpn7YbV5fH0FnpRur7vwlso2vxo6d0U1zb/CMra+sDwzoi9YUMEtOoQcomDjzauzTtHhWx4nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6468
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 06:43:59 -0700 (PDT)

On 10/25/23 20:45, Edgecombe, Rick P wrote:
> On Wed, 2023-10-25 at 13:03 -0500, Tom Lendacky wrote:
>>
>> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks!
>>>
>>
>> Under SEV, when making a page private/encrypted and the hypervisor
>> does
>> not assign the page to the guest (encrypted), but says it did, then
>> when
>> SEV tries to perform the PVALIDATE in the enc_status_change_finish()
>> call,
>> a nested page fault (#NPF) will be generated and exit to the
>> hypervisor.
>> Until the hypervisor assigns the page to the guest, the guest will
>> not be
>> able to make forward progress in regards to updating or using that
>> page.
> 
> Yea, mismatches between guest page tables and EPT/NPT can be trouble
> for TDX as well.
> 
>>
>> And if the hypervisor returns an error when changing the page state,
>> then,
>> yes, the guest will terminate.
> 
> I guess those callbacks could be changed to return an error after all
> these fixes then, if you want.

Probably not necessary as we will want to terminate the guest in these 
situations and having it here in this one area is easier than checking all 
of the call sites.

Thanks,
Tom