Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <0e62013a-1819-460e-8d19-697273d63367@amd.com>
Date:   Thu, 26 Oct 2023 09:55:01 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-kernel@vger.kernel.org, bp@alien8.de,
        mchehab@kernel.org, Muralidhara M K <muralidhara.mk@amd.com>
Subject: Re: [PATCH 6/7] RAS: Get CS fabirc ID register bit fields
Content-Language: en-US
To:     Muralidhara M K <muralimk@amd.com>, linux-edac@vger.kernel.org,
        x86@kernel.org
References: <20231025073339.630093-1-muralimk@amd.com>
 <20231025073339.630093-7-muralimk@amd.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231025073339.630093-7-muralimk@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2paKy9HZkhFMndqWk1RWXFETXdxdXp1bjBjRTJvNUZBR20rcE9ZWmtxZnNz?=
 =?utf-8?B?MGxDclpLQUlvRTZ4dVRJUFVrN0d0VmYwaVBEMjZKQmVrWXJ5YUNTeHRpVWRX?=
 =?utf-8?B?Q2dOTURMbXdpcGFCZksyQWhlbXc3eEZuWTJUVmE4YXFGU29KZzlGL0Vic1VF?=
 =?utf-8?B?bU1BKzltc01Scnh0VEliMFk1TEE3RDZOYzlzN3hMVkRvZUFXRkF1NDhUVStv?=
 =?utf-8?B?N3d2RGpFZC83MDJwUTdySDFWQ2NyZnNHTC92Y0t4WjhwZ2lrcFNPcmx6VUtX?=
 =?utf-8?B?dnFUMnZmY0R4TWdkdU05aExCOHhsUjlNQy90d3k1RUhveEl1RnUxQ0xLa08y?=
 =?utf-8?B?TTZ6RGMzcmhkSGp6UzQ4dGc3eWNmMW4rRXRxTVhJN3EvUVl4a3pzQ2luZDFD?=
 =?utf-8?B?UHg1LzlTYVgrb3J0bnNuR3BtcDB4SjhabStqY1FxSXFlNm9BaGxWbFBmZ2Iy?=
 =?utf-8?B?ZHR3UXRtK1FxbVMvMm1ZSFZSY3B3elREbHp0MGpXeWxpUjJ2ZEU5N3M1ZmN4?=
 =?utf-8?B?RjNrc2lZbi93aFBUWW8xT2hJMG5teWd4ZktaZGNvOUVHZlJtU1lWRWMyNTBu?=
 =?utf-8?B?ZXZUVTZpUFN4b0sxMmFWMkNVYXh2VEIvK3UrYmt1Q2xDVWlNOHhqSlkyMWZu?=
 =?utf-8?B?ZXpjTUpseGxoUkVITnRKMnRZY1YvelVyRUZSOGw3aHBjRVllK2RwNWdDWDg3?=
 =?utf-8?B?RHZnTXhWM214Wno5Z0pFQUdSbnpxODY5aFdWajl6ZUl5ekErWXYzeFpCWlAv?=
 =?utf-8?B?N3I2VmFPMHoycDNBbnBOSnRHZDBrTUYyTzFpMHlQZk1BeGsxTk9SUzF3dWhh?=
 =?utf-8?B?b0hMVEhKNmt5U1JDQXpqbzBKY0RLM2QydUQ1d28vVC85V2pTdlR0TnJxaExR?=
 =?utf-8?B?bVdpeEVnSEY1dFRQY3l0Qmk1eGdlTUFzTXZvektXcW9KNjV4QmhRbmZaNDRK?=
 =?utf-8?B?ZTM3TmNodnpWY2dSTmpYdDB5SEpkemdmRVZ0dGI0cGo5dysrUHNDelFHSHVC?=
 =?utf-8?B?N3dNMUVTa0ZVOUhlZllzdkhFVUF2YTZSWHdyV0dqVS9hTTh5NlVkbVpjc2FV?=
 =?utf-8?B?dmtMQnl4MVBvczZWRm1lMjlrcWxSWnJuY0tCRGhNVlpkQ3pFd3VqOWx5RXpy?=
 =?utf-8?B?NTFxTlRyY3ZWdHpPR1IzbUcxZndWeFRVamlaOWdFMXYwa2I2Nkh0eFZtOHV0?=
 =?utf-8?B?MnBMVXlCWktPdFZ0OUt4NDhVWjY1T1hJRFEwcHZCSUZBbHpIYTJIMFBDUEp5?=
 =?utf-8?B?dzdqREtXSkJDL1I2RFRoUHUyNnJOT1FuWFRRc3MwSGFaaGVoSHE5QmVwVjlj?=
 =?utf-8?B?RXZrMHVoM0VaS3VtN2VXNGJvcDBnSUd6bHVmajFLZHhoMGRjREdFWTlWc3pq?=
 =?utf-8?B?OVU5QzIwbUFxa0I0WjdhN2d0V3pwMlRjcXhnYlpvVm45Z2t6Q0I2eHd1cHBD?=
 =?utf-8?B?MDhkRFBtUGlmd0h1WEZKaHd5SVplVkVhYXg0Q29HUEtSN2d3OExWK0xZN3ps?=
 =?utf-8?B?WFJNQnBYN3NtOEVwY2t6Y1FPRzdDcGV6UXBLWjlyYTBjb3NBdHdSY1d0QmZv?=
 =?utf-8?B?TmhTaDltZ2pqZituTjdwZ1hGdWxlQU83SEM0ZnlEc2VibHFSclVoa0ZNRktX?=
 =?utf-8?B?dWRNd2dVKzRFR0QyZ3NsYU1UcUd6dGJDM2dxTnJvajZlbllnb3BIRVBRd1Vh?=
 =?utf-8?B?azVQdVVvZExXRXVMeVRjS09WdjFNNkpsR1J3Z3Q4Zm1NMUFQOWY0WElFazdi?=
 =?utf-8?B?Q3JYZTV4OEJlQXVnd2R2bHNRdC8rQWJLdWdaRkl2QzdxcGYwNnlWNFRqZ3Ev?=
 =?utf-8?B?aFE1a0dBTmZhcHE3VXVzZGxzUUtRODMyeDdsaUFFMk5ZN2ZEL1dYTEt2VmVs?=
 =?utf-8?B?M1pVN3VaUjY2eWNOUWtEWEsrbHRlemxDeFE4QXh0Nkl1c1l4c283aEtJbFRm?=
 =?utf-8?B?cDZnK0NnZlpNVjhrUDBNMDFwUDhXUExlbnh6cEtUSDk0TzZjRllLdmxxelBO?=
 =?utf-8?B?Q2xsVFAzKzJkWGNLUUdGeUo4ZzQxMjdRNGxVUk5HNzEzUEhBZ0x5ai8yMlBs?=
 =?utf-8?B?eWRzVVhoMk9hV1FYRVpBRzVYQm56eDRMUVFmWkUrVlI1S2MwR0FodTVtMmdO?=
 =?utf-8?Q?qJJTy/O8OtMVvw9flW8TnWRT8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88de47b2-0759-4bbb-8f14-08dbd62b2749
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 13:55:03.5738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8HVi9Z+qIcTgDh8kHisI3FZkiw76oCHGhMTiID3oQh+tYwyUGbu5NJiaiec3GBpntpk/2MjBSyyi9t+PQTROFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7142
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 06:55:29 -0700 (PDT)

On 10/25/2023 3:33 AM, Muralidhara M K wrote:
> From: Muralidhara M K <muralidhara.mk@amd.com>
> 
> Read correct register bit fields for cs_fabric_id for
> address translation to work.
> 

What is the problem exactly?

> Signed-off-by: Muralidhara M K <muralidhara.mk@amd.com>
> ---
>   drivers/ras/amd/atl/reg_fields.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ras/amd/atl/reg_fields.h b/drivers/ras/amd/atl/reg_fields.h
> index c3853a25217b..6b60091f235b 100644
> --- a/drivers/ras/amd/atl/reg_fields.h
> +++ b/drivers/ras/amd/atl/reg_fields.h
> @@ -28,14 +28,14 @@
>    *	Rev	Fieldname	Bits
>    *
>    *	D18F0x50 [Fabric Block Instance Information 3]
> - *	DF2	BlockFabricId	[19:8]
> + *	DF2	BlockFabricId	[13:8]

DF2 should be [15:8]

>    *	DF3	BlockFabricId	[19:8]

DF3 should be [13:8]

>    *	DF3p5	BlockFabricId	[19:8]
>    *	DF4	BlockFabricId	[19:8]
> - *	DF4p5	BlockFabricId	[15:8]
> + *	DF4p5	BlockFabricId	[19:8]

DF4p5 is correctly listed as [15:8].

Special cases can be listed separately.

>    */
> -#define DF2_CS_FABRIC_ID	GENMASK(19, 8)
> -#define DF4p5_CS_FABRIC_ID	GENMASK(15, 8)
> +#define DF2_CS_FABRIC_ID	GENMASK(13, 8)
> +#define DF4p5_CS_FABRIC_ID	GENMASK(19, 8)
>   

Even though the most significant bit changes between DF versions, it 
looks like the upper bits are all reserved/Read-as-Zero. So we can 
document the correct field, and use an expanded/inclusive field (like 
[19:8]) for code simplification. And make a note of this for reference.

Thanks,
Yazen