Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <krzysztof.kozlowski+dt@linaro.org>, <dillon.minfei@gmail.com>,
        <david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <conor+dt@kernel.org>,
        <linux-samsung-soc@vger.kernel.org>, <andi@etezian.org>,
        <gost.dev@samsung.com>, <alim.akhtar@samsung.com>,
        <aswani.reddy@samsung.com>, <pankaj.dubey@samsung.com>,
        <ajaykumar.rs@samsung.com>, <linux-fsd@tesla.com>
In-Reply-To: <948af111-e7a1-4757-a784-b4256657abd6@linaro.org>
Subject: RE: [Patch v4 01/11] dt-bindings: media: s5p-mfc: Add mfcv12
 variant
Date:   Thu, 26 Oct 2023 19:01:31 +0530
Message-ID: <000001da0810$c2b17680$48146380$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLm4twfZx4yvmLB3iF6RxvUJv+HzQK0rOY9AbqXOzoB/yYnBa4Oc9rw
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20231025102216.50480-1-aakarsh.jain@samsung.com>
        <CGME20231025102233epcas5p16b716d5b650bbc5af0d759ea4f58f44d@epcas5p1.samsung.com>
        <20231025102216.50480-2-aakarsh.jain@samsung.com>
        <948af111-e7a1-4757-a784-b4256657abd6@linaro.org>
Precedence: bulk

Hello Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 25 October 2023 18:30
> To: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-arm-
> kernel=40lists.infradead.org; linux-media=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; devicetree=40vger.kernel.org
> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> krzysztof.kozlowski+dt=40linaro.org; dillon.minfei=40gmail.com;
> david.plowman=40raspberrypi.com; mark.rutland=40arm.com;
> robh+dt=40kernel.org; conor+dt=40kernel.org; linux-samsung-
> soc=40vger.kernel.org; andi=40etezian.org; gost.dev=40samsung.com;
> alim.akhtar=40samsung.com; aswani.reddy=40samsung.com;
> pankaj.dubey=40samsung.com; ajaykumar.rs=40samsung.com; linux-
> fsd=40tesla.com
> Subject: Re: =5BPatch v4 01/11=5D dt-bindings: media: s5p-mfc: Add mfcv12
> variant
>=20
> On 25/10/2023 12:22, Aakarsh Jain wrote:
> > Add Tesla FSD MFC(MFC v12) compatible.
> >
> > Cc: linux-fsd=40tesla.com
> > Signed-off-by: Aakarsh Jain <aakarsh.jain=40samsung.com>
> > ---
>=20
> No changelog and your cover letter does not explain what happened here.
> Specifically, why did you decide to ignore received tag.
>=20
Last patch series we had two different patches for schema which was one for=
 adding MFCv12 compatible string and other for adding its HW properties.
In one of the patches you gave reviewed-by tag. Since mfc dt_schema got mer=
ged already, and this is relatively  new patch so thought of getting review=
ed again.

Link to those patches:
https://patchwork.kernel.org/project/linux-media/patch/20221011122516.32135=
-2-aakarsh.jain=40samsung.com/
https://patchwork.kernel.org/project/linux-media/patch/20221011122516.32135=
-3-aakarsh.jain=40samsung.com/   =20

if you are ok, I will add your reviewed-by in next patch series.

> >  .../bindings/media/samsung,s5p-mfc.yaml          =7C 16 ++++++++++++++=
++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-
> mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-
> mfc.yaml
> > index 084b44582a43..c30eb309f670 100644
> > --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> > +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> > =40=40 -24,6 +24,7 =40=40 properties:
> >            - samsung,mfc-v7                =23 Exynos5420
> >            - samsung,mfc-v8                =23 Exynos5800
> >            - samsung,mfc-v10               =23 Exynos7880
> > +          - tesla,fsd-mfc                 =23 Tesla FSD
> >        - items:
> >            - enum:
> >                - samsung,exynos3250-mfc    =23 Exynos3250
> > =40=40 -165,6 +166,21 =40=40 allOf:
> >            minItems: 1
> >            maxItems: 2
> >
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - tesla,fsd-mfc
> > +    then:
> > +      properties:
> > +        clocks:
> > +          maxItems: 1
> > +        clock-names:
> > +          items:
> > +            - const: mfc
> > +        iommus: false
>=20
> That's odd. How so? MFC v12 does not support IOMMU?
>=20
MFC v12 do support IOMMU. But currently it is not enabled in SW (has depend=
encies on some of the floating dma-mapping patches) and not tested on upstr=
eam kernel. Current patch sets intend to add support for MFCv12 using reser=
ve memory and later patches related to enable iommu will be posted (after r=
esolving the dependencies). So I marked iommu property as false.=20
Now what is your suggestion here? Should I keep iommu as false or add memor=
y-region as below?
Ex-
  - if:
      properties:
        compatible:
          contains:
            enum:
              - tesla,fsd-mfc
    then:
      properties:
        clocks:
          maxItems: 1
        clock-names:
          items:
            - const: mfc
        memory-region:
          maxItems: 1


> Best regards,
> Krzysztof

Thanks for review.