Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp470343rdh; Thu, 26 Oct 2023 07:15:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE54HHg6CURuN1p4a3FGgBeS8KVaqSkYLbdekaxFMw/G8FX8Z2x1gEqfVLyxod4FmO8OUYx X-Received: by 2002:a5b:8c5:0:b0:da0:3ec1:f3f with SMTP id w5-20020a5b08c5000000b00da03ec10f3fmr5544263ybq.3.1698329702864; Thu, 26 Oct 2023 07:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698329702; cv=none; d=google.com; s=arc-20160816; b=K0y0zPsLee3TO1xzd+Htxua7EOnPw6OHVrNKgujadzwM2mmIBEtfRyB48qaCG7oOC5 CXA78+RG2oTnoXFZWGJk2bbnMNFRtwyoFg8okZk/mfmzgNK067piPr7LRrY0vd9HXuz1 8BYCixWmAK5VYBpNyMj+ZoLnffHU16JUgIZAJqFRVK+u8bL+Boc0oaA8S16qYW8HI0Js ihfYZxklRu+V81H0f+XtMPE/c9fwy2zihIaxMmNhQG88JFrXVPo2sRfd/bLQSGjpVkuH AZJ+mZQ1QSCQErt47UjWGxFi0kF+n4nOVB0XUxEr0O0fM61nd3JmBkEG6TR4eEN8G/L/ pMDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:message-id:subject:from :to:cc:date:content-transfer-encoding:mime-version:dkim-signature; bh=W5fFxhCOIYscZBRprzniuQ2/sqUzxXjEob/R9onjmmU=; fh=Y4IAzX18OHJMW5FC2/qWq6kjea3XOZiy4wP2tIzbQgs=; b=0RaWkUTUtO3vr1I5UvkZuQd86GObMVAFKrBFaPV8VGfKpGtQ3j8H6Mix/dcb7gADgw k6r5Qxdy4bXDj6xMPvBJeup8os75PDizO4jN2fB6ZTeG9EEnQno4eRSZbHTymnbRRV6u fOOTnrJkf30aYwb5Or6hAdRWbCb9GcD04c2MdMIRSOcRWMTPdzE42oyP843l9k6RdbBE ubnIOwOnosegWXMYb5KxW2xW2ePP4pSsXWzYWGFeFN+eg0tttyOAoZy/k751HoDhy65V jxT09wvF2hWIBW8x8Q73p+aaexk17NSAqERCh/srLG1TbYhINi9yVRuwfDdYvUjl/P3Z Q7UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=S5gKKvTT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id c126-20020a254e84000000b00d9c6beccb61si12915474ybb.501.2023.10.26.07.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 07:15:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=S5gKKvTT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id EF8D88226F69; Thu, 26 Oct 2023 07:14:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345174AbjJZOOt (ORCPT + 99 others); Thu, 26 Oct 2023 10:14:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234902AbjJZOOs (ORCPT ); Thu, 26 Oct 2023 10:14:48 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99A41AA; Thu, 26 Oct 2023 07:14:44 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7841224000C; Thu, 26 Oct 2023 14:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1698329683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W5fFxhCOIYscZBRprzniuQ2/sqUzxXjEob/R9onjmmU=; b=S5gKKvTTOlDQVxRGeXo1NbJLAwFsIjZLgIXFKbYYtNjfPXI9t1bfYGE+2URKYJsdCEp2TQ BPHrYl3vzD0847Q4bCsHsU2F5DunNwS10rA81t1uWjWOqZgkazNyjeLV/68HL8q4KWX48d TZ3WjFPpHeiKeFejZ65gzM83H6eQo+Zvp6aexWa18Qxlr+sj8pC9jo4HvCpAdHnTIhKBVm a/B1eZ3io7FGIJsAlH6ImJmNyhcXsm1SdpcCeEzFst7KH72+iK5NOKtAn28Z8s7jGYYbeA P/9VTaloQXo5k9Z04EDdnf0Pc8gP9iJAuv41BMuEXeqS3UsuJN5nzu8vjzy/8A== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 26 Oct 2023 16:14:42 +0200 Cc: "Russell King" , "Greg Kroah-Hartman" , "Jiri Slaby" , , , "Gregory CLEMENT" , "Alexandre Belloni" , "Thomas Petazzoni" , "Vladimir Kondratiev" , "Tawfik Bayouk" To: "Linus Walleij" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 2/6] tty: serial: amba: Use BIT() macro for constant declarations Message-Id: X-Mailer: aerc 0.15.2 References: <20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com> <20231026-mbly-uart-v1-2-9258eea297d3@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 26 Oct 2023 07:14:59 -0700 (PDT) Hello, On Thu Oct 26, 2023 at 3:37 PM CEST, Linus Walleij wrote: > Since you don't know where this header may be included, you should > add #include at the top of linux/amba/serial.h > > With that fixed: > Reviewed-by: Linus Walleij Clearly, thanks for that. -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com