Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp477228rdh; Thu, 26 Oct 2023 07:24:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoU3xWRz2r2+IyNN8tPh7FdzBhNAOw8Npgl6J4llWtxpT6sL3Ai09/WE8Co/q/Hy/+WLzM X-Received: by 2002:a0d:d712:0:b0:5a7:a959:337 with SMTP id z18-20020a0dd712000000b005a7a9590337mr21345091ywd.27.1698330282092; Thu, 26 Oct 2023 07:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698330282; cv=none; d=google.com; s=arc-20160816; b=oOaMwx3VgNyZz3vLhE9y3j3ZNPCGKJbu1hbnhnoLTnJsElBhGueOKKcJikS5Ppl+xn oDcVT7vekQ9QbAudIUumwJegPxKRTvCgmwHXIJBQ1RtjtgWi5DfRN3VRp1CeUpSSi0G7 GQSzxfPcLtDSZyTeXaIcx5wC5zeX/+8UGpSS5GgNnzSoQ2V4+ExQ+uGpqcVFb8kJQXls WgCdylPrNSUbAFPC1BUe076Ij2S/d3aDGD1TKGsFX5VVMevTbQII7ONO7UEJBN9di8pk 63XVjXakwkEjanydkZfhAKbmhmBJo9cmJ2acF51hve9igijDhZPHYWhZcSTDHLckRBNd u96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JvktxjVfkL+L338qM5yYJHIrOtY6B+d/w/XgfHIyqJ8=; fh=eTju4TVx1lzwQMapHCYGzI6FYl3TewmpHUKdHvNRjtg=; b=YAZRR19gjsmICKQr42Pavy8mvCDFGukinK+jE8d6gwojE/zhFs6r2m2+CcqoLOQyVO Tpg4buiBbTwV84C06nVBYExD95KSpEgC4z3YupEZMPHLv8F5P0nLyTVvtuOtPYFrRmHP VwMuvSTfn0LHzc8FFE5kJfala09dHsLGdSqaQvmaLiXeSv1MPrbLnT7exJRFc+34H1Tc mEuhQ+GOD1PKe18Cz6xZOIRDZ2I209YfjHFqGvAo7s50bk20AMo/ZKxbMTH6v9hGloPA MK20Onlj5m2dD+nIpTi/wq6X08Kvy+7o+lRsAE7vEDiKMPbC16evPSY7dAeo0q4VJ2+x 8Jeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T1+gpBbu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g77-20020a0ddd50000000b0059f74659a2esi15008163ywe.56.2023.10.26.07.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 07:24:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T1+gpBbu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8B44F819A6A3; Thu, 26 Oct 2023 07:24:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345215AbjJZOYd (ORCPT + 99 others); Thu, 26 Oct 2023 10:24:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235075AbjJZOYb (ORCPT ); Thu, 26 Oct 2023 10:24:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A80C0D7A for ; Thu, 26 Oct 2023 07:24:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 182A7C433C9; Thu, 26 Oct 2023 14:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698330265; bh=JvktxjVfkL+L338qM5yYJHIrOtY6B+d/w/XgfHIyqJ8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T1+gpBbuxN3eqF4QCYpT83BIEg0rFmZapScZQJ7whB+Hy4Y/GiypWgWapxytG+HJC L7rExCB0EvByr/Vt+KvKSm76qzkqsOkFDfe/wAMJIdo6IL1dtgF+73RmWPjkdgyJ9x VpBFQsqP5eZGpg2gIfQb3IgEFrlXXaIt2mSR29CCMBO2qAOr8IWz0OVqsuOiLiiYNf ngP7MiDMktJlqG64ShxT7abpgW2RH1nBTjet9kL9keKfzE2EQfxKhCHyzSeB87Xo7k 7LHSK8Vmz4IyxE7sGkdZx2bmn14F3rM646El/iJmEqiHCVYgP3zttjDHjxIlY/pBcM wkbdWdLe9uXQw== Date: Thu, 26 Oct 2023 07:24:23 -0700 From: Jakub Kicinski To: Justin Stitt Cc: Przemek Kitszel , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Rasesh Mody , Sudarsana Kalluru , , Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , "Tony Nguyen" , Louis Peens , Shannon Nelson , Brett Creeley , , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Ronak Doshi , VMware PV-Drivers Reviewers , Andy Whitcroft , Joe Perches , "Dwaipayan Ray" , Lukas Bulwahn , , , Nick Desaulniers , Nathan Chancellor , Kees Cook , , , Subject: Re: [PATCH 2/3] treewide: Convert some ethtool_sprintf() to ethtool_puts() Message-ID: <20231026072423.2ebd4619@kernel.org> In-Reply-To: References: <20231025-ethtool_puts_impl-v1-0-6a53a93d3b72@google.com> <20231025-ethtool_puts_impl-v1-2-6a53a93d3b72@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 07:24:40 -0700 (PDT) On Thu, 26 Oct 2023 11:23:37 +0200 Przemek Kitszel wrote: > this would now fit into one line > (perhaps it's the same in other cases, I just checked this one manually) I think cocci would fold lines automatically? Could be worth trying spatch to do the conversion for that reason, if you aren't already.