Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp477960rdh; Thu, 26 Oct 2023 07:25:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTl+OPtisSg6JYXB/8ixqVQ0vW8P7HFQrh3eGt6ji6rgO7ueCH3nNQTQZEIJi9sRxii9Zv X-Received: by 2002:a05:690c:ec9:b0:5a7:bc0e:8ce9 with SMTP id cs9-20020a05690c0ec900b005a7bc0e8ce9mr6636927ywb.24.1698330339959; Thu, 26 Oct 2023 07:25:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698330339; cv=none; d=google.com; s=arc-20160816; b=BV1Gr14Fz69FXeO4qpAianIb5oGhEtR+iJdHNue8/Nqn140bPBT4wREpcnvJPoPTFO jbqS7LJREafCkQ77gU1bJ9kE1hCHB5XelJu5H4JkSXcQnKp0mfq5XVkuvGbZy3MxAWJ4 v23GI+ogCS/a8m8EW6lME8f5bHVJRHTtPVimSp6T+uGMy7a8E/GTDaA7IjpXYTZGpK+h PuGrfN7mTLd34wKhrsx0qy5OnyLtU2QzXujvWX3BmrAhmgp9uLUgntfHAHTZF/MIn3XK K7Mnj9ceZ+peKIpKR7UnO++1jWvCoEF92f6NON0f+VpvL7H44459FBLaZ2VWY7hj3J4v 92Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=PziSD1PgLb0667xILGVhhWhS3pJpGafG9WCNyplDM6M=; fh=WXg7AoFm5vzw3OKOzrS0R4uTPt6umYAarSGmQPLuG/g=; b=aUqiMr50IdCuMLFMmwgsspQc36De3Qu/FfIOJ9d9W3nhLglOfjTd9k4yAwV8zPFzPn WewdArDb4neer5KNquA+++EFaJg/vKHisa5DIzXbKxKjKoKc+/KwZWufdzsfz+o8WyZ8 vXKQVZZqgdchlHIDhZTZUYHz9stRoa/L9unaXVc2yQo0MjWM0UblU/HSKLsrk2fzw3R3 guu7tAr530KD6zxuiirunlBRQ4nKjmjtp3YNKCZ0957B+oLa1REAJIwP+hLoGt55cCqB wZh5hswpToqKOUTRm9tWEkCoRCli/QP6x0KgIvTJ/ZxmoVbxzO9a4xIQVNZ0SM0cNuDU 9KNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QIn7GuOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id d140-20020a0ddb92000000b005a7bf2b8577si13102181ywe.92.2023.10.26.07.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 07:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QIn7GuOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 224A2837EA5C; Thu, 26 Oct 2023 07:25:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345225AbjJZOYy (ORCPT + 99 others); Thu, 26 Oct 2023 10:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345233AbjJZOYp (ORCPT ); Thu, 26 Oct 2023 10:24:45 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0CD71B3; Thu, 26 Oct 2023 07:24:40 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id EB058240008; Thu, 26 Oct 2023 14:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1698330279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PziSD1PgLb0667xILGVhhWhS3pJpGafG9WCNyplDM6M=; b=QIn7GuOInRvzLopWLDpEwkNAHOMLbAID0zp3gldafosregQkAiEFK3AidlLnrta4vGYG4y wr5A5L4tEgRVFz6aDtcbpalX2QiVE7UgBQla1eH5D+AaaCpOUCM2d7EkqGfs9QCWHHExWY KgKsYMAFdux9kQYKH4Dr5F88YDwjoxpvGkDZ4ydIhkmDgh2c+IhcdLWMdgUOa3FhrWvZXb fi1g9c84ant7cWC5XmGIy0/bcZQanfqqXLE9L2VH36Zz+NSpS16lVJgwHNZj2j8BP8PaX6 OHMers7IgTCaRz8Pels/IChplDKbacwVhDlxNpUIxSHIXwEeb3h7Yf2EHrZlvg== Date: Thu, 26 Oct 2023 16:24:38 +0200 From: Herve Codina To: Rob Herring Cc: Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] of: address: Consolidate bus .map() functions Message-ID: <20231026162438.5b063044@bootlin.com> In-Reply-To: <20231026135358.3564307-3-robh@kernel.org> References: <20231026135358.3564307-2-robh@kernel.org> <20231026135358.3564307-3-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 26 Oct 2023 07:25:19 -0700 (PDT) Hi Rob, On Thu, 26 Oct 2023 08:53:59 -0500 Rob Herring wrote: > The bus .map() functions vary only by checking the flag cells values > and skipping over any flag cells to read the addresses. Otherwise they > all do the same reading 'ranges' address and size and returning the > address's offset if it is within the 'ranges' entry. > > Refactor all the .map() functions to pass in the flag cell size so that > each bus can check the bus specific flags and then call a common > function to do everything else. > > Signed-off-by: Rob Herring Acked-by: Herve Codina Best regards, Hervé