Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 26 Oct 2023 17:48:04 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, andrew@lunn.ch,
        Jose.Abreu@synopsys.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next V2] net: pcs: xpcs: Add 2500BASE-X case in get
 state for XPCS drivers
Message-ID: <pgr3jnzao7jeoz6sutt2nk6wrtzvjl42lxmorncyddzeouuzvu@jpznq4ycta6f>
References: <20231026101642.3913-1-Raju.Lakkaraju@microchip.com>
 <ZTpHi5YYmiQKpy1e@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTpHi5YYmiQKpy1e@shell.armlinux.org.uk>
Precedence: bulk

On Thu, Oct 26, 2023 at 12:03:39PM +0100, Russell King (Oracle) wrote:
> On Thu, Oct 26, 2023 at 03:46:42PM +0530, Raju Lakkaraju wrote:
> > Add DW_2500BASEX case in xpcs_get_state( ) to update speed, duplex and pause
> > 
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> 
> Sorry for not doing a fuller review with the earlier iteration today.
> 
> Also, please note that on netdev, it's customary not to post more than
> one version of a patch per day. Please see the netdev FAQ for guidance.
> 
> > +static int xpcs_get_state_2500basex(struct dw_xpcs *xpcs,
> > +				    struct phylink_link_state *state)
> > +{

> > +	int sts;
> > +
> > +	sts = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_STS);
> 
> 	if (sts < 0) {
> 		state->link = 0;
> 		return sts;

My 5cents to this note. Please use "ret" variable name as it's implied
by the local naming convention.

-Serge(y)

> 	}
> 
> especially as a negative errno value could result in state->link being
> true.
> 
> Thanks.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!