Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 26 Oct 2023 18:02:20 +0300
From:   Michael Walle <michael@walle.cc>
To:     Pratyush Yadav <pratyush@kernel.org>,
        AceLan Kao <acelan.kao@canonical.com>
CC:     Tudor Ambarus <tudor.ambarus@linaro.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v4=5D_mtd=3A_spi-nor=3A_Improve_?= =?US-ASCII?Q?reporting_for_software_reset_failures?=
User-Agent: K-9 Mail for Android
In-Reply-To: <mafs0fs1xmrit.fsf@kernel.org>
References: <20231026012017.518610-1-acelan.kao@canonical.com> <mafs0fs1xmrit.fsf@kernel.org>
Message-ID: <8D87B330-8FA1-46BE-949E-5A8DFB8AACF3@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 26=2E Oktober 2023 16:39:54 OESZ schrieb Pratyush Yadav <pratyush@kernel=
=2Eorg>:
>On Thu, Oct 26 2023, AceLan Kao wrote:
>
>> From: "Chia-Lin Kao (AceLan)" <acelan=2Ekao@canonical=2Ecom>
>>
>> When the software reset command isn't supported, we now report it
>> as an informational message(dev_info) instead of a warning(dev_warn)=2E
>> This adjustment helps avoid unnecessary alarm and confusion regarding
>> software reset capabilities=2E
>
>I still think the soft reset command deserves a warn, and not an info=2E
>Because it _is_ a bad thing if you need to soft reset and are unable to
>do so=2E Your bootloader (or linux if you rmmod and modprobe again) might
>not be able to detect the flash mode and operate it properly=2E=20

agreed=2E=2E but=2E=2E=20

>I think we should just not unconditionally run this and instead only
>call it when the flash reset is not connected -- that is only call this
>under a check for SNOR_F_BROKEN_RESET, like we do for 4-byte addressing
>mode=2E

=2E=2E keep in mind that this is a restriction of the flash controller=2E =
the Intel one seems to be the only affected one (for now) and it's doing a =
reset (according to mika) on its own=2E=20

snor_broken_reset is a property of the flash=2E=20


>I don't have a strong opposition to this patch but I do think it is
>fixing the problem in the wrong place=2E

if the flash controller doesn't let you issue a soft reset (or does so on =
its own), what's the fix?

-michael=20