Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 26 Oct 2023 08:23:15 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     Yang Li <yang.lee@linux.alibaba.com>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fs: Remove unneeded semicolon
Message-Id: <20231026082315.fd432f07d9db32642f78aeac@linux-foundation.org>
In-Reply-To: <20231026150334.GA13945@redhat.com>
References: <20231026005634.6581-1-yang.lee@linux.alibaba.com>
        <20231026150334.GA13945@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 26 Oct 2023 17:03:35 +0200 Oleg Nesterov <oleg@redhat.com> wrote:

> On 10/26, Yang Li wrote:
> >
> > @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> >  	for_each_thread(task, pos) {
> >  		if (!nr--)
> >  			goto found;
> > -	};
> > +	}
> 
> Ah, I forgot to remove this semicolon :/
> 
> This is on top of
> 
> 	document-while_each_thread-change-first_tid-to-use-for_each_thread.patch
> 
> perhaps this cleanup can be folded into the patch above along with Yang's sob ?

The above is in mainline, so no squashing.  I added your acked-by.