Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Subject: Re: [PATCH v6] usb: Reduce the 'SET_ADDRESS' request timeout with a
 new quirk
To:     Hardik Gajjar <hgajjar@de.adit-jv.com>,
        <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>,
        <mathias.nyman@intel.com>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <erosca@de.adit-jv.com>
References: <20231025164019.GA121292@vmlxhi-118.adit-jv.com>
 <20231026101551.36551-1-hgajjar@de.adit-jv.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <cd598ae5-6eae-8e0b-8295-d98fa5c4b2fd@omp.ru>
Date:   Thu, 26 Oct 2023 19:00:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20231026101551.36551-1-hgajjar@de.adit-jv.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-Spam-Status: No, score=-4.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 09:01:22 -0700 (PDT)

Hello!

   Please don't post the patches as a reply to the other thread, start a new
thread with a new patch version (I thought others would tell you that but nobody
has so far).
   And how about changing the wording of the subject to s/th like below?

usb: new quirk to reduce the SET_ADDRESS request timeout

On 10/26/23 1:15 PM, Hardik Gajjar wrote:

> This patch introduces a new USB quirk,
> USB_QUIRK_SHORT_SET_ADDRESS_REQ_TIMEOUT, which modifies the timeout value
> for the 'SET_ADDRESS' request. The standard timeout for USB request/command

   The upper case is enough of the emphasis, I don't think the apostrophes
are needed arounnd SET_ADDRESS...

[...]

> Signed-off-by: Hardik Gajjar <hgajjar@de.adit-jv.com>
> ---
[...]
> Changes since version 5:
> 	- Changed the terminology in USB core driver files from 'command' to 'request'
> 	  as it is more commonly used. 
> 	  It's important to note that USB specifications indicate these terms are interchangeable.

   Didn't know that... tried to find the proof in the USB specs but haven't
managed to do it...

> 	  For example, USB spec 3.2, section 9.2.6.1, uses the term 'command' in its text
> 	  "USB sets an upper limit of 5 seconds for any command to be processed. "

   Hm, indeed; and this wording is even inherited from USB 1.1...

[...]

> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 3c54b218301c..98db92af2cce 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -54,6 +54,19 @@
>  #define USB_TP_TRANSMISSION_DELAY_MAX	65535	/* ns */
>  #define USB_PING_RESPONSE_TIME		400	/* ns */
>  
> +/*
> + * USB 3.2 spec, section 9.2.6.1
> + * USB sets an upper limit of 5000 ms for any command/request
> + * to be processed.
> + */
> +#define USB_DEFAULT_REQUEST_TIMEOUT_MS	5000 /* ms */
> +
> +/*
> + * The SET_ADDRESS request timeout will be 500 ms when
> + * USB_QUIRK_SHORT_SET_ADDRESS_REQ_TIMEOUT enable.
> + */
> +#define USB_SHORT_SET_ADDRESS_REQ_TIMEOUT_MS	500  /* ms */

   I don'ts see the _MS-like suffixes in the other timeout #define's there...

[...]
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index e1b1b64a0723..d856c4717ca9 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -3997,12 +3997,18 @@ int xhci_alloc_dev(struct usb_hcd *hcd, struct usb_device *udev)
>  	return 0;
>  }
>  
> -/*
> - * Issue an Address Device command and optionally send a corresponding
> - * SetAddress request to the device.
> +/**
> + * xhci_setup_device - issues an Address Device command to assign a unique
> + *			USB bus address.
> + * @hcd: USB host controller data structure.
> + * @udev: USB dev structure representing the connected device.
> + * @setup: Enum specifying setup mode: address only or with context.
> + * @timeout_ms: Max wait time (ms) for the command operation to complete.
> + *
> + * Return: 0 if successful; otherwise, negative error code.

   I still think the above change should be a separate follow-up (or even
a preceding) patch...

[...]

MBR, Sergey