Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 26 Oct 2023 18:02:21 +0200
Message-ID: <87zg05xtgy.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "Mark Brown" <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH v1 0/8] System Suspend fixes and improvements for CS35L41 HDA
In-Reply-To: <20231026150558.2105827-1-sbinding@opensource.cirrus.com>
References: <20231026150558.2105827-1-sbinding@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 26 Oct 2023 17:05:50 +0200,
Stefan Binding wrote:
> 
> There is a report of a single laptop which uses CS35L41 HDA having an
> issue with System Suspend. This particular laptop uses S3 (Deep) Sleep.
> The reported issue states that when the laptop resumes from a system
> suspend, audio no longer works.
> 
> The root cause of this issue is due to the CS35L41 being returned to us
> in an unexpected state after a suspend/resume cycle.
> When the driver resumes, it expects the parts to have been reset, which
> leads to issues with audio and firmware loading.
> 
> To prevent this issue, and the possibility of similar issues, patches
> 2-5 force the driver to reset during probe, system suspend, and system
> resume, which ensures that the part is always in the correct state.
> Patches 6-8 are improvements in the suspend and firmware loading code,
> which makes it easier to detect issues in the future, as well as
> simplifiying the suspend code.
> 
> Patch 1 is a fix for an incorrect configuration for the HP Zbook Fury
> 17, which is the laptop which had the original issue.
> 
> Stefan Binding (8):
>   ALSA: hda: cs35l41: Use reset label to get GPIO for HP Zbook Fury 17
>     G9
>   ALSA: hda: cs35l41: Assert reset before system suspend
>   ALSA: hda: cs35l41: Assert Reset prior to de-asserting in probe and
>     system resume
>   ALSA: hda: cs35l41: Run boot process during resume callbacks
>   ALSA: hda: cs35l41: Force a software reset after hardware reset
>   ALSA: hda: cs35l41: Do not unload firmware before reset in system
>     suspend
>   ALSA: hda: cs35l41: Check CSPL state after loading firmware
>   ASoC: cs35l41: Detect CSPL errors when sending CSPL commands

Applied to for-next branch now.  Thanks.


Takashi