Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <24d96a47-bd0c-4110-be64-e0d3a3dc8a24@amd.com>
Date:   Thu, 26 Oct 2023 09:10:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] treewide: Convert some ethtool_sprintf() to
 ethtool_puts()
To:     Justin Stitt <justinstitt@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Shay Agroskin <shayagr@amazon.com>,
        Arthur Kiyanovski <akiyano@amazon.com>,
        David Arinzon <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        Saeed Bishara <saeedb@amazon.com>,
        Rasesh Mody <rmody@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        GR-Linux-NIC-Dev@marvell.com,
        Dimitris Michailidis <dmichail@fungible.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Louis Peens <louis.peens@corigine.com>,
        Brett Creeley <brett.creeley@amd.com>, drivers@pensando.io,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Ronak Doshi <doshir@vmware.com>,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com,
        linux-hyperv@vger.kernel.org
References: <20231025-ethtool_puts_impl-v1-0-6a53a93d3b72@google.com>
 <20231025-ethtool_puts_impl-v1-2-6a53a93d3b72@google.com>
Content-Language: en-US
From:   "Nelson, Shannon" <shannon.nelson@amd.com>
In-Reply-To: <20231025-ethtool_puts_impl-v1-2-6a53a93d3b72@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzROZndFZjNia3hRMS9kNFdCbCsxN29aRmU2ZkZnNzlRRXJkbFhma0xJWjFM?=
 =?utf-8?B?UjQyRiswblFkS0xxOStNczN1RURybWNrczhLQndmNjN1eTlMOUVJRzhKclB6?=
 =?utf-8?B?Zk1KbjhRYnlIN1c5ekxnbHJVbDBQTEt5cTFjZnB0cmtZYlI0Tzcrd0tDbDhV?=
 =?utf-8?B?WXpOL216REx6b3dyREtkYk1NQi9ONVhsVUJObGNXS2RBTHIyNzlONFZTdWFH?=
 =?utf-8?B?emxkdW9tK1ArWFp0VTFYVGs4bDRFeXVuU3hRMm0vQ1F5MHpCakgrTk9FMmNn?=
 =?utf-8?B?UFdwQnY0VjR3em5adVFPQ3hBVEQrb2o1RjBlWCs3SDhDR1gzWFVhbEQwWXJJ?=
 =?utf-8?B?cDV2aGdOL3ZEUzVxRU13RWVpdEs5WHZlVmdhWkdtWDRCQXVjMzFLZXFmcmw4?=
 =?utf-8?B?Um52TG5Od0duVWJvWjVHa29XMnNyb2o0YmdCc1NuMm1sVmQ1ait4RmQ4Y0Zo?=
 =?utf-8?B?QTU3WEtaR3RYelpFQURBYVR0eTdKS0dZUzk2UG5RUmdwOG9LZlJTbm5PYWFs?=
 =?utf-8?B?Q3BYU0REejZ6UEN4aWVUZ1JXYzd4d0cyZmI3RDlBR3lJVy9jTjViWktuTHVZ?=
 =?utf-8?B?UmJBbU00aEVNT1R5L1BtTjVpNVl4UFJEeDdyZzViWjd1TG1tVEEzb0hKalM4?=
 =?utf-8?B?VGFRaVFWSGlVNnJmRDI0a2dkTm5oVitScFkwai80T3lQdnlIaFVja2N0MEk3?=
 =?utf-8?B?VytOTVlxMkxKZkFUdGczTnFtUHZOenhpR2toMzZjamFOU2hJdUR1MUh1VFBo?=
 =?utf-8?B?cjFuUUNRckVBQ1lqUjJ1MUlOek53S1R0VXZOQ0FwWXRub1pQL21TbzhIY0Uz?=
 =?utf-8?B?OXVDZ1U3MzhFdTVnRnIyMW5jUEgvM1FsRjQ1SHNvSmpNVTVuKzViZkZvaEQx?=
 =?utf-8?B?b2o5b3QwbHdLS1Npd2lVM2tMcUc4cDByR0VXc01veEpXVHhZUHBiV1lhVGdv?=
 =?utf-8?B?MTVXYUlxdXdQeWNvS2gwS0UyNUxOR1Zod2ZPQUFGd0lnQm1QY1cvVjNYSHZi?=
 =?utf-8?B?eU9jU2xyUUgwVUlEbEExR1VhdUtwZzBuZkphOXBlNnJoUFM1UE5LQjc3R3Ux?=
 =?utf-8?B?ekQwVjdiYzZBK2N5V2JiejRNUUl0ZjhYRFFySEVpbk1oY2pPeFMvOGY3b1lI?=
 =?utf-8?B?S0NjMlh3d2JaazlPQ3JYcFhXS1hMSElyRld4L1VOUmlQbEtyMzROeitRU0VI?=
 =?utf-8?B?WDJtWEZXd3NQdHZNYjkwWFU1WmZkaFU4OGwrWmtpS2FkMUV2UVkycUh2MFNQ?=
 =?utf-8?B?QmF3NjQybThIQzRsWFBsMVpySUJ0dEYzWXVPVjZLVjYzVmN3N1BLemdzMnpt?=
 =?utf-8?B?cThONU1SSVNvV0VmcWdiajRBQ09EY01oSGF2b0wvN1JIdzJTN1BTREd4Y2da?=
 =?utf-8?B?eXJ5alFIdW93QVB0M0VFd1VHVlQ2NHZlVXR3TVZ6T2xRUm5FQ2ZXSzVlUlpW?=
 =?utf-8?B?OHJFb3UzdHdBMFJmeGFVY2I0UHdYdGd2TitpRGJJTlFFbmFkYjI1S0p5M3M2?=
 =?utf-8?B?TG9jLzFNclJ3RktHK0pSWXhWODZremtHZitrcFBpZFhtMHdaYmloV3FVUDY3?=
 =?utf-8?B?Mm1iVjVkdXFXWTdmMTV2aXJpaTF4TExuMkJDWU50TGlsNXA0V1U3QU9iRkN5?=
 =?utf-8?B?ZEhiWE1VbWdSYS9Sc2syVldBS1poWHVMa1Z0ZHoxMFhSRzE2a2V2RHRDMVZk?=
 =?utf-8?B?RGNMdkdZcmdiUHp0T1VhN0pVZTJKYlloc3JmcWhaUElqRVpGUWZhaXlNcWhR?=
 =?utf-8?B?Z3RVUVRBL210dHliT3E0TWw2QytZaXdaempZd2hoUk5MMTl1Snl6a1dWdFpU?=
 =?utf-8?B?UWJ2WmFlWS9UZXFReXVycnFIdVBQTEhkWk9MbE5RbmV2eGxUbjdPTmduZElX?=
 =?utf-8?B?SzJxSkFSdjM1YmJwQkN4LzlZZzZseU52d0N3aVNuelo3SGFIMjlyNWZvQzMx?=
 =?utf-8?B?WVFMZWlqc3BuMGNzMmZEODRZSVhqdWlNNm9UbFBZNS9aTmZjT3pvd2pjZVIx?=
 =?utf-8?B?ajBRQjY2dEZzL01ZVExSZE5UWXFMVy9uemZMS042V0RjQUFaOFhhTXhFYVQ0?=
 =?utf-8?B?Q3kvWDhUa0VaS2NpUlFFWk9aWTVMZHNmU2gzSUZydVl6dTRNVmU1b1hZWFdw?=
 =?utf-8?Q?1UxtXHwkRT/oYCbTRGcOb9iOa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c89489e1-b7e3-4467-ac2f-08dbd63e0d01
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 16:10:19.9493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 84IwVK12b/PxGHjuVupLnbpX+gP3YWk3J3O1DtwOxkB2/syu3SPiepDeajD7GgIC+5P9p2jHKGMGfXkzbyhGlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6650
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 09:10:53 -0700 (PDT)

On 10/25/2023 4:40 PM, Justin Stitt wrote:
> 
> This patch converts some basic cases of ethtool_sprintf() to
> ethtool_puts().
> 
> The conversions are used in cases where ethtool_sprintf() was being used
> with just two arguments:
> |       ethtool_sprintf(&data, buffer[i].name);
> or when it's used with format string: "%s"
> |       ethtool_sprintf(&data, "%s", buffer[i].name);
> which both now become:
> |       ethtool_puts(&data, buffer[i].name);
> 
> There are some outstanding patches [1] that I've sent using plain "%s"
> with ethtool_sprintf() that should be ethtool_puts() now. Some have been
> picked up as-is but I will send new versions for the others.
> 
> [1]: https://lore.kernel.org/all/?q=dfb%3Aethtool_sprintf+AND+f%3Ajustinstitt
> 
> Signed-off-by: Justin Stitt <justinstitt@google.com>

[...]

> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_stats.c b/drivers/net/ethernet/pensando/ionic/ionic_stats.c
> index 9859a4432985..1f6022fb7679 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_stats.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_stats.c
> @@ -258,10 +258,10 @@ static void ionic_sw_stats_get_strings(struct ionic_lif *lif, u8 **buf)
>          int i, q_num;
> 
>          for (i = 0; i < IONIC_NUM_LIF_STATS; i++)
> -               ethtool_sprintf(buf, ionic_lif_stats_desc[i].name);
> +               ethtool_puts(buf, ionic_lif_stats_desc[i].name);
> 
>          for (i = 0; i < IONIC_NUM_PORT_STATS; i++)
> -               ethtool_sprintf(buf, ionic_port_stats_desc[i].name);
> +               ethtool_puts(buf, ionic_port_stats_desc[i].name);
> 
>          for (q_num = 0; q_num < MAX_Q(lif); q_num++)
>                  ionic_sw_stats_get_tx_strings(lif, buf, q_num);

This works for me for the ionic driver

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>