Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 26 Oct 2023 17:22:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Hector Martin <marcan@marcan.st>, linux-kernel@vger.kernel.org
Cc:     stable@vger.kernel.org
Subject: Re: [PATCH] regmap: Ensure range selector registers are updated
 after cache sync
Message-ID: <66c2f5d4-23de-4faf-a816-919516927f94@sirena.org.uk>
References: <20231026-regmap-fix-selector-sync-v1-1-633ded82770d@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yV82cCzg5Dy/7U2I"
Content-Disposition: inline
In-Reply-To: <20231026-regmap-fix-selector-sync-v1-1-633ded82770d@kernel.org>
Precedence: bulk


--yV82cCzg5Dy/7U2I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 26, 2023 at 04:49:19PM +0100, Mark Brown wrote:
> When we sync the register cache we do so with the cache bypassed in order
> to avoid overhead from writing the synced values back into the cache. If
> the regmap has ranges and the selector register for those ranges is in a
> register which is cached this has the unfortunate side effect of meaning
> that the physical and cached copies of the selector register can be out of
> sync after a cache sync. The cache will have whatever the selector was when
> the sync started and the hardware will have the selector for the register
> that was synced last.

Given the nearness to the release I've dropped this into my CI and am
intending to just apply it as soon as that's done in the hopes that it
hits tomorrow's -next and gets a bit more coverage, it would be great if
you could confirm if this fixes the systems where you saw the original
issue.

--yV82cCzg5Dy/7U2I
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU6kjMACgkQJNaLcl1U
h9CEYQf/Q5ULTgilPiDhR27I79FYeKwJKoonfpkYACVHM8Bg3ARdRNNVH0f1MSOH
WhcTfUdcMXzSdG4pPadQ+ah06DEJxF4iDAqL3AE2uNrxCx1o5qaWNFtUAyc7XAzo
ts2i3VU8CoqvtxtPf7V9I3QX/ah24O4x9TCbT5w2Hgf6wrObBBtHKBsH+ySG1ure
4nYIaFJVgHie/xv8vubBQckPi67fXS/vk/Si/dTPrdbpCZkYs6wyuRDeigPbtmDR
492txYn87M30vK6imwm/0UM8ECAlYbDyfY+yN0rAanOWNerbXoVV4CVBiGlf3h8N
FlIV8R77ikrSVbxSpvjL95IyyfesSw==
=DxNy
-----END PGP SIGNATURE-----

--yV82cCzg5Dy/7U2I--