Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698329862.git.andreyknvl@gmail.com>
 <eb637fd7930722ff9dfc2ab4469d78040ee2a166.1698329862.git.andreyknvl@gmail.com>
In-Reply-To: <eb637fd7930722ff9dfc2ab4469d78040ee2a166.1698329862.git.andreyknvl@gmail.com>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Thu, 26 Oct 2023 18:36:42 +0200
Message-ID: <CA+fCnZfBder34H+zuONEkzJk0_Li91H12AxsO6rCY286RYjFrQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] usb: raw-gadget: report suspend, resume, reset, and
 disconnect events
To:     andrey.konovalov@linux.dev
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 26, 2023 at 4:24=E2=80=AFPM <andrey.konovalov@linux.dev> wrote:
>
> diff --git a/drivers/usb/gadget/legacy/raw_gadget.c b/drivers/usb/gadget/=
legacy/raw_gadget.c
> index daac1f078516..ee712e6570b4 100644
> --- a/drivers/usb/gadget/legacy/raw_gadget.c
> +++ b/drivers/usb/gadget/legacy/raw_gadget.c
> @@ -65,8 +65,9 @@ static int raw_event_queue_add(struct raw_event_queue *=
queue,
>         struct usb_raw_event *event;
>
>         spin_lock_irqsave(&queue->lock, flags);
> -       if (WARN_ON(queue->size >=3D RAW_EVENT_QUEUE_SIZE)) {
> +       if (queue->size >=3D RAW_EVENT_QUEUE_SIZE) {
>                 spin_unlock_irqrestore(&queue->lock, flags);
> +               dev_err(&gadget->dev, "event queue overflown\n");

This is wrong, no reference to gadget->dev here. Will fix in v2 or
send a fix up.