Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <fd996a28-99e6-ea69-df0e-49cf68780d16@roeck-us.net>
Date:   Thu, 26 Oct 2023 09:49:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2] hwmon: (pmbus/max31785) Add delay between bus accesses
Content-Language: en-US
To:     Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Cc:     "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "eajames@linux.ibm.com" <eajames@linux.ibm.com>,
        "ninad@linux.ibm.com" <ninad@linux.ibm.com>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231023180804.3068154-1-lakshmiy@us.ibm.com>
 <bbbf3668-aa7a-4489-85b0-333cf394abe9@roeck-us.net>
 <25390DC7-E8FF-4706-B241-C45E6DFDF444@us.ibm.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <25390DC7-E8FF-4706-B241-C45E6DFDF444@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/26/23 07:48, Lakshmi Yadlapati wrote:
> Thank you Guenter!
> Should I fix and send the patch again?
> 

Please do. And don't top-post.

Thanks,
Guenter

> ﻿On 10/25/23, 7:48 PM, "Guenter Roeck" <groeck7@gmail.com <mailto:groeck7@gmail.com> on behalf of linux@roeck-us.net <mailto:linux@roeck-us.net>> wrote:
> 
> 
> On Mon, Oct 23, 2023 at 01:08:03PM -0500, Lakshmi Yadlapati wrote:
>> Changes since V1:
>> 1. Changed the max31785_wait macro to a function, following the conventions
>> used in other drivers that had the same issue.
>> 2. Changed the function names from max31785_i2c_smbus* to max31785_i2c_* and
>> from max31785_pmbus_* to _max31785_*, making them more concise.
>>
> 
> 
> Please check Documentation/process/submitting-patches.rst
> for the expected patch format, specifically details on how
> description and change log are supposed to look like.
> 
> 
> Guenter
> 
> 
>