Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp593641rdh; Thu, 26 Oct 2023 10:11:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDFzjPChGV5mtcpSuuuOHOOg2tj5bImPFi0E39OXXn11DqZ5JdIApcLSPagGiBSx7wGpfZ X-Received: by 2002:a05:6870:bf17:b0:1e9:e8a0:12dc with SMTP id qh23-20020a056870bf1700b001e9e8a012dcmr260211oab.24.1698340316518; Thu, 26 Oct 2023 10:11:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698340316; cv=none; d=google.com; s=arc-20160816; b=bzlboazQnLQFBpws6lfHXxiOilMr21HrJ7guZ/4ss5WRWCbNpAvPuZO7Z99ypEjjr3 5gtU0nETJf5IAkdexVCqSETiTrXERECiGRbY7mZ4YDlOsbX9s71FF7PmweLNduyWEwO0 TTuXNZYzt6RHJLZZEBeMjgvyLZ3dpm+KQFUDbqAKp7SyVoYQ/z3SgAjOs99WlVRqNrGw yPeJK/kXh69UEvgM5B3AYSQuFinKY6RrbC3Fr8RKkgqO059kPbDGyfGoN8PUcnaiqnZx TjqYrXT7Fpr7NhCzOK6aGxLKoTY+/0oAN6Gn70k+S0DpksTp7/dBZFwyADLpT/ELTfIH 3K2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=b+b3te2DwYywqjIiY8hga8wTzUv9c0ds1pzLWR2VOXk=; fh=Mn09ghnXlWxIMgfWfif1K2bfgqjJ8E/L0X/RYCvAn5M=; b=ki0yJxsQOehwzVCUT8uHLHaY3fNGC+ORoxW63l5/cRQHDeCbyjJUyNg3Cuv8XFNOM5 7HWRkHuYsx57d0MW+2vERh476FULS+fg9FoNi2+2IiwaA8XHBo9khzZcyFK9P9reEbji AXRj2RwNDdKaCUak9o0GsDRSCiIPLJCrxWFVfYw2mOvHB+sdAQqZrN/kWBoRbJEQGcED myMboXvgaQ54uJXIePsPSupe/gOy2bWp07qqjRKeodMDspGurPr4Ys9bboRcLH18Cmay UIKjmAnNGS2xcR5XU+0AMrHRZK8xiJxU2bgHJNP2hNUj5akmGaxm0NF6OtXbyfczNMR1 8GMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AnQ+nJYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id e65-20020a251e44000000b00d7fd681a51asi15120959ybe.732.2023.10.26.10.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 10:11:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AnQ+nJYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9336181B5A85; Thu, 26 Oct 2023 10:11:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345405AbjJZRLa (ORCPT + 99 others); Thu, 26 Oct 2023 13:11:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345376AbjJZRL0 (ORCPT ); Thu, 26 Oct 2023 13:11:26 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8AC91; Thu, 26 Oct 2023 10:11:24 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-5a9bf4fbd3fso976571a12.1; Thu, 26 Oct 2023 10:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698340283; x=1698945083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=b+b3te2DwYywqjIiY8hga8wTzUv9c0ds1pzLWR2VOXk=; b=AnQ+nJYORiJExIflszqTA1NzEglFdQJk35FRbDQuvsjIXjNwiuKVSQMTK3d45EfoRc CbBWDDnIYPQQP8qgp/CnIN2y3JGgJ9zo1LP9OrbWtooACCy0+sv9nsB3ZdWkaPGVYLP6 PAdBVm964g6tH3uwdLytbexFWP7k47wc4rGDbVM30frXGo0+5alTFIlDpZmD4qVC0aUE 9orPSs6aiIh4uLsPU5DG/pVIT3g+nVfdSkj5851LvEPSjtZcMGO/UcA85qQM64CEgKT8 OrJ7kIy65uA+dxA2bCWR62yvcZt8UlLs++k1ttuXCcF0G/GtgK71oqeJwOpOsIFXYXn6 tBoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698340283; x=1698945083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b+b3te2DwYywqjIiY8hga8wTzUv9c0ds1pzLWR2VOXk=; b=G0fxHuwHN/mcLMjNU29KrDcUqLpuTHYPrtPxpAh5eSRATwqe09ShsqUlaxHFs5nZm7 fm6v2awmj3vSHRBFOBYynPdGswPA9fblXUL56U0U7AQYxzQ/JFe3i6BnROkwnpli2K8A PAomkbNahg3PZE0qm3JDY3aMMRbnh5ne8HdKFbetmL10iyq7Ne97bzUZ+22eVZQ6Ks1G q/Gb/DUrI0fLQqIv2EOKOjw7uiDm/sNUVJNMkac0QJ2typgVPce5GU1B9LrMtBD8g7I3 Up3tIfZHWOXPoRm6wk+VWfxbt0L5Ixqox1dGVJhA5rsAVQaWN8HyI7hrVbMkGtZrirpn YqSg== X-Gm-Message-State: AOJu0Ywi5izA4lWgpNcl0sRxIXPfrValSnGDnPME54cyQjklIff5N56e EMjEZdrVlJN7BEQ8SboPK3Q= X-Received: by 2002:a05:6a20:3d82:b0:16b:9886:7eda with SMTP id s2-20020a056a203d8200b0016b98867edamr501084pzi.35.1698340283370; Thu, 26 Oct 2023 10:11:23 -0700 (PDT) Received: from moohyul.svl.corp.google.com ([2620:15c:2a3:200:ec51:cb82:a169:2ada]) by smtp.gmail.com with ESMTPSA id k15-20020aa7998f000000b00688965c5227sm11356315pfh.120.2023.10.26.10.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 10:11:23 -0700 (PDT) Sender: Namhyung Kim From: Namhyung Kim To: Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , LKML , Adrian Hunter , linux-perf-users@vger.kernel.org, Ian Rogers , Peter Zijlstra Subject: Re: [PATCH] perf report: Fix hierarchy mode on pipe input Date: Thu, 26 Oct 2023 10:11:11 -0700 Message-ID: <169833996388.1181734.3051920334476183711.b4-ty@kernel.org> X-Mailer: git-send-email 2.42.0.758.gaed0368e0e-goog In-Reply-To: <20231025003121.2811738-1-namhyung@kernel.org> References: <20231025003121.2811738-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 10:11:53 -0700 (PDT) On Tue, 24 Oct 2023 17:31:21 -0700, Namhyung Kim wrote: > The hierarchy mode needs to setup output formats for each evsel. > Normally setup_sorting() handles this at the beginning, but it cannot > do that if data comes from a pipe since there's no evsel info before > reading the data. And then perf report cannot process the samples > in hierarchy mode and think as if there's no sample. > > Let's check the condition and setup the output formats after reading > data so that it can find evsels. > > [...] Applied to perf-tools-next, thanks!