Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20230926205948.1399594-1-irogers@google.com> <8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.intel.com>
 <CAP-5=fWk12jKjVmV+aJ_U5A=ao7L1ha-wOHaM+ytO9oF0nP9zA@mail.gmail.com>
 <CAP-5=fURbve928P5CGi-dQ7Y8mZhxRmi9wucFc_gP+aDGMftYw@mail.gmail.com> <CAP-5=fU5W=97NFvL1yUKw+rrbBrcd8c-S_y3=86SYv+pszNjmQ@mail.gmail.com>
In-Reply-To: <CAP-5=fU5W=97NFvL1yUKw+rrbBrcd8c-S_y3=86SYv+pszNjmQ@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 26 Oct 2023 10:12:41 -0700
Message-ID: <CAM9d7cjRac8i9+VWYNfWxNr5iz3bUUxc0-Phfcbk0RdfwXqr6w@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde
 tma_info_system_dram_bw_use metric
To:     Ian Rogers <irogers@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        "Liang, Kan" <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Ian,

On Wed, Oct 25, 2023 at 9:20 PM Ian Rogers <irogers@google.com> wrote:
>
> On Wed, Oct 25, 2023 at 2:56 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Thu, Oct 5, 2023 at 3:16 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Wed, Sep 27, 2023 at 6:47 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
> > > >
> > > >
> > > >
> > > > On 2023-09-26 4:59 p.m., Ian Rogers wrote:
> > > > > Broadwell-de has a consumer core and server uncore. The uncore_arb PMU
> > > > > isn't present and the broadwellx style cbox PMU should be used
> > > > > instead. Fix the tma_info_system_dram_bw_use metric to use the server
> > > > > metric rather than client.
> > > > >
> > > > > The associated converter script fix is in:
> > > > > https://github.com/intel/perfmon/pull/111
> > > > >
> > > > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell variant events/metrics")
> > > > > Signed-off-by: Ian Rogers <irogers@google.com>
> > > > > ---
> > > >
> > > > Thanks Ian. The whole patch series looks good to me.
> > > >
> > > > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > >
> > > Would be good to pick this up in perf-tools-next.
> > >
> > > Thanks,
> > > Ian
> >
> > Ping.
>
> Thanks Namhyung for picking this up. There were two other patches in
> the v2 patch set that Kan reviewed:
> https://lore.kernel.org/all/8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.intel.com/
> that I don't see in perf-tools-next.

Sorry about that.  I'll take care of them too.

Thanks,
Namhyung