Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: Document USB support
In-Reply-To: <20231020181059.7rtj2csi7t6vorrm@begin>
References: <20231020181059.7rtj2csi7t6vorrm@begin>
Date:   Thu, 26 Oct 2023 11:35:48 -0600
Message-ID: <87fs1x70cr.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> Speakup has been supporting USB for a while already.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> diff --git a/Documentation/admin-guide/spkguide.txt b/Documentation/admin-guide/spkguide.txt
> index 74ea7f391942..0d5965138f8f 100644
> --- a/Documentation/admin-guide/spkguide.txt
> +++ b/Documentation/admin-guide/spkguide.txt
> @@ -7,7 +7,7 @@ Last modified on Mon Sep 27 14:26:31 2010
>  Document version 1.3
>  
>  Copyright (c) 2005  Gene Collins
> -Copyright (c) 2008  Samuel Thibault
> +Copyright (c) 2008, 2023  Samuel Thibault
>  Copyright (c) 2009, 2010  the Speakup Team
>  
>  Permission is granted to copy, distribute and/or modify this document
> @@ -83,8 +83,7 @@ spkout -- Speak Out
>  txprt -- Transport
>  dummy -- Plain text terminal
>  
> -Note: Speakup does * NOT * support usb connections!  Speakup also does *
> -NOT * support the internal Tripletalk!
> +Note: Speakup does * NOT * support the internal Tripletalk!
>  
>  Speakup does support two other synthesizers, but because they work in
>  conjunction with other software, they must be loaded as modules after
> @@ -94,6 +93,12 @@ These are as follows:
>  decpc -- DecTalk PC (not available at boot up)
>  soft -- One of several software synthesizers (not available at boot up)
>  
> +By default speakup looks for the synthesizer on the ttyS0 serial port. This can
> +be changed with the device parameter of the modules, for instance for
> +DoubleTalk LT:
> +
> +speakup_ltlk.dev=ttyUSB0
> +

I've applied this.

We *still* really need to fix the license for this document, though...

Thanks,

jon