Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 26 Oct 2023 10:17:52 -0700
From:   Darren Hart <darren@os.amperecomputing.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org,
        Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] sbsa_gwdt: Calculate timeout with 64-bit math
Message-ID: <ZTqfQJiEMRD0Xc9S@Fedora>
References: <7d1713c5ffab19b0f3de796d82df19e8b1f340de.1695286124.git.darren@os.amperecomputing.com>
 <bcc41311-075c-44fe-b0f7-30564d7ac58c@roeck-us.net>
 <ZSpbfXzFeaoUJRZ3@Fedora>
 <1fae4d2c-4bc7-f169-7b84-501674a82ee4@roeck-us.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1fae4d2c-4bc7-f169-7b84-501674a82ee4@roeck-us.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7DiB6cPTr+lbmBaLcXfykX2DZaCRbg3zmc2mMiUvygO0m+Z9JIvqh2GijFhX?=
 =?us-ascii?Q?ZwJ4L4B668be4uS6TSVlTZ4Dp9IONDcF3f9OOKKzDlnW9rZGPaC6fEYCScgH?=
 =?us-ascii?Q?zxSUdLeIYFs+PuQeC7letsYHN+G40rH4K/xelp3UZhzBoUT4ixyKMpVbPmyR?=
 =?us-ascii?Q?nPW2wIH/pYTZEpvRtY8IHXO6hF7aWHakL/zcCb51W9yIgmzZ6UfsWZ/VLaiw?=
 =?us-ascii?Q?u1utkaN9rY/seXFsvXimUlOOt2OKgkvtQfGUMa+MXbaDyjhzyJGSvsBY0ntk?=
 =?us-ascii?Q?fErqHNMY5utZP2+WwdpYYYTZ+7/30ycMfMYc9leMXpNVzi9geY/8mRfiZDaA?=
 =?us-ascii?Q?svZKagvQAKsRq0oU05e8mesSfVaxybU3bHijYbyHDVqSb8mAlpuFq2Zk0r+d?=
 =?us-ascii?Q?zC8LDwSUh/r4W4LQbWa57W6c62C6B6EjGSYgVq+x/r9AWd+k6Fxw5owMOsjK?=
 =?us-ascii?Q?dyi0zCbk5yIZYywsNSmqklwc+mE7RjBXOykNCZpPEp/S8oW/Anotl7JGhZjG?=
 =?us-ascii?Q?quZaZF/SNmg8WeITNDjL2YRHJWW8eVWhnKnfETzcleBHPLm4bTTKti+dAbwx?=
 =?us-ascii?Q?zs9258VLu+pg98y6HkQkitx/SscnQ6/gUVSEws6ZztE8PKlBW4J5lxRSVD9b?=
 =?us-ascii?Q?k1rU9cB9BmaAT0Bp0zoFT1yzV6TI1QvMyKzXh4NyYVFeVNyoJLkSFIIaO3f/?=
 =?us-ascii?Q?uXaMdtp904ckJ6MUfiCEQABDK8UwzwksP3VYAX9D7Mp488uSWDX7s1WZbQR5?=
 =?us-ascii?Q?VqYfb60/17ddaNpKj5M2bZtXx149nUcidG0Q0kUZbIr5k9FdZ132yUkhZcq0?=
 =?us-ascii?Q?uqgCir2eHEmBEjrb0/qBGHxMnQslvkH3UC5qat7GWQryWpe//qgbtfDDIn1E?=
 =?us-ascii?Q?HO9Mw/4zCUe3uXQ2LNYjVGbcmvLv98WvRmfx/4sZc/Ve02WVFbYuGy445L1j?=
 =?us-ascii?Q?Khtjvi1fMnpJ6eVcSf7c0ucdx5HgxoC4ztg94EIvDU+0nk7p0cPKQ9Kq11cQ?=
 =?us-ascii?Q?L5YHtVIt8nT0hWRwx209NiAHTa71vUwOI1h1LZP4r31cDsE7nAv8Lsgc3jR9?=
 =?us-ascii?Q?bF4wnvvK2xsJKok2WSm69pizHBrzLvzZg2RYb6UD7Zqh8ET6m0bnWVq2Yy+l?=
 =?us-ascii?Q?Om5lbJVvOjxyhdTDxNDU+jjdmyTrztJ05Pl7oGid7mbJF5wniuBdQMiR10L4?=
 =?us-ascii?Q?NAZPqofjg2DUH5rBcvTWGd3J9gOSdnyMcZhiKxy9KYKtsZr/uH6tOaRH0a3J?=
 =?us-ascii?Q?FQHj3yrXWusbtEMMjeNbBySRjJIdW8ske/pOxZ89pHoEmXDYRp51ZhEzi7BI?=
 =?us-ascii?Q?atjqxQ5C2abgd9qZAhFuTkAxuERBPxRln/IizqKdPWeYYdJ1heDzrbDhy+yR?=
 =?us-ascii?Q?clxtt1Ef2bEmOa0sXsTdcwgBfBnfs/ltEJ4NcbOdgBTu7sOyxZMAZalk1/HX?=
 =?us-ascii?Q?VRTZRytKTPdcVD+HiEBXNNa5nVlJNY3hB3Mq0NwT8sk5qjNn82CJ+rd1c+ZH?=
 =?us-ascii?Q?rQ5MIlj3V7RGKDDN1T5A1KL2C4hjNoPT9cv0xIy7aOpGOEUy4sw5fksRx6IC?=
 =?us-ascii?Q?dA4A1Jc9u0HHRO1aCcEdwXMiDpH/g2thBgIyEU4/8Uq1/hMVD9+gPNNj7VEk?=
 =?us-ascii?Q?0cWRdk0xB7jIvrfOgFRYJFY=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c42e0860-c29a-4b34-8cba-08dbd64b1561
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB6795.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 17:43:38.0538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FgbOBQetg3Eh490i58pr2IplIlhbWcjw5LCaKI6xS0DFXHQIt/F6nfti8xMYwZ4e+tUcj6DtOAYfoMnqUjnPbmeBFLkkoEHoYOlvJN+Y9z9TIbZvzSMuAemlXoWMYDls
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6462
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 26 Oct 2023 10:43:58 -0700 (PDT)

On Sun, Oct 22, 2023 at 09:58:26AM -0700, Guenter Roeck wrote:
> On 10/14/23 02:12, Darren Hart wrote:
> > On Tue, Sep 26, 2023 at 05:45:13AM -0700, Guenter Roeck wrote:
> > > On Thu, Sep 21, 2023 at 02:02:36AM -0700, Darren Hart wrote:
> > > > Commit abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> > > > introduced new timer math for watchdog revision 1 with the 48 bit offset
> > > > register.
> > > > 
> > > > The gwdt->clk and timeout are u32, but the argument being calculated is
> > > > u64. Without a cast, the compiler performs u32 operations, truncating
> > > > intermediate steps, resulting in incorrect values.
> > > > 
> > > > A watchdog revision 1 implementation with a gwdt->clk of 1GHz and a
> > > > timeout of 600s writes 3647256576 to the one shot watchdog instead of
> > > > 300000000000, resulting in the watchdog firing in 3.6s instead of 600s.
> > > > 
> > > > Force u64 math by casting the first argument (gwdt->clk) as a u64. Make
> > > > the order of operations explicit with parenthesis.
> > > > 
> > > > Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> > > > Reported-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
> > > > Signed-off-by: Darren Hart <darren@os.amperecomputing.com>
> > > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> > > > Cc: Guenter Roeck <linux@roeck-us.net>
> > > > Cc: linux-watchdog@vger.kernel.org
> > > > Cc: linux-kernel@vger.kernel.org
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > Cc: <stable@vger.kernel.org> # 5.14.x
> > > 
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > Guenter or Wim, I haven't seen this land in the RCs or in next yet. Have
> > you already picked it up? Anything more needed from me?
> > 
> > Thanks,
> > 
> 
> Sorry, I am suffering from what I can only describe as a severe case of
> maintainer/reviewer PTSD, and I have yet to find a way of dealing with that.
> 

I'm sorry to hear it Guenter, it can be a thankless slog of a treadmill
sometimes. I found having a co-maintainer a huge help to even out the human
factors while maintaining the x86 platform drivers (in the before times).

In the short term, should I ask if one of the Arm maintainers would be willing
to pick this patch up?

Thanks,

-- 
Darren Hart
Ampere Computing / Linux Enabling