Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <7e16351f-4d70-4451-b3c7-1dadfa41f20b@kontron.de>
Date:   Thu, 26 Oct 2023 20:12:33 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC] drm: bridge: samsung-dsim: Recalculate timings when
 rounding HFP up
Content-Language: en-US, de-DE
To:     Adam Ford <aford173@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     marex@denx.de, Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonas Karlman <jonas@kwiboo.se>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        aford@beaconembedded.com,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Maxime Ripard <mripard@kernel.org>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
References: <20231013031040.152282-1-aford173@gmail.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231013031040.152282-1-aford173@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UERrOG5TZlZwam11ZDhrT0MyM1daaDFKLzhaVGJSUzFFQVdOQlY3UFRQbDRS?=
 =?utf-8?B?WThpVFgxLzVnUmp1UFZUQ29sMjFzeW8xK1FjTkJjWk83cHdINjRFSXdqa3Vw?=
 =?utf-8?B?ZlZNNkJlZEwyUVhEdndaK0tmRDh0ajAxMG1rTXBKNi9tQjU3WjBkeFVSeWkz?=
 =?utf-8?B?dXBXSW8wSnBEQkI3N01sYiszK0M3Nnl5L29FY3lQZENFdEtTS0FCTUp5cWty?=
 =?utf-8?B?UkFUZlpwREg0cEFIS2U4bm9udXBGdVgzV0wvT1FEbThzY0xNOWs1VWRXang0?=
 =?utf-8?B?a2h2YkRRVldPaDFDSjFmS1F4TFhyeG1rTXVodVgyZTNoVGN0Z0tJK2xIZ2tj?=
 =?utf-8?B?Y0liaUFuSzNqRVRHdWEvQTBvOTNqd0tjSUI0OElBZEZOTER2NitLZlY5ZG0x?=
 =?utf-8?B?L1VMNmJKWUdlWkdlck1ZN0w4cWgveXJpS21VNDNCKzFWSGhXSGdKOWZ0dlJJ?=
 =?utf-8?B?dUJQZzJUK0UveUZsTDIwc3N2YXVPNzR2Z1dSVUJZQWxyQWJrbXlsK1FwSy8v?=
 =?utf-8?B?cVZFSG9lekE1ZUdFQkp6d2FFZ2JCWEJlelAvMHdaeWhiVThBckkrdXJZQndk?=
 =?utf-8?B?NGhrTXNjRm5URTZTZDE0SUxOTG0rd3NkZ3J1aVhPY2tHeDVHa0pLb0ZCaUNP?=
 =?utf-8?B?aythRmtsY2JNT0sweFRPVUdpcUozQ3BDRUNtbVV0Z3RQYWFKWXRsMmpHa3Q0?=
 =?utf-8?B?ak1SKzVNcS80OWtZaVpPMUpZaHZkZkZwUmNhaG1yazRYeUhYMmF2ejRMQ2Fz?=
 =?utf-8?B?R2swTkp2TVkya056T2lScm1iait2bjhac3ZWZDcrUmJEZ0tPamxlRDhWK1Vv?=
 =?utf-8?B?VHpJZXhxNGIvMUFqOEFEWm5pZnZqRng0anUyWFhScDlDUFllZUxEaWdobmJU?=
 =?utf-8?B?NHl0bkdvTzNsUzBiNU1SUy9KekpKczltZ29ZeThlTHd6SVUvTHJyQ0E0bHRo?=
 =?utf-8?B?YzhkRlBBT1E4ait1Z0hSL1BZYk15MjR5b05nbUpRUGlXMGhmaXNlMHBsRGgz?=
 =?utf-8?B?QWQrbzlBZWkzWHJUK3F6ZWRyb1BnZnlWdHo5RDRQSzU1QkdkbFc1VTRjQ1Rz?=
 =?utf-8?B?OTVsby83K01mejd3aGpmOUd2MUJzeVpBRjZ0enMydmFFQkhuODlTRnN6UlBY?=
 =?utf-8?B?bS80aEZtU0wyYjVOQURuaWpGMjNxS3ZnMVkyaVRTSUV5ZFgvZS9pbS9vZEhY?=
 =?utf-8?B?ZTlyazRLbTQ4dmp4Uit4dXJHanpVTnMwd1J1em5nSXVocmd0SU5KMkVRaXpC?=
 =?utf-8?B?b3pSWWdDNVdXRmdoUmhqRHcrOG81VXlBNkk0WG54Sm5FV2MzVms4NnZaN0wz?=
 =?utf-8?B?ZytVeURCNGNNMzJhMjFKQnlVZjNjUnZOelFqMHdoaUJPYUdnOGxvUVY5QjA1?=
 =?utf-8?B?YXVOUm0wa2hVWVQ4eTBDTUNTOTQ2M2ZJcXhSdzE3OVVtT0ZPSG93NGlicktv?=
 =?utf-8?B?QWVxeEZjZlpLZWYyQU5ZZFJTbjZRNjQzT0dscEk3SG16VUFDSHJpNXFSS0hZ?=
 =?utf-8?B?SlhFSmZLbkpML29vczJMNTAvWjlZWmdwL0RZT2JvZGh6WC8wYTQyQmdxU21T?=
 =?utf-8?B?WWlvZ21DRWdKQU9FY3lzNlVtMTRYSmVtMFdUTEVyekdIT3pKbENOMUwyN2lE?=
 =?utf-8?B?a1hWdHR5b2NyNnZIVEtmb3JDVi9JKzl3S3FCeDVSRlY1bksvTW90czBYalEr?=
 =?utf-8?B?YVpodjdWUDNmaDlCS0JQU010MHdwV3c3U0JGL1hyejBvS09zQVY2NTErc2do?=
 =?utf-8?B?czhSY3JjRHc2dG0zQkJNWW9hTWZLQXgzaEVZOGZJWjRRZ1kwL1RWVFZOTEJ3?=
 =?utf-8?B?UGxrdUx3SzlzVnljNngyOUJMckVUZFl1NHBGbkI3Ry9NL1h4bHlpODZkLzBI?=
 =?utf-8?B?MzhJM2FzbXIzcVNzZ1RqWDVBMU1LQU1XeHIxL1IreVZ6bTkzWlVVaUcwbzh2?=
 =?utf-8?B?VWdvZC9UQ29iaC9EYW5yZlRIOWk2TGJxWjRFUnBkNlJSY2xNK1JwV01LRFd6?=
 =?utf-8?B?SW43aDQvMHRFM1NKOWRObHZhMTEwbUFMdm01dERUYWMyRkk4MHd5V3k0VGxN?=
 =?utf-8?B?K2VzS29rMnJUVnVDQno1eFk3NUN4VVV3K1dQSHRUTHFvUm9FR2dlU1FTdm9F?=
 =?utf-8?B?Tm1qVTVRRjhDL1dvdGhHeFVjalhTSzJEMlNvUDUrQkpQTlYvYll2NVZrSEZY?=
 =?utf-8?B?MVE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d5a5b84-9e05-4a84-d436-08dbd64f21ac
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 18:12:35.9965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ExiqESiKpCi4ZLOjwazI2tF6FShHWoNzyINlCbubj+z3+RNx/qy7WdQ5gYPCG7w6fr09OMk/Z0oRR1NEjLV2089O3y8XyjnDsljI5Gv+x0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7762
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 11:12:48 -0700 (PDT)

Hi Adam,

On 13.10.23 05:10, Adam Ford wrote:
> When using video sync pulses, the HFP, HBP, and HSA are divided between
> the available lanes if there is more than one lane.  For certain
> timings and lane configurations, the HFP may not be evenly divisible
> and it gets rounded down which can cause certain resolutions and
> refresh rates to not sync.
> 
> ie. 720p60 on some monitors show hss of 1390 and hdisplay of 1280.  This
> yields an HFP of 110. When taking the HFP of 110 divides along 4 lanes,
> the result is 27.5 which rounds down to 27 and causes some monitors not
> to sync.
> 
> The solultion is to round HFP up by finding the remainder of HFP /
> the number of lanes and increasing the hsync_start, hsync_end, and
> htotal to compensate when there is a remainder.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> This adds support for 720p60 in the i.MX8M Plus.
> 
> NXP uses a look-up table in their downstream code to accomplish this.
> Using this calculation, the driver can adjust without the need for a
> complicated table and should be flexible for different timings and
> resolutions depending on the monitor.
> 
> I don't have a DSI analyzer, and this appears to only work on
> i.MX8M Plus but not Mini and Nano for some reason, despite their
> having a similar DSI bridge.

I just want to report that I have tested this patch (on top of current
linux-next) on our Kontron BL i.MX8MM board with the ADV7535 bridge and
I don't see any change when trying the 30 different modes the monitor
reports as supported. 18 of those work and 12 don't work.

So at least there is no negative impact in this case.

Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL
i.MX8MM with HDMI monitor

Thanks
Frieder