Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp684043rdh; Thu, 26 Oct 2023 12:41:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmVWbjt8E6MQWhR2GW2S1+MhYaEtEOS3lPh+l2ecClYMeR2dTvJO31DM2YyCs6Fp4VAilN X-Received: by 2002:a05:6870:7d10:b0:1ea:183d:ff63 with SMTP id os16-20020a0568707d1000b001ea183dff63mr750095oab.46.1698349273599; Thu, 26 Oct 2023 12:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698349273; cv=none; d=google.com; s=arc-20160816; b=m8X9YAz1paHcm9JyJWeMDVOE0vRpgg0v96lkuTNeG9Gfc7mC3aiXoI0A0rMTIRs56h 0e1ManD+21QPu3kyjn563KKm6Q953tyYxUJ8GcfpVG+qpQTqZuQx3W2eSBVjiKqYhoh4 6NE7XXLG47TMox05OGxcjxyb54GEJk51fCrZJJ7XFIWIUC+61WW9RaIMT+l40bpMIyt/ HWrt/Q7qw744DUVkSDcgOSpXH6IxSO6P3Fx6f3Es19W//xjPmkMMVEpISrjLT80OB4LX ghQ5qhoXH9k274aMginxTLqALLU3yalEywi4jNBpSEkp3bX4si67rGzP3o0riCVC+SXq hCzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=zhA6zySIQHY0IGOpeI36r/Qf2GtzopfCqJ3B0A1W8GU=; fh=agrAHtIqZjhpGmH9pxiFKwkxGwm49Bo65e/FvJpqY00=; b=iBaJ6fmkI6dE8IkCkZWKx+783Qli43aVi6GX93efG6qesZpjVAz3IeHnfNYfztGejK 6RdDFp6et0vISFCjLqW3Mfyt8sYtXCaxrCgknPoj0OgrCvMsgun4V1DwPmhiYfYb4rGp EieEQ/WqLIROZxPfeKnPBqauzqeoJF5gAHPnvlPhcsCepY9+yIQzvCGD/VGpin+IxfDo xBr7z055jAK4bVnhKhmjT/uvPLfmI+yFHnME0STemFTE+sKDrNyaaXVDNQt5CkR/3QVf T2zocdmuJiOJURdLYPiqn1lu6rwrQeVT9jDWf/LhysCrWKCaEuVZNjVSDhIcSJbQKlem VZFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZnMyTh1D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id f3-20020a25cf03000000b00da0b72ef24csi124834ybg.729.2023.10.26.12.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 12:41:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZnMyTh1D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2E7F18119780; Thu, 26 Oct 2023 12:41:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231921AbjJZTk4 (ORCPT + 99 others); Thu, 26 Oct 2023 15:40:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbjJZTky (ORCPT ); Thu, 26 Oct 2023 15:40:54 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B06A21B4; Thu, 26 Oct 2023 12:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698349252; x=1729885252; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0Nzv5LTJJEKsHmknlPaS9KY3l2lpzNkwRdh66CUbomM=; b=ZnMyTh1DICXnoRMfGaqWjVd+M7sNeLrxzRtd4LdJHyXJtUJ3D0tZFbgQ aJDDSRb1orcct0khHBWkeu+89HpIo8gbDs+2VDRPfGuwrFN4VuTwalF5F umJ8OzIciK0zJHWTjp+jqQi+y0HV6dCYzjAulxdMedDzEJeDJcY2z+6CS GQ9perKavjOnOIa1+U7qkB8+3GES8bzIRIqNkj3Db+z36E90gm5WwxlqR be5p3D8ayAL0b/pj5EefmFw09oaEg93BHfdXSiHN0VpAIoQ8AmrFFGI4C LCITCAPHDS3uLeiQHj/WhHjRCXJwJwLfWuKGG/+P9PUlcN2TcMkwKknYt A==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="377995506" X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="377995506" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 12:40:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="7399054" Received: from pjmartin-mobl2.amr.corp.intel.com (HELO [10.209.32.248]) ([10.209.32.248]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 12:40:39 -0700 Message-ID: Date: Thu, 26 Oct 2023 12:40:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] x86/entry_64: Add VERW just before userspace transition Content-Language: en-US To: Pawan Gupta , Nikolay Borisov Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com References: <20231025-delay-verw-v3-0-52663677ee35@linux.intel.com> <20231025-delay-verw-v3-2-52663677ee35@linux.intel.com> <2cda7e85-aa75-4257-864d-0092b3339e0e@suse.com> <20231026192950.ylzc66f3f5naqvjv@desk> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231026192950.ylzc66f3f5naqvjv@desk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 12:41:07 -0700 (PDT) On 10/26/23 12:29, Pawan Gupta wrote: > On Thu, Oct 26, 2023 at 07:25:27PM +0300, Nikolay Borisov wrote: >> On 25.10.23 г. 23:52 ч., Pawan Gupta wrote: >>> @@ -1520,6 +1530,7 @@ SYM_CODE_START(ignore_sysret) >>> UNWIND_HINT_END_OF_STACK >>> ENDBR >>> mov $-ENOSYS, %eax >>> + CLEAR_CPU_BUFFERS >> nit: Just out of curiosity is it really needed in this case or it's doesn >> for the sake of uniformity so that all ring3 transitions are indeed >> covered?? > Interrupts returning to kernel don't clear the CPU buffers. I believe > interrupts will be enabled here, and getting an interrupt here could > leak the data that interrupt touched. Specifically NMIs, right? X86_EFLAGS_IF should be clear here.