Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp694149rdh; Thu, 26 Oct 2023 13:01:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjZPju1bU6od7XrUUZ1YPY6a+8KGFHO+c8bau4Zb4TAkApLEuRkDkIQxh3zXxT/2m4XJPD X-Received: by 2002:a05:6871:5307:b0:1eb:e8b:7179 with SMTP id hx7-20020a056871530700b001eb0e8b7179mr718182oac.34.1698350493455; Thu, 26 Oct 2023 13:01:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698350493; cv=none; d=google.com; s=arc-20160816; b=O0hehyqrDdZ2ipwHiNjiXv0GTFKaihLkMpCf6kRMwIkaNpSE69VF4AhZQsJPs7nhfa VQ/T1WrzoUuzdjtJw3/xCzpFp/3ZIphEgOkK8iafNhFakE6geRQMWaTyT+SA9BEXPhMZ R4TDF6ReVG8euEylnmOtcqeWpIg595dVtwdhTCspzjJIr6KjJ1a08hxL495dI4SULtB6 WcoPI4SjNBHPIC0C06c0z6q7gEhKIclFTDdnXeHuzG1wIBvQXxxNWjF6rHTVFfsziSRa sax7Yn2S7CBqH4SDYSRhv0bHOahV47C/IabI0SzcIOOg0gVaNfFtuwKeALANoKEHmfXT Fmgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RvOXwandeVYtdokqifAIU5QghzlMJsS3czqYn7Psq7E=; fh=DBw8sIhCOs/zdXI6cu93/8Vq3AXghKAi7SgsQJ3PTcg=; b=ElORVlp4aOz4pLw+uK7s7Jh+GiyhL9SVS9uI7oCyh+9K52nQboGChpfrgbk7gIAYv0 bDqhXQSSG7V7dTl7mAArWYhoaRDx784B9u5aH1TO16cRytEs/mfxHelW+r5xMviKa03a lcfMMfMr7MBFFclrcmrYNPl6d3rUTV9hdF5jexXHnaDm5g+8UbQM/8+gPjpfq/uj10pH CHxlMuom7ubrUODi+qa1I/W514PlENCKSydIY4oRaycuiNl7w46QXXwrhAlgIJCbdyV5 NEOBgT1xDs0KEdNISzT8WXDYJYD92Bd7TiZLySnjeLd+AZIUckFG4bQ/T79lMSx0dBrT rRBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="kRfJ/Tcx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id eb14-20020a0561302a0e00b007b9d17b6044si12847uab.85.2023.10.26.13.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 13:01:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="kRfJ/Tcx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BE164809849E; Thu, 26 Oct 2023 13:00:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbjJZUAY (ORCPT + 99 others); Thu, 26 Oct 2023 16:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJZUAW (ORCPT ); Thu, 26 Oct 2023 16:00:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30900B9 for ; Thu, 26 Oct 2023 13:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RvOXwandeVYtdokqifAIU5QghzlMJsS3czqYn7Psq7E=; b=kRfJ/TcxIaEyeZwdVqfX4UvqrI aY2pRl9eiyXEJrUSsDRRXOn2/hlT7BCsqe/TLrJjdQPqdBafYpuuPJupOgHXFH341YSRFk7j072K1 6zFUdJwNjVCMZiYM+gYrsqMq2K1ukBOiz9ddpwwpI8g+oQ7g9H2HC62bi1bobZctV8YqZfkLzx58R wdJbaeGZAcx2MRd4Hhy2ClAHNIyRoUM5+j7G1QuYmOX0u5DPDeKJ9DubQl+lYHEwsDjy40bt8JJvC 5nPJ22TU/FNOR1xCxGoYKY0vzpahOetj5K68dWUe3qFpip3B3bRJX34JS2+B/KladbvQSwcLngDz6 lK917kEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qw6WX-00GtAR-D5; Thu, 26 Oct 2023 20:00:09 +0000 Date: Thu, 26 Oct 2023 21:00:09 +0100 From: Matthew Wilcox To: Gregory Price Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, naoya.horiguchi@linux.dev, linux-kernel@vger.kernel.org, Gregory Price Subject: Re: [PATCH] kpageflags: respect folio head-page flag placement Message-ID: References: <20231025201237.948993-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025201237.948993-1-gregory.price@memverge.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 13:00:28 -0700 (PDT) On Wed, Oct 25, 2023 at 04:12:37PM -0400, Gregory Price wrote: > +++ b/fs/proc/page.c > @@ -188,20 +188,31 @@ u64 stable_page_flags(struct page *page) > u |= 1 << KPF_SLAB; > > u |= kpf_copy_bit(k, KPF_ERROR, PG_error); > - u |= kpf_copy_bit(k, KPF_DIRTY, PG_dirty); > + > + if (PageDirty(page)) > + u |= 1 << KPF_DIRTY; This is not the way to do it. At the beginning of the function, add: struct folio *folio = page_folio(page); Then use folio_test_XXX istead of PageXXX().