Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <883ce8a7-80e1-4065-a957-424d0b4a6535@linaro.org>
Date:   Thu, 26 Oct 2023 22:05:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/5] media: qcom: camss: Flag which VFEs require a
 power-domain
Content-Language: en-US
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
        rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org,
        mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231026155042.551731-1-bryan.odonoghue@linaro.org>
 <20231026155042.551731-2-bryan.odonoghue@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20231026155042.551731-2-bryan.odonoghue@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/26/23 17:50, Bryan O'Donoghue wrote:
> At the moment we have some complex code for determining if a VFE requires a
> power-domain attachment. Particularly discordant in this scheme is the
> subtle reliance on VFE and VFE Lite declaration ordering in our resources.
> 
> VFE id is used to determine if a VFE is lite or not and consequently if a
> VFE requires power-domain attachment. VFE Lite though is not a correct
> delineation between power-domain and non power-domain state since early
> SoCs have neither VFE Lite nor power-domains attached to VFEs.
> 
> Introduce has_pd to the VFE resource structure to allow the CAMSS code to
> understand if it needs to try to attach a power-domain for a given VFE.
> 
> As a side-effect from this we no longer need to care about VFE Lite or
> non-Lite or the id number associated with either and which order the
> VFE/VFE Lite was declared in.
> 
> Add the flag and populate the resources. Subsequent patches will disjunct
> on the bool.
Generally such things are expected (?) to ship together, but I see that these
patches are quite big as they are, so this is totally fine!

> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad