Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 26 Oct 2023 23:14:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Alexander Potapenko <glider@google.com>
Cc:     catalin.marinas@arm.com, will@kernel.org, pcc@google.com,
        andreyknvl@gmail.com, aleksander.lobakin@intel.com,
        linux@rasmusvillemoes.dk, yury.norov@gmail.com,
        alexandru.elisei@arm.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, eugenis@google.com,
        syednwaris@gmail.com, william.gray@linaro.org,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v10 1/2] lib/bitmap: add bitmap_{read,write}()
Message-ID: <ZTrIoaFE+c5XQXFs@smile.fi.intel.com>
References: <20231026135912.1214302-1-glider@google.com>
 <ZTp2oLST3nR9AZk4@smile.fi.intel.com>
 <CAG_fn=VSYNk=k1kqKo1vQ7Bd87x9evy6GQBfjdNatOp51x8DZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG_fn=VSYNk=k1kqKo1vQ7Bd87x9evy6GQBfjdNatOp51x8DZQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Oct 26, 2023 at 04:48:46PM +0200, Alexander Potapenko wrote:

...

> > > +static inline void bitmap_write(unsigned long *map,
> > > +                             unsigned long value,
> > > +                             unsigned long start, unsigned long nbits)
> >
> > While noticing strange indentation (you have space for the parameter on
> > the previous line,
> 
> I believe I do not, maybe that's something on your side?
> There are tabs in the source, and in the original email.

I meant that you can use 2 lines instead of 3:

static inline void bitmap_write(unsigned long *map, unsigned long value,
				unsigned long start, unsigned long nbits)

> > I realized that this is a counter-intuitive interface.
> > Can you actually make value the last parameter?
> 
> It is consistent with bitmap_set_value8(map, value, start), and in all
> the functions above @nbits is the last parameter.

Oh, then I leave this to Yury.

-- 
With Best Regards,
Andy Shevchenko