Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756799AbXKUEro (ORCPT ); Tue, 20 Nov 2007 23:47:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751672AbXKUErg (ORCPT ); Tue, 20 Nov 2007 23:47:36 -0500 Received: from relay1.sgi.com ([192.48.171.29]:33864 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752063AbXKUErf (ORCPT ); Tue, 20 Nov 2007 23:47:35 -0500 Date: Wed, 21 Nov 2007 15:47:11 +1100 From: David Chinner To: Christoph Lameter Cc: Christoph Hellwig , ak@suse.de, akpm@linux-foundation.org, travis@sgi.com, Mathieu Desnoyers , linux-kernel@vger.kernel.org Subject: Re: [rfc 18/45] cpu alloc: XFS counters Message-ID: <20071121044711.GF995458@sgi.com> References: <20071120011132.143632442@sgi.com> <20071120011335.975705216@sgi.com> <20071120081230.GA1324@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 35 On Tue, Nov 20, 2007 at 12:38:29PM -0800, Christoph Lameter wrote: > On Tue, 20 Nov 2007, Christoph Hellwig wrote: > > > On Mon, Nov 19, 2007 at 05:11:50PM -0800, clameter@sgi.com wrote: > > > Also remove the useless zeroing after allocation. Allocpercpu already > > > zeroed the objects. > > > > You still haven't answered my comment to the last iteration. > > And you have not read the discussion on that subject in the prior > iteration between Peter Zilkstra and me. Seeing as I didn't notice this patchest changed XFS (where's the cc?) until I saw hch's question I'd appreciate a pointer to that discussion as it's long been deleted from my mailbox. FWIW, I happen to agree with Christoph (hch) that the shouting macros are an ugly step backwards, esp. given that is replacing: #define per_cpu_ptr(ptr, cpu) percpu_ptr((ptr), (cpu)) a set of lowercase macros.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/