Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp731633rdh; Thu, 26 Oct 2023 14:14:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjQMwZmLdFvfuehB8xYZxUoa2ecffqzzhzhkrbFBLCSeOBN7fVM8YlXtJLpLwOWp7ZucZM X-Received: by 2002:a05:6870:13ca:b0:1e9:d0a2:f730 with SMTP id 10-20020a05687013ca00b001e9d0a2f730mr701238oat.14.1698354894720; Thu, 26 Oct 2023 14:14:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698354894; cv=none; d=google.com; s=arc-20160816; b=gdMWyp0084IsM/x4I1gzFeToAa5F5K1nvy6mOxiXTK64fiCN9iHmnlc/C6pdXxrx/M TuDlbF9+O1bTsw2HKgfbiZ3yvmigdwTgLuEc36G3y3GmyQdmKjAaP0K0LF/OfvWqRPF0 60k51EqPhDainfvridyZxd3rrNmv0nnYI3+ohVbiwl+0v+KnuEpxusU5GrFz92fEBfXv 2ZT59+SqAmjzRm+7DDIzqivF3P0MkpRaM7LuhFkEKn7U8hgooA69q4Pk7XPk21KQbmC9 ovuFKG1b3Vd3/i1j8pSgKNAqUS6Y814GWTuHlf6BMA6Fg63vY1z5rp4bdIFnCsFbSkV5 iaKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=STBT4USV80X7xjDyPQBrhAt8zpR20Z1FI+DoegQb6k0=; fh=ycjS+CNLmtJv4c+zJsYmHQ2DSkiiK2r6Of9dy8wHrYw=; b=a5PooV1DiV0m2iSoE4XE6//RzF3N3B1SsX3WXdu8PX4UOVUICeMBxrekBOMCrZ7QvC A5rirwRGGQFsNmca7T01xdsBdqcl4fRbcJfNaOmrJenNfc7rkQR6nb2Xr5p7aosbm6v1 jTuy9Jw2jvrhD2CvKuYBS0tu2I848gAD++32M2vTs5cAiIR5MKJqO4aRytiuVsuaqUA0 v6ORv/fiBiTkNvHwRYUSSXDzjcvVut7wNAvTxhfp3IXI29rAPRatI62eO9UMsh6QjLAD 5ce/a1kDK+GVM0VGXH9m3uxUey5hISJ42qgjERawLI7JeUz2BQI1k7gSHwmGHx2Cctjg kYmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hi92sel8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id v127-20020a254885000000b00da0a8d94df2si407099yba.19.2023.10.26.14.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 14:14:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hi92sel8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 04B9E8246851; Thu, 26 Oct 2023 14:14:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232027AbjJZVOp (ORCPT + 99 others); Thu, 26 Oct 2023 17:14:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjJZVOo (ORCPT ); Thu, 26 Oct 2023 17:14:44 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A954A10E; Thu, 26 Oct 2023 14:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=STBT4USV80X7xjDyPQBrhAt8zpR20Z1FI+DoegQb6k0=; b=hi92sel8fx6a1xWS0qj0ZTLs/C aBvXQcKQ5GoQ5MvYk1e7qacr3FeQXgWQK63i1ubM4FgoNQlD17p7gmdLEtJ4/YE8q4tv7UU8xvLyS CUyB/qwwB6tcIYmvkc4s7TuS0yfKgaJOaF2tiTLw6PHrxCoGabYCD5BGbhJkHQHHQwtTm5mY/hmVL ZDkSBZphBgFjFVDpGGFoQEQjNy1VJHGMyGdfLiKiGwIW1Y7gMwWwLLiP/K9vW8+nU2eccdpNv6XZt 3CjL14h0Oda8aQA6e4Zt7gCu5CKzSvd4eqmSnzkhoDF1QAjfpdzkft9JkoLqCx6pgNtO5Ac6nihTW z4xJgRJA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qw7gZ-00FA7v-32; Thu, 26 Oct 2023 21:14:35 +0000 Date: Thu, 26 Oct 2023 14:14:35 -0700 From: Luis Chamberlain To: Zhong Jinghua Cc: axboe@kernel.dk, hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhongjinghua@huawei.com, yi.zhang@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH] block: Set memalloc_noio to false in the error path Message-ID: References: <20231025075436.2212468-1-zhongjinghua@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025075436.2212468-1-zhongjinghua@huaweicloud.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 26 Oct 2023 14:14:52 -0700 (PDT) On Wed, Oct 25, 2023 at 03:54:36PM +0800, Zhong Jinghua wrote: > From: Zhong Jinghua > > In del_gendisk, memalloc_noio is set to false, so it would be better to do > the same thing in the error path. The commit does not mention what happens if this is not done. Luis