Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp747891rdh; Thu, 26 Oct 2023 14:52:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbsGTACY8jH7HoKo3X1qCFqMHam5MGmKu4Dqr0+lcD81US4wW5QXyr37vg2eH3lB5pg+06 X-Received: by 2002:a17:907:9412:b0:9b2:74a1:6b30 with SMTP id dk18-20020a170907941200b009b274a16b30mr701243ejc.33.1698357149373; Thu, 26 Oct 2023 14:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698357149; cv=none; d=google.com; s=arc-20160816; b=uFv9XZjA7N7+kr8VAaFOXuWWTu/lUvCk3OjyUMPMwEvFc9qT+h/ZoahmiEEsoGlk4A Z7yycm2spEZH3MQ22qgJoO4tMMR/YrFtxflZLAjYOxlH/XnVBnpRCw1eBZ9CZlvJhQ87 YGrnVUklz1drW8hbFkTLo5gU4+bfvDtQ6jBA7tabXw6fWlkf7C9m/44/ptSRa747uvlD 8ZxScTNkEnED5rk1AwWB7lhrUz+KyFSwHBsNrRGrQsoJlzxv+t/iYGVNDoH4gEYj5ql/ CeHmzmqxbpPaUj2XHHaL4tWu5VPiB1mnaR6+j5wsEmWg6+dyhR7WrVNnIpH1deF8LX3L HDVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ZmYVy4RMB1nm84Ujmahlr0a1LucrpOQmVhWf/UbYX6U=; fh=xIEeRyRAYvqlnCTrrwU+x0AaKtR++qNBEPAvZj3BZes=; b=cYV4KeuU+ao0P/s4C04G2DBrSDYhzmcD70BsXfKlhtZKBRC21AUUBrr9iURwpOXAGr PpnkUeMFiJZrUzFwgVcHhFJOvpudMxvD9T9jKvTtrZlp4TOyAWx2eFdy2fQjALrqnN0q nUkoDJ3AvjVjdVbZMKbJ5lV/YsZez5W7yQ4Yi+QrvhJUkLtFAUAYm79DE6+NUkY8oQzQ 2hcWJeQMNnfR1kxPqvWO+jiptLWgavt4ZXyo66n2sZbd1wdqlS8zc4CQyz9w1YZZZJ0J QnSLBy0e3aVLrRN2eOaKRHawMWUFAwMyTbT/Hr4oTn3n9QCzGruL6aD+ugZGdn9GIs2R rb1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=toS75VrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id ds15-20020a170907724f00b009b99c845e1asi147976ejc.674.2023.10.26.14.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 14:52:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=toS75VrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4E934826CB48; Thu, 26 Oct 2023 14:52:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbjJZVwV (ORCPT + 99 others); Thu, 26 Oct 2023 17:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJZVwU (ORCPT ); Thu, 26 Oct 2023 17:52:20 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CD3E129 for ; Thu, 26 Oct 2023 14:52:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FC67C433C7; Thu, 26 Oct 2023 21:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698357138; bh=Ar47rK4VoU9HotPJMrv49W+xY9ALyh8WYdwKhKQgUjU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=toS75VrT71cikMeUq+SfNasbWtSG1FISHYIJFDSUO0ISgit075mYCrh1WTa96gqPk B4Ho5FKtAF9MAaCg9k9C4EFXLyF6ncBFhU9Mt2qYJNLwAF1ftJPxlHjLqQi4qpuYTm Qee57m3AjAjykTLJfW+C0S85VION5dk47IDxHcwPM8jsnAZ4EIdjPp0KMdcnHUr1jN H1Gjou0ILvGoQZANolOE1wDuky0MwqaK+OtnnlcijosFr061irIm8KNpwIFIimabRH DIxjo7PAf2Hb67ywTo4VIEPMnQCz3ZeXdZ1THQFQykeZKZ/F6arfAU99Iu0Amo3ocy 6qOjLI9h9hZSw== Date: Thu, 26 Oct 2023 14:52:17 -0700 From: Jakub Kicinski To: Wojciech Drewek Cc: Ratheesh Kannoth , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sunil Kovvuri Goutham , Geethasowjanya Akula , Subbaraya Sundeep Bhatta , Hariprasad Kelam , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" Subject: Re: [EXT] Re: [PATCH net] octeontx2-pf: Fix holes in error code Message-ID: <20231026145217.4b840baa@kernel.org> In-Reply-To: <0d1cb5d7-53e8-45bd-ad45-48fae64b8d9c@intel.com> References: <20231026030154.1317011-1-rkannoth@marvell.com> <5819e6c8-d887-40ca-9791-07c733126e64@intel.com> <0d1cb5d7-53e8-45bd-ad45-48fae64b8d9c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 26 Oct 2023 14:52:26 -0700 (PDT) On Thu, 26 Oct 2023 12:56:26 +0200 Wojciech Drewek wrote: > I'd add to the commit msg that some error values were wrong and it it > was fixed, but it's a nit. Agreed, it should be explained in the commit message. Borderline it deserves to be a separate fix. -- pw-bot: cr