Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20231023033144.1011896-1-yangjihong1@huawei.com> <ZTrCS5Z3PZAmfPdV@kernel.org>
In-Reply-To: <ZTrCS5Z3PZAmfPdV@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 26 Oct 2023 15:08:54 -0700
Message-ID: <CAM9d7cjhSSV+18ZCHLdTFpMM+MmpoDkYSGjUa5JKZp02Kx9XRw@mail.gmail.com>
Subject: Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Yang Jihong <yangjihong1@huawei.com>, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Arnaldo,

On Thu, Oct 26, 2023 at 12:47 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Mon, Oct 23, 2023 at 03:31:44AM +0000, Yang Jihong escreveu:
> > evsel__increase_rlimit() helper does nothing with evsel, and description
> > of the functionality is inaccurate, rename it and move to util/rlimit.c.
>
> > By the way, fix a checkppatch warning about misplaced license tag:
>
> >   WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> >   #160: FILE: tools/perf/util/rlimit.h:3:
> >   /* SPDX-License-Identifier: LGPL-2.1 */
>
> > No functional change.
>
> Please run 'perf test' before sending patches upstream, I'm checking if
> what is in perf-tools-next/perf-tools-next is building and I noticed
> this:
>
> ⬢[acme@toolbox perf-tools-next]$ perf test -v python
> Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
>  14: 'import perf' in python                                         :
> --- start ---
> test child forked, pid 2912462
> python usage test: "echo "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" | '/usr/bin/python3' "
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> ImportError: /tmp/build/perf-tools-next/python/perf.cpython-311-x86_64-linux-gnu.so: undefined symbol: rlimit__increase_nofile
> test child finished with -1
> ---- end ----
> 'import perf' in python: FAILED!
> ⬢[acme@toolbox perf-tools-next]$
>
> The following patch cures it, Namhyung, can you please fold it and force
> push perf-tools-next/perf-tools-next or let me know if you prefer that I
> submit a patch fixing this separately.

Thanks for fixing this.  I prefer having a separate fix.
Please send it as a formal patch.

Thanks,
Namhyung


>
> - Arnaldo
>
> diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
> index 26e1c8d973ea0b95..593b660ec75e24e1 100644
> --- a/tools/perf/util/python-ext-sources
> +++ b/tools/perf/util/python-ext-sources
> @@ -40,6 +40,7 @@ util/rwsem.c
>  util/hashmap.c
>  util/perf_regs.c
>  util/fncache.c
> +util/rlimit.c
>  util/perf-regs-arch/perf_regs_aarch64.c
>  util/perf-regs-arch/perf_regs_arm.c
>  util/perf-regs-arch/perf_regs_csky.c