Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 26 Oct 2023 15:56:10 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: RE: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER
 events
Message-ID: <653aee8ad2717_780ef29418@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230601-cxl-cper-v2-0-314d9c36ab02@intel.com>
 <20230601-cxl-cper-v2-3-314d9c36ab02@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230601-cxl-cper-v2-3-314d9c36ab02@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5wQeZseHwIrU76aoeEMNe+RHxZ8Vhn332ZYIUt80+sgnVFvUs+/sM1o6oE1Y?=
 =?us-ascii?Q?UCDYH1mMPiTOhiM6V6T0rCcBkthX0z5kRtLnwXIdLJzqCBA7Nk1d4gI/MxzS?=
 =?us-ascii?Q?0DL3nuEiYoXEwaWf8R37eDWUgUViA6TlGSgz81JrChzYlZhxlxa6Wa2Wz3sx?=
 =?us-ascii?Q?g021ArQqsbKK44NNp76vSSCvDHeLp3sDkkDsO+mMHQoOfQXuKFd3L0SEQ4cJ?=
 =?us-ascii?Q?EhJzSiagfe1kwopbP7oCvwCYc134uajF6Qksiu8KukqFb+M4ZhY4RAtTHdbF?=
 =?us-ascii?Q?aUQCfcwDWzy1mzjsBc6Y6ylrJyRkvcOzw6loArd8V7vhOZJDVo5CTeTJh2Cw?=
 =?us-ascii?Q?Lf2tJQhF/8Y5b5UqihCSqk6VbnZbV7W0SlPAJqR5sKDln7Fdo9CXPZpdSmE3?=
 =?us-ascii?Q?1ZimtVIPQ5tHukclL7pgbjJ7uHzQubCQAgoIZfedZeut9kgw7vnadbQ5auRT?=
 =?us-ascii?Q?BW44o41xD5eeV7NUa1zZ53MmZQF+IMIy4wqWb2yWYChTyayT+Z9TbnWZxC5b?=
 =?us-ascii?Q?LknG6f5tacUPyktVC28SAkHwmC1vmwmbSl2UyJJptFitRBzbRhSANipJ8FSt?=
 =?us-ascii?Q?F0njzW+GkHBV3wSHnNQFfq3cZn9mxesHOFM4z8QzR7E4SF3TghdYXE7Y4hZe?=
 =?us-ascii?Q?xZHKLsETrWuDKe9HeWpjUfthxkqQYnYaynkD268RHV4PHayRyCqWiRxosmXf?=
 =?us-ascii?Q?sKhMGz3LkR6B2pvxw3P7047G3l4NXwO/75W5KnK5O4BzFxbFB71JfxYmKZPy?=
 =?us-ascii?Q?HOYkcn5d/hMBhQq/rTaa4MADvdj/WdiOl06WrG+LIa1bZWdHWEi6VgquuUtZ?=
 =?us-ascii?Q?YKPZZ0y59Oxw+ValKIF+UUwe2hwKzDXPJkODbMVscdGRSoLv8tR8PfiubbAt?=
 =?us-ascii?Q?Yw4hnExqu/ee57yTM/jcxL7J1JACURGr6GkkBhQWAmX8E//lNkshpYtK+aq0?=
 =?us-ascii?Q?Y+LLXgEi1nSQN1Cq9ko9k9UUn00pwUYS2hq+cDdodObeb+xjckHmX1hbqnxr?=
 =?us-ascii?Q?0Kt+KpnHtLm6PSWBoskU62AV62Y5FtDt00zxvreRhWS5bpBJxTnzTtdwFp8a?=
 =?us-ascii?Q?YqhkR83dYNbHGNQuMI78AXvSPWYqVSmxpSHyzxchjPt6Ph3K3qoWkXCnbEzi?=
 =?us-ascii?Q?8toikzpbZfP/y6Jf+QydBmK1t78Xfzl1hrC9rMamHvAvd2ar/mmUxJRHweCe?=
 =?us-ascii?Q?xrno+Hw2KEpenDXdOBmJa+g9jq4hTseJkCMKCD3FluoCRDAOpR8YSuDnZV9R?=
 =?us-ascii?Q?bKhCtXH6uzLEC21F5ckBp0ZZCJKhp//zUzKGvSIQ5hGfvzlngDpSYwbGgCsE?=
 =?us-ascii?Q?b5FWIx1n1mvw6zvag23i1OVv+mHpV9YR+05svM1swh7eQPmrxOob5Pm7gRwk?=
 =?us-ascii?Q?+wu+5l5EwYox5IGJNTFN/JC3/3dLWb9+4al6GTnWcawYBM2GE9kVIoL/q1ew?=
 =?us-ascii?Q?WLjPlfd8qTloIZZ1htViDGLbqLpYGMfl+FO6HbO0LvMTMQqysBnFnCDRhbae?=
 =?us-ascii?Q?ZwasMq3xFX3w/rE6+crGri5U0jhUM2JBHBNa4AE8Z+qEyvUCVesDw8eY2j9k?=
 =?us-ascii?Q?bmq5sRRHbVMo0TZuPeLKshzj/r587fO6RxGnIe3AVclhTxlhAUXE56WtsQpl?=
 =?us-ascii?Q?KQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cab19653-cd0a-4632-6077-08dbd676c0e7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 22:56:13.8173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J0XNDKZrsTLC48Z5JI7Dw7hqOomB44BqMtEfG400HSGfo5JSsa9EYvX/W9CXN1ZsKdCm+tmuNsZakqcoUWyD1SefkWmlD4JzFUjD/Vng7Uw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7295
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 15:57:25 -0700 (PDT)

Ira Weiny wrote:
> If the firmware has configured CXL event support to be firmware first
> the OS can process those events through CPER records.  Matching memory
> devices to the CPER records can be done via the serial number which is
> part of the CPER record header.
> 
> Detect firmware first, register a notifier callback for each memdev, and
> trace events when they match a device registered.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
[..]

The changes requested in patch2 cover all of the comments I currently
have on this patch, just one more cleanup below:

> +#define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> +int cxl_cper_event_call(struct notifier_block *nb, unsigned long action, void *data)
> +{
> +	struct cxl_cper_notifier_data *nd = data;
> +	struct cxl_event_record_raw record = (struct cxl_event_record_raw) {
> +		.hdr.id = UUID_INIT(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0),
> +	};

Just do:

	struct cxl_event_record_raw record = { 0 };

...and the compiler will take care of the rest as initializing any field
automatically initializes everything else to zero.