Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <0bd4fede-2d11-c781-98af-5a27ba454346@roeck-us.net>
Date:   Thu, 26 Oct 2023 16:02:20 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v4] hwmon: (pmbus/max31785) Add delay between bus accesses
Content-Language: en-US
To:     Lakshmi Yadlapati <lakshmiy@us.ibm.com>, joel@jms.id.au,
        andrew@aj.id.au, eajames@linux.ibm.com, ninad@linux.ibm.com,
        jdelvare@suse.com
Cc:     linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231026221708.1582518-1-lakshmiy@us.ibm.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20231026221708.1582518-1-lakshmiy@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/23 15:17, Lakshmi Yadlapati wrote:
> The MAX31785 has shown erratic behaviour across multiple system
> designs, unexpectedly clock stretching and NAKing transactions.
> 
> Experimentation shows that this seems to be triggered by a register access
> directly back to back with a previous register write. Experimentation also
> shows that inserting a small delay after register writes makes the issue go
> away.
> 
> Use a similar solution to what the max15301 driver does to solve the same
> problem. Create a custom set of bus read and write functions that make sure
> that the delay is added.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
> ---
> V3 -> V4: Fixed warnings realted to this commit

I also asked about the use of udelay() instead of usleep_range() or fsleep().
I see you did not change the code. Fine, but please explain why the use of
udelay() instead of the alternative is desirable or needed here, and don't
just ignore review feedback.

Thanks,
Guenter