Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <f545e695-d838-ec28-d319-e4e9a885f8cf@nvidia.com>
Date:   Thu, 26 Oct 2023 16:04:56 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH] hte: tegra: Fix missing error code in
 tegra_hte_test_probe()
Content-Language: en-US
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        timestamp@lists.linux.dev, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20231026075328.996704-1-harshit.m.mogalapalli@oracle.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20231026075328.996704-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEhVQktnejJjcjRqSy9nNXRyc0daQm53QmxtdHY4ZGZWMUxUb05pL3JiYW5z?=
 =?utf-8?B?bWpuSUNZeEJHZ2VSdHg5YzdDb1FLYjJPUWVvSCsyV2tUVzgrVi8yVGVmbjJT?=
 =?utf-8?B?TXgxeE1lN1VMdWxyZmxMdCtOeUR6bE8zM3c2dnVXazdPTjRvNTI4OVVTZ1Nm?=
 =?utf-8?B?MS9HRTJKbVhzcGs1bnJHbTlJbm9JOTNrZHNLbmZITkdDZTFXSStRejYybWIx?=
 =?utf-8?B?dzBkeENCZHZoOFZVMStGV1MyS2JlejdtQTNlNThPdUg0WnZkbXJRM2lFVHpN?=
 =?utf-8?B?OHYxN0ZTMWRSYUdXNytDT2o4bHl4dW1zTGZDMjg1anpJNTRQT1VTcjBnSGFk?=
 =?utf-8?B?bSs1MHk1WlVDbWw1WG5QM3Vtb2JySCtwNHVKSW9YSWdFSzZSN3Z0ZTBhWkRk?=
 =?utf-8?B?anhPTW14ZGk0TFZOZGxRbUFCL0tqU2VFWkFiemxVTERxRGlVdTJwRzFLQm1H?=
 =?utf-8?B?b1FSVDEydjg4WVN5TGRUcHEzSFIzS1JUcy92TWk3SStVbHNwN210QXZVRU9V?=
 =?utf-8?B?TForbE1tOWZIajdIYXQzakUyZ0xtTkwwNXAzR1VGRzdpU3U2a1lYY1Z1REdV?=
 =?utf-8?B?allQT0tnbFkxUzBuaER3eVZhOTRxOU8wNk82Y1ZzSXFFeTVTQU5GYlg0VVMx?=
 =?utf-8?B?K280dGRHR1ZaS0RtOEExZkh1QmpTNnlIcWFHN0pISUFwVjlDMnZudklsMUhQ?=
 =?utf-8?B?TVhKbVdLanN2M1g1ZnA5ajUyWUFqbW85VzBmYXNseng1OW1xeEVDVG16OTZl?=
 =?utf-8?B?N1J0QmlId2FyL29LcTBLNVkrQ2dZT0dmb3hGVkplb0lPd2dlNzM2aUhiNXZU?=
 =?utf-8?B?VVZZVnlNZFU5a0wyUW1aQnZpaXRmbEpXWDhMUS9RZHE3a29SWG1DaGRBd1NH?=
 =?utf-8?B?U0FKR3JwUkdqWmM2TzJtTVplS1I0VlV0RFQ5S1NPMjkwWjFnUTAyRW5vRzlO?=
 =?utf-8?B?RC9Damt2NUI5SFlGNkRtNjZmU2Nzb1VOTUFGTUdxbXZLd2YvVWVTLzVxWTNh?=
 =?utf-8?B?OVV0eERzejFPbWhOVlhEZm9IekpUWlM3dy9Ldk9aWFdhQXdFVXVWN2djQUNX?=
 =?utf-8?B?ZmxmZHVXTFZwN3BIS21STWppNlp2Zmx2eWhLNEJSYXpBYUM1MWN3MTFpZW5S?=
 =?utf-8?B?MGhuZk9oeW1ZZXFLUUkzd0E4djlhTk1uQW0vdGNFWWVpbTdiZXh2SUpuK1FS?=
 =?utf-8?B?YTl3WWUxSFFlTnIxT2s3YUNTUmx4aWQyT1FseDFNS0wzMERCWFl2UjJKMnBP?=
 =?utf-8?B?aFV4WTlmN3NhS1QxZ2RNNGVIaTNUQmZvdnljWk5OUTVIWURtblVxKzVuTENH?=
 =?utf-8?B?SnZPTUt6RkpPakhQQklma1B0clUvc0tvbmVreXM1YXFkZjRWNnZSTUNjV1Ri?=
 =?utf-8?B?eitTQi9wdGNHNytuN2NRd012elpURjZWL2dGaVZ5bmJWbklKUHpGZXI1M0Z6?=
 =?utf-8?B?aTRCc1RlbWZYaTErVkpoRDkrMmdHaVJ5ZnNKQXovU0hvL0ZUVjR3d0R0bXJl?=
 =?utf-8?B?ZmNSSWdYR1d2dVNDTS9aajcvTHNLYlZvdEVpeWp6UGxuYUVpbXZ4R2IvU21S?=
 =?utf-8?B?Ly9mNFQ2NlR0cmhCekI2MHZMRnRoYTdkQlJmOUxqYVQ1OStHbkVwSys3Mjcy?=
 =?utf-8?B?T2FDdW1jSG5ON2hrOU1xTS9hTkFReTZTMnhmRVlqL0wzWkZPcS9vSDFvVVJO?=
 =?utf-8?B?czM5cVg5WnF6RXlTVVc2Z0UvbGRlTVBHQk52Z3VIRDNKYWtBWWl0T3JjY3ZT?=
 =?utf-8?B?V0xjRmZsczQzcjVDMitrUlJIWC91bk82Tmh0WXdKSmtUaEZIaXV6cUlCRmE3?=
 =?utf-8?B?L1NEQmd3YU16Z0l1dVZvLzBlOHhUN0hWTndoU2Y3dDRFQ2txQ2JVS0taaTV1?=
 =?utf-8?B?OWUzay9YVnJuSUVJNFJFWkRFenBSMitGRTcyVU4yU2ZPK3ZNSVhXWFhZbWFy?=
 =?utf-8?B?QnRQNUtsbUN4Y09xSnc3WjZSbFhpZVdtRGRnbWNUUDdMYklKcWxMMkkydTVW?=
 =?utf-8?B?QTRsR0pJTWZGbWVVSlo0dUIzTnV1ZlVOWDhpMEJqUVpocE5DWXY3aUxZVTE1?=
 =?utf-8?B?eTF0SHF3N1RxQlRFQjVJaFdMY0psbC9UT2J1ejlvbTdaT1krWDlNYXlheUdu?=
 =?utf-8?Q?EKXR1NJKKf6Fn5oGNLt3sJAqN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59d0e1ca-ef3d-45cd-2e59-08dbd677fa29
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:04:59.1396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i/QQvBy34QqQ6jQ1IEMqwi2c7uEF+8eTlHS+UM80FOYXMW2svekyyiS8oaJxHSPqmoRPBS6FBeneuBkVVMag/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6805
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:05:09 -0700 (PDT)

On 10/26/23 12:53 AM, Harshit Mogalapalli wrote:
> The value of 'ret' is zero when of_hte_req_count() fails to get number
> of entitties to timestamp. And returning success(zero) on this failure
> path is incorrect.
> 
> Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is found using static analysis with smatch, only compile tested.
> ---
>  drivers/hte/hte-tegra194-test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index ba37a5efbf82..ab2edff018eb 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -153,8 +153,10 @@ static int tegra_hte_test_probe(struct platform_device *pdev)
>  	}
>  
>  	cnt = of_hte_req_count(hte.pdev);
> -	if (cnt < 0)
> +	if (cnt < 0) {
> +		ret = cnt;
>  		goto free_irq;
> +	}
>  
>  	dev_info(&pdev->dev, "Total requested lines:%d\n", cnt);
>  
Reviewed-by: Dipen Patel <dipenp@nvidia.com>