Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <de5e5529-7365-4ed4-9069-7912ad9bbdfb@intel.com>
Date:   Thu, 26 Oct 2023 16:15:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v1 1/1] net: stmmac: xgmac: Enable support for
 multiple Flexible PPS outputs
Content-Language: en-US
To:     Furong Xu <0x1207@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Joao Pinto <jpinto@synopsys.com>,
        Simon Horman <horms@kernel.org>
CC:     <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <xfr@outlook.com>,
        <rock.xu@nio.com>
References: <20231026094856.986796-1-0x1207@gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026094856.986796-1-0x1207@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0ZTbHFmSE1ETlpYdm5qVlJ0NTRNbXpsbmJVYThYNXU1VW1NRVQwa1FpS2kz?=
 =?utf-8?B?VXBvaWlHUjA3azNOUGlhWUErZlIxVnhuNzkzQURFZTB2aUhleW5BWHNHQ29W?=
 =?utf-8?B?bDBoaVY4KzA1ZUZDTFFIS3F1TE85ekpHZDZFZllhc2o3UHEvdVRsQllkTUll?=
 =?utf-8?B?OEFMQmszZ0lZRWRNRWE0b3lpWFVINW5Db0NvTzdpZTA4WjM3SnVsMGlvYmdE?=
 =?utf-8?B?KzRoektoRXJEYktQeHZZeUs4aE1aeTFoTzVHbnYyTDBBMmFXOXk1Q1pIbnV2?=
 =?utf-8?B?K0N3YWVvRlJPY0pvaWtRQ3ZsTVJMRkpueThYSW40VW8zVjNmWlhzNk1SeC9y?=
 =?utf-8?B?eXVmanZENzFKeFZrd3d3MzRDeTRCcUc5ZWpQRitYNWpyRG5sUnQ3a1NEc2E3?=
 =?utf-8?B?V2N1S2J6SFZrU1Jkb2tBL1FLNlpSRGk5N1ptSHAyVVBOZDJWWjY4WXJwVWlG?=
 =?utf-8?B?QXFwL1pzQWxROXpaUUVIWk5aSU1qRTRLeTRrSGFyWXNGUmpMcTFubi8vZHpy?=
 =?utf-8?B?ZElHL09PZmk1SEZycE5aNUpBaFBydVdMbVQ0bndnWE9Rbmc4MG80SEpZWFBT?=
 =?utf-8?B?a1ovTWJma1NGbVR2d0NEMlZHZUZ2TVZ2dzV1cTl3aVlucDdPVHV2Nk5DR2F1?=
 =?utf-8?B?NGt6cnlkdzNZOHhXU3ByMEFza1FYbGFtckJSRlIwL1R5cloxRW40dXpIZ0pV?=
 =?utf-8?B?S21wQkQreXhEcVc1bTFQOUQvYU9RQ1BPZkpqYllVYkNaY3EyMmpWdSs4SCs1?=
 =?utf-8?B?dW42K2FPbm9DZlAvZlc1RHF4V2tvQjlqWFVldWdydFpiZ09KRWxtSWladDZX?=
 =?utf-8?B?SXlSdXQ0aXJjUUZ4OS9YaE5zazBwTFE3WDAwNlU4UjBVazJBTnRVVzRpb2Jv?=
 =?utf-8?B?YjBjMHhSbm9vTDRBMlkrR0duNER1Z1F2MUFqMUtUSnhnTEJyMjQ1YXlLT0FB?=
 =?utf-8?B?RFR2K3l1ZWhsaUczSzdVTzRxQS84SnMzd1ZVVjMyQ3ErbXJNdzNyVzBvVDJI?=
 =?utf-8?B?S3F2eXNtbEQyb29ZWkdueVhINkxQeGFTeGV1c2h2YkVJVXN3alZmdnVHYzF2?=
 =?utf-8?B?TzAvVlVjejRxMFF5U2kxM1NpRWhVb05NaStzVWRya3A3L1dyYXdyeWVtcHpR?=
 =?utf-8?B?SnZoM0p6MlZoM2VwU3F0MlNKcFB5SDVqcjdnUGV2WTBPZktnMEJ4OU0zWjZX?=
 =?utf-8?B?MzEvNTJjZWhEdTRva0FmZFRtQTdVWUZKbFo5aEhhOU1qUkhNOWlhd2xrNzRC?=
 =?utf-8?B?VENVeU50alkzMFI5Z3l2cU03QW1MMCt5KzRLYWd6c0VnTDIxaVN0OTNOMDA2?=
 =?utf-8?B?Z2xWS0pnZEowRmhPdTNRd2R1REJJVTBpWmRBK2lDZ0VVenhBS0xQVW02V2ZP?=
 =?utf-8?B?MCtSRm4zbmRUK2N0TnEyU1BJSDZMT3RJeG9QYlZhR1N2TUs0VXdNdnlmTkFZ?=
 =?utf-8?B?UUNOL3pIZkpJMXBlazdKZVZwMU9ZYkk2Ui95WW9aZk5jYm1GL09UY3E2V2dU?=
 =?utf-8?B?VTl0RFJkeGFqeCtTUnpkVkorQThtbWRDQitmZUxRR2RjMVg0a0FlQlkwajda?=
 =?utf-8?B?MFNrNFg0WkhLb21qemk4UjFFTkVmYTRMWVhUQzZHRmRqd3llZ1ZobUVrMmV1?=
 =?utf-8?B?NThhcGZxaHQvSDNVU2tLWFYwS21kQjZYZnB4OEtBcHNTdUgyQUpZcEo2K1l4?=
 =?utf-8?B?dVUrT1JnVllqWStlKzlZbk1vOXdWVnpKblhZVm1STG8ydFpQSGpuTElwN29v?=
 =?utf-8?B?S3FMTW5na2k5VWhBTi9iUmZ3QXpES0NZMTZSS05LN1VBUW8wM1pTb0FKeXh2?=
 =?utf-8?B?YkhJTDdDdE40SmszRm56T01IUXVVQVVCTEd6VTRwTlcxYSswL0p4TDlVcEVu?=
 =?utf-8?B?UTZ6ZXZwV1pkckdHcWlPdzNMRzQyY0M5ZWdvL3NmcUgrazFlbUZKdmE3cmtr?=
 =?utf-8?B?R3dHWCsvbXY2TkNmbzlURWdQLzhiZ3RIWFBqTjZ0VVhaQVhNdDJXQlZxU2xP?=
 =?utf-8?B?b0s1cTBJZStpOG9JQ01Uclc1MU1rdmh5MzNRRjYxSDFtRjNrWEtWa3hrTXpG?=
 =?utf-8?B?YlNwN3ZVWlBXRXZsT1pYamc5ZHNMYzVqdGRTcld3SFFPS1huakVHWVFZSno1?=
 =?utf-8?B?eW1Ua1RHVDB1eGprRjR4NTZHZXZtS0VwZjdhR295ajY1U0k1RUtPazhCa25m?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c478befb-ebdf-4ef0-9b38-08dbd67979de
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:15:42.8127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zqiH/7Fe3wKIJDsH9xXn+hC4dDjAywKTi63vf6niLBxUgLkYj99nImnG8fsrlxFgndBAPp7HKqn/DLxzUshiwvEnGCdl1N+jtgofcLSwb3c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8703
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:18:03 -0700 (PDT)


On 10/26/2023 2:48 AM, Furong Xu wrote:
> From XGMAC Core 3.20 and later, each Flexible PPS has individual PPSEN bit
> to select Fixed mode or Flexible mode. The PPSEN must be set, or it stays
> in Fixed PPS mode by default.
> XGMAC Core prior 3.20, corresponding PPSEN bits are read-only reserved,
> always set PPSEN do not make things worse ;)
> 

Previous revisions the corresponding bits are always set, and don't get
modified by writes, so setting these bits for all hardware has no ill
effect.

In the previous code we always set BIT(4), but nwo we set BIT(4+x). This
won't affect XGMAC prior to 3.20, but corrects a mistake when
programming the newer XGMAC. Ok.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

The original code was added in 95eaf3cd0a90 ("net: stmmac: dwxgmac: Add
Flexible PPS support"), which landed in v5.4

It looks like XGMAC Core 3.20 support was not added until possibly
commit 669a55560e4b ("net: stmmac: Check more MAC HW features for XGMAC
Core 3.20") which appears to be new enough that its not in any official
Linux release, though it looks like it was already in net.

Perhaps this should be tagged Fixes: and sent through net, hopefully to
try and hit 6.6 or at least a stable release shortly after?

Thanks,
Jake