Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <976cbd32-3f0c-4ca4-b147-10040f2d7767@intel.com>
Date:   Thu, 26 Oct 2023 16:18:03 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 1/5] net: ethtool: Make RXNFC walking code
 accept a callback
Content-Language: en-US
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>
CC:     Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "Tariq Toukan" <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniil Tatianin <d-tatianin@yandex-team.ru>,
        "Simon Horman" <horms@kernel.org>,
        Justin Chen <justin.chen@broadcom.com>,
        "Ratheesh Kannoth" <rkannoth@marvell.com>,
        Joe Damato <jdamato@fastly.com>,
        "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@resnulli.us>,
        "open list" <linux-kernel@vger.kernel.org>
References: <20231026224509.112353-1-florian.fainelli@broadcom.com>
 <20231026224509.112353-2-florian.fainelli@broadcom.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026224509.112353-2-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXc0V0g1RWd1ZG14dXJIRjRuRitGZjlMcTNaRk12MEliaHhQb0VuMHlSbGhM?=
 =?utf-8?B?OFVtSjRHVjEvenRNT3pnRGIvMld6VjhNeWN1YzZuMm80ajBGOXQ5NWlvUmow?=
 =?utf-8?B?S1VjMU5mRmpwbWpIWkRGdEFBK2xvYlBZQVpxRzlIZm9kem1zd2lLWVJrQ3Fn?=
 =?utf-8?B?bVVBZDlFS3hrRU9HUStRQnZlYzUrTVhNTjc2WlNCbCtOdXorYjdtNTdXN1JZ?=
 =?utf-8?B?d084YjhXcEY5SHlVb25oM3FnL3VrOFN4Mi9UNFBnUmoxSEt1NzFRZmd2V0dJ?=
 =?utf-8?B?TjdWM3lYY1RDNkZjQnphUTh5VFdKeWxqVGdHNkdZWGIvdmNlWWJSSFM5NnRz?=
 =?utf-8?B?NVdFcmw5M3lYSzBoekMxWCtVWjNndFdtUGlZWkc2UW9qdHByckhoTmhaQzls?=
 =?utf-8?B?ZFdOS25nanRVU3dzMzVWdlZZWXBldzdvTnczMXQxdjltdVBjUUQ1SVJJUTI1?=
 =?utf-8?B?b25mTGU0TUg2MGR4S3BLWUljeFRDUzBLcHB1WmJnVTJUcXBYamxyUjBTNFBx?=
 =?utf-8?B?VnVpREJpT3FQMkk1ZGxiWnVqV09MLyt6a0RpMlc4d0FCcEd6RXkxYTV4N3Bo?=
 =?utf-8?B?ZzRwNk1obnFrY0NoVzRBb1h6Wklhd3RaL3N0ZmdnRlhHNmtmODIvSkt2YUxB?=
 =?utf-8?B?S09NRHRNYVk2ODBjcVBzdDBZc0I5UWtzSWx6dVQ0dDlkN1lRRFJLUUdXWkd5?=
 =?utf-8?B?dHJoUWIwMHJta3FvVjVaekxaQithL1hUMWhaQWpPMUdkT2drbEZRR2hneTlL?=
 =?utf-8?B?QWhSVWZxVCtYV0RzVlpXZVdxLzRTTjdRMDY0SXVURWZhQ0xXSnlRVFJvRU0v?=
 =?utf-8?B?MmJ6SG1FSUNhd3lrZkhoT2NZbFQyYndYT3JuWUlBM01ZU1Y4cEREeUhyTGZY?=
 =?utf-8?B?RlZBOGlwcDllUGFMSUE4U0owQTNwbndDWVFGZ2F5VE9paUd1WHVmdDNlMHF2?=
 =?utf-8?B?b2E5L3FXOW94TElMS0J0WlE4OUFSYnk4enc1VDJoVkVRQ3RxWEZpNTg3WERD?=
 =?utf-8?B?dHR2QS9wWDVkaU9xQTRRUlk5NDVUczRIUndzVHNFZHU3L0hla05VTlhCLzU3?=
 =?utf-8?B?UlRlc29tVEZZVUcrSyszYzAzL01YaTBjUnpOWml3aUM2NktQdy9TMVVZSks2?=
 =?utf-8?B?aUJRcXY2eU5DTDNueWg5T0xueElIaXRqY1VyVDNDeXZETWs1aTBZaFZrbndr?=
 =?utf-8?B?dTN3dXV2Z1ZSaU5BMlRsenY5MXI3eHNEbmgxeXdQSGh3V3JKYlovT2VBUWR4?=
 =?utf-8?B?SEl2cFU0UVlCRkNzdUJzcnk3T0J6dUJSdGZZUStyZ0pRT1hCdTR3d0dtNFlF?=
 =?utf-8?B?S0NQQjMwcmNEQXBTbGEwSUNyVjl3U2lJd0luSFVKZDRVcHhJZGpDNVV4aFFE?=
 =?utf-8?B?NVpUUEc0TFRuRmkrVDh0M0c2Tk9TUzR3ODZpYmRsbUlLK2NoTysrTStyVTF2?=
 =?utf-8?B?Wm1LalBjSlNCNzErVE5xTUtJYU1mMktsMFJqV3EzOGdXcGhVakxTZmlhd3NS?=
 =?utf-8?B?bGcwSWJUWEE4R3p2TEpHUVlzVWJmcHV5VytiRmZrUGxwQzZhdCs0b0laRTlE?=
 =?utf-8?B?YnloSXFXbXA0TU1Zalk2Rkg5WkdSbllvbGpCalBDZkFtYzhmSWNwenFrSm5Z?=
 =?utf-8?B?Y0p3eFpOMEhINFNPaU52QkJaUTRmZHdGbDJnYkpOZVVTa0ZpQlZ5cC9PK3F2?=
 =?utf-8?B?UkIyT3J2a3VzWFlBQno2V0Y4VDlRUkYzUUhjRHlaTVhwb3A1WHBNV3duQTBw?=
 =?utf-8?B?cE5sNEFrRmFPU3U4amZnS1RLblM2Qnp1Y2tRZ1I5aXFXSXBGamFmR0g2cHVl?=
 =?utf-8?B?WFpYbHUrSWxsYUhnWUJNcytIYWRUQVBuQWZBUmxINXM1cm1Xb2dnREhCQTF2?=
 =?utf-8?B?SzRNS2w3c3ZTbld5WllEWFl4dFovSW1qQlR1UDk0aHhMMjJrVkdUU1lBOGdj?=
 =?utf-8?B?ZmdFcjBHbjN4clRrcm5XRHNCZkRpeUI0QnBaTDQ1UVFOWmxKeldpYkQ3bFVj?=
 =?utf-8?B?WWJBckMwOWdoRFRUUnU2aGtKQlZLMkdGM3ltVS9wdk9GZ05xcXVIOFFab1NJ?=
 =?utf-8?B?L01BYlFpeWFTYXlBdkxFQjZXV3JLTklscnplUUFZVjBZMVNUZk41SC9tY1FS?=
 =?utf-8?B?MDBNOFpCbHE5QTRHTzRtTXpQeTYxMHdYNnZTd0lZM3Q0clMrRzNWZ2JIRE5k?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 92c1fbe5-ad8b-48ba-79de-08dbd679d048
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:18:07.7824
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZTgiOnwtDbOdMihKNJNi6sVI66Kh/bUQP2PI2owOfva3Q/v7bBjGToAS3sLvPKdZlGGqbcuCx9VNvBp5bo8DKMzYcjTRN4cq22NxevG2EaE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6180
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:18:36 -0700 (PDT)


On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> In preparation for iterating over RXNFC rules for a different purpose,
> factor the generic code that already does that by allowing a callback to
> be specified. The body of ethtool_get_max_rxnfc_channel() now accepts a
> callback as an argument and is renamed to __ethtool_for_each_rxnfc().
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>