Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Fri, 27 Oct 2023 07:18:15 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-mm@kvack.org, mpe@ellerman.id.au,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Luis Chamberlain <mcgrof@kernel.org>, hch@infradead.org,
        Florian Fainelli <f.fainelli@gmail.com>, deller@gmx.de
Subject: Re: [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some
 architectures
Message-ID: <ZTrztxpJu31EKrls@MiWiFi-R3L-srv>
References: <20230921110424.215592-1-bhe@redhat.com>
 <a7e3fdcd-d5e6-4261-85be-3ec1221edf24@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a7e3fdcd-d5e6-4261-85be-3ec1221edf24@app.fastmail.com>
Precedence: bulk

On 10/26/23 at 01:36pm, Jiaxun Yang wrote:
> 
> 
> 在2023年9月21日九月 下午12:04，Baoquan He写道：
> > This patchset tries to remove ioremap_uc() in the current architectures
> > except of x86 and ia64. They will use the default ioremap_uc version
> > in <asm-generic/io.h> which returns NULL. Anyone who wants to add new
> > invocation of ioremap_uc(), please consider using ioremap() instead or
> > adding a new ARCH specific ioremap_uc(), or refer to the callsite
> > in drivers/video/fbdev/aty/atyfb_base.c.
> >
> > This change won't cuase breakage to the current kernel because in the
> > only ioremap_uc callsite, an adjustment is made to eliminate impact in
> > patch 1 of this series.
> >
> > To get rid of all of them other than x86 and ia64, add asm-generic/io.h
> > to asm/io.h of mips ARCH. With this adding, we can get rid of the
> > ioremap_uc() in mips too. This is done in patch 2. And a followup patch
> > 4 is added to remove duplicated code according to Arnd's suggestion.
> >
> > Test:
> > =====
> > Except of Jiaxun's efficient testing on patch 2/4, I also did cross compiling
> > of this series on mips64, building passed.
> >
> 
> For whole series:
> 
> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks for testing, Jiaxun.

> 
> Hi Arnd and Thomas,
> 
> I've got some work pending based on this series, however I'm unclear about
> which tree this series will go since both of you give acked-by.
> 
> Given that there are some tree-wide modifications, I guess it should go into
> Arnd's asm-generic tree?

Previously Andrew merged my below patchset. This patchset is solving the
left issue during reviewing below patchset and discussing. Maybe Andrew
can help pick this patches?

[PATCH v8 00/19] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way
https://lore.kernel.org/all/20230706154520.11257-1-bhe@redhat.com/T/#u

Thanks
Baoquan