Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <b331eca9-5345-49e9-8e44-7c18045ac7f9@intel.com>
Date:   Thu, 26 Oct 2023 16:19:06 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 2/5] net: ethtool: Add validation for
 WAKE_FILTER
Content-Language: en-US
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>
CC:     Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "Tariq Toukan" <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniil Tatianin <d-tatianin@yandex-team.ru>,
        "Simon Horman" <horms@kernel.org>,
        Justin Chen <justin.chen@broadcom.com>,
        "Ratheesh Kannoth" <rkannoth@marvell.com>,
        Joe Damato <jdamato@fastly.com>,
        "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@resnulli.us>,
        "open list" <linux-kernel@vger.kernel.org>
References: <20231026224509.112353-1-florian.fainelli@broadcom.com>
 <20231026224509.112353-3-florian.fainelli@broadcom.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026224509.112353-3-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlBKWmpicXdkSHJHSk5tUCtUaVFCRlBWRTRmQk1LSllJbU5sS0VIMWJqb1d1?=
 =?utf-8?B?bU9FYmlsS01NaTJoWVBEYVJ1VFUwMUUrWGpoSGd2ZWtkYlkyeEJ6Y0JBNlNl?=
 =?utf-8?B?S2lFdXJSWE90ZjdsTmppVWNNaVhPZHoyTExLU1YvVkV2Z1ZSRWptcEl0dW02?=
 =?utf-8?B?THdqcnA5a2Y4ZXlxOEt3MTRkYjhGeDFacThOc0J2R2VQMlFFZTFjQXc3L3Z2?=
 =?utf-8?B?akRMK3BFU2hFQXlmbFFtcnlWSEt1eXFuTHpYTUVkZmY5RzBERlZLZkRPNzlQ?=
 =?utf-8?B?ZkViNFZ2bDZ3TUhxQzBFeWREVncydVlEMmhwSzRnb05NSjV6bVhWb2IwN25a?=
 =?utf-8?B?bkdNUjd4UlhvbmN0MDhrNy9JMTVlUlpFZ2hhakxmVWI4d2VoaCsyL0prVGtI?=
 =?utf-8?B?YUJ2S3p6U0tXR0dUOThMcEZzZkVJVmwvaXp6N05MWHU0QjRINXZoUkZxcStN?=
 =?utf-8?B?WEFsbldzdi9OSHREcjlhZHhCU1ZteDRPZ2FkaUoreEVoRkE3VlRQWDJmQ0l6?=
 =?utf-8?B?TStMbm1qL0Y5ajBKS1VKYU9vWUE4T2xOVzlJampndmVJbWx4cFRVWFdiWWVB?=
 =?utf-8?B?MERCVkJmTkJhQ25DY1owUGNJNmhpTSswaHlhV1VFSXpPRTJNMVVNWXBRWFNK?=
 =?utf-8?B?Ni9iZHFMQjJJbmdjZXczSGF5TkNxbkkxZ1czRDhUMG9GbEJwQlI0Z0VUUkZh?=
 =?utf-8?B?Rkl2dWozUlp6UzN3VXlKUFhHVS9xMUg4RlZNai9hTURtSGRoc0xHMVZydGN1?=
 =?utf-8?B?TWxOb1A2aXNTOFJJeUZsOXFKZlJ4aUtzQkJpWExOWTE5TnFTWmZvcFg4akRP?=
 =?utf-8?B?RnIyV1NaNmYzSVNOcVVTdGpFU2VENDUxNWJ1UUZ0VVBVc0hCS3liSWJyZ0k1?=
 =?utf-8?B?MVRuWGJxak1ockhWVHJyYUYzQTZ1OTVQREZia3hlWThOa09ZRUNaWFRCdnVq?=
 =?utf-8?B?OFJZRmYyWW5MWEVlbWE3RGg0bFZod2wyY1h3aEprSmxYTytydm90TXhKWUxQ?=
 =?utf-8?B?ZTJROW1kOXZLN2xrNDBibEtxK2FHOUJXOFVZbFUyeDdqWEVMMVpwRVVldnRQ?=
 =?utf-8?B?ZmZaNmZoRVVmNzd3aTNCRnZNdUwzdWRBVUpCMnUyTDYzMG5oVkxpNUxzdjdy?=
 =?utf-8?B?cHJra1Vxd05iQWVEOUpqdmk1blJFNVozSEZOV3ZOZ3Jndk5QRCtJNjBRaHE4?=
 =?utf-8?B?eHYxZDBnZU1sY2tPT3BCMW1NWWRMUzZ0TDFEaXB5azFyeXRpMnVMWnB4RmVI?=
 =?utf-8?B?cDFyeld4RUtlVGZVSlB6bzlRZ2ptR2E2bW95Wlo4TUxIRzNubHNBbzBqR3py?=
 =?utf-8?B?NWxhNEVpaDQ4Y21mV294cURvbE9vODZGMmsrb0kxbE52TjdZdkg1WnlGZG9u?=
 =?utf-8?B?aTRucThNOVROVjRjdUczbzdQV2R4TnVwSVIxUlNSajVPMnQ2N1JzRFVWU3RJ?=
 =?utf-8?B?Y2RGQjJCK0ZQSTRFOFVuV2pwQXRza0dKcm0wK0hRQkJpYVpmOFFWVkNBNkxP?=
 =?utf-8?B?TVlYQzBWeU5Ua1N5dFRVMzd5SWF3b2ZKSHBHYU9JQVgxOWNoT1ZDV3dRNnVO?=
 =?utf-8?B?OE5FaHZhUXFJbkk3aUJ0b1pNNDFQdE1zL2JqWUZmOTBCN09wTU5FeFlOL2w5?=
 =?utf-8?B?S3NrS01WNEJ4V2E5czlHbnJSTk1YdWNOb1hjU2l5aTJiLy9RSlRUSlR2eGp2?=
 =?utf-8?B?TGI2REI2cW5kZ0NGUTRBbmhJSG01eER2ZnpFbEtKbXp4T0dtM0Z4WU1XQWZH?=
 =?utf-8?B?UG4zdXV2SkNITG0rTE83ZExDUnFHbFZqeDZsRk1RbjJnWHpGbm1sakhOU3pn?=
 =?utf-8?B?cm5YVi9TcjdYQ1pESTdPSFFuazBVZlQ0VDd0aVZSaEl0U0pOcXZZZ21XR1Zo?=
 =?utf-8?B?QzZoVklaaVNOTHpPUkxUVWtPeCtNaWtpcXZ1ZGZSUWhRSG9RUzUwNWw1UEU0?=
 =?utf-8?B?dkVqeGJsVGFMVzFwdnRjK0dtc0xBZFlLdVl6cnBJM2lnSmtQeUNHZnF4aWt1?=
 =?utf-8?B?K21OLzdtS2hzcCtZbWVKV2FOd0pxYVVZWW94VHFCcms3aUQwWi9VQVF3TzNS?=
 =?utf-8?B?a1VqM3NmTUNhQ25SZFdPbVVIZEYrSUZZc01RSUtkQ1BIclB2bnoxN1VUVmcv?=
 =?utf-8?B?YTVQZTJTbFZOTEIvc1BPRFhHaUg3VGRCdGdpRUpRVnhQM2p6UDAxaksrK3M2?=
 =?utf-8?B?VEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab76f118-b62d-4058-9f63-08dbd679f41a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:19:07.8803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUh8bYZ4V6H7wnsdpeNqeDt3VKhN3tkSDF1FVmusZ94nYAGtrRRiRS6TYmc5rxqBF4pP1eNe7nWeCQGdhGg7XrXgsoT1uD3VrQCPdD9zUrQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6180
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:19:33 -0700 (PDT)


On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> A driver implementing WAKE_FILTER must first install at least one rule
> with RX_CLS_FLOW_WAKE for WAKE_FILTER to be effective. Iterate over
> RXNFC rules to validate that condition while trying to enable
> WAKE_FILTER.
> 

Makes sense to enforce this.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>