Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <0e64566f-6dfe-49a7-aeac-21ed9e66bd75@intel.com>
Date:   Thu, 26 Oct 2023 16:20:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 3/5] net: phy: Add pluming for
 ethtool_{get,set}_rxnfc
Content-Language: en-US
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>
CC:     Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "Tariq Toukan" <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniil Tatianin <d-tatianin@yandex-team.ru>,
        "Simon Horman" <horms@kernel.org>,
        Justin Chen <justin.chen@broadcom.com>,
        "Ratheesh Kannoth" <rkannoth@marvell.com>,
        Joe Damato <jdamato@fastly.com>,
        "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@resnulli.us>,
        "open list" <linux-kernel@vger.kernel.org>
References: <20231026224509.112353-1-florian.fainelli@broadcom.com>
 <20231026224509.112353-4-florian.fainelli@broadcom.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026224509.112353-4-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTNsZ2RVa0l0QnV0K3F5VERJd2dNenYxWkJuY1ZlOHV2SW9xVTJ5UHM1Vldu?=
 =?utf-8?B?enVJckcxdURaYWgxRnFIcFlIbTJ1UVJiVm0yTVJrUmliRFdPbVc2UUpDakpH?=
 =?utf-8?B?SjNzb0RxV2M3Z2ZLQ2Y0M3JjaFJoZjRXUjdBRUNwK2kwUDZvaUs5MTlnRW1i?=
 =?utf-8?B?RkxObHpNOTNHaTZVdWF4Uk5TYkRGWlA0VnhYTXJ0b0VHM0hmaytGWWl3Ujha?=
 =?utf-8?B?Qk45TlZtdUJ4YjRyWjRZSGtRcmdZVjd4a2orTDdXOXNiOHdWN1gyOUtNRU5P?=
 =?utf-8?B?SlA0RXRwdzBhaXRHTDJNL0FMR0tpbmxGZmh4dDBrSVlxRllRUHIzUDcwSGYz?=
 =?utf-8?B?UTFsdUs5NGZ0L3REMTl0QWgrVlZ0NmhnbnlYSVM5M0w4S1o2ZTVBbnJJdFp5?=
 =?utf-8?B?a0s3d05Gb1BBbGVubHpLUkRVNmhlQ2o0TmQzR3R4TWlLZlUwek9aTnRaSTg2?=
 =?utf-8?B?S0NNbHExdzNBRTlWSEg4emUzOXF3VVFiMERkK2hvNmZ2dGVmcXhNNzIvOW9L?=
 =?utf-8?B?a0RoVVNFbkd3bWFvRWZOeExXSHNWMFMvdVZGeUI1YlkraVRRSXpKYjBUNEZo?=
 =?utf-8?B?bTRCdXRzTmhhSHZ3VjM2bkhyNzBwM3dlb1czOVhUVWx3Rkg4d1hlZlhYeGdG?=
 =?utf-8?B?c3VHdEJNZ3FpMzVlWDhodlpIMk5iL3RJdTdnSXJrc0NpUXZ5dW1xcVhWMDRC?=
 =?utf-8?B?cVdoVkpsRmVIWWJEK1BSdDkzc2RuRzd4SXJTTGRuclc3Z2FKZC93TlFCWktk?=
 =?utf-8?B?V2VqY1RpL0hLOUl4dlBsV1VzNHVmM0dVaFdna3hGM25UZG9pd2JOSTFYZUJk?=
 =?utf-8?B?Nlg4aWhiWkdGaVRoLzBFOWJvUW5GRnFhcWdZN3JTS2xwcmVrUjNkV0RkYU5t?=
 =?utf-8?B?WVFLcTR0dnQwK2hnTjA5OUQ1MnFOQWREdGxiUU9pclNhZlZGRkRmT2FvdkdD?=
 =?utf-8?B?a3dCSDl0VlRnd0FwZmY3bWNXZVY3WDI2ZjVvZkZ4T3ExSWtFZVZPb3IyRm5R?=
 =?utf-8?B?dCtyTk1sNUpUWlB0QllFZWlUSzJQTFVuMWlKTmc1WlYzdkV2QXptdzY0QnU0?=
 =?utf-8?B?RjVHb1Q0WHJMays0TlM3SDN4NlRwdW9jRmNHR3V1RDNtOXR6ZHNaZGhDbnhO?=
 =?utf-8?B?VTBIRWQxYmdubXUra05BbEtTdXlCSEN0Y0Vpdi9yQmlDUTJCallqK09BekZa?=
 =?utf-8?B?UmxUUEtsNnhoeVJsTzFLQUFsbUJtNlZyVWlSMUFTTmRwR3VxMHJrd2ltUmIv?=
 =?utf-8?B?R3FjcHJHTGVUVTNiZG9WWU5PN1VJNUdyK282dEdwTnJqVStTNnlNTlJpZng4?=
 =?utf-8?B?YnI5elFpclI1cEVLUkxiVHU1WGVoT3d5RGZBQmh4TSsvTmtRbElWSDczNlA5?=
 =?utf-8?B?M2IyYklVNTl1dWp4VDhZT2VUYkFEVGxkd0g0ZWgyWFozNm5QV0Q4bkVmcjVy?=
 =?utf-8?B?SisrS1pXUXNxZ1J5U3ZVc1NWRUp2bkFLU0Fyd1NSL0FMY0dkblRaN28yT3hn?=
 =?utf-8?B?NkFEYWxZWGZUQmMwaTlZaWVDdHJ2NnJsWkk1Skx6L3dpZ0gxRmFkMGpvd0Vp?=
 =?utf-8?B?RnFEdjJEejlqYjFCTXBCSW1nMnFyVjIxV3Q4UExzOU1WdFIxNXNFc1N2MlVp?=
 =?utf-8?B?MVVrYlNFdmxWa0d5M2YrMFRMUUl3LzJrVnY0cXdneFBnaFIxOEliZEtDYmEr?=
 =?utf-8?B?KzNFTDFkekNZZ08yaDJ0citxb25oN3Q0bk9Kb0tpN3RnRGhvNmx6TGpmM3RO?=
 =?utf-8?B?YURlQnFob3I3d0hzMWVNSkdQMUNuYnJ1NW9hNDIxNEF5cjR4UHdiVUNxTyt2?=
 =?utf-8?B?aVZ6RGhMZi9ueWE3bUdtd2x2dlo5OHFUSnlWYjZJTlVqRytxanRabGY1ZXpi?=
 =?utf-8?B?NzR2eUp5enoxT0NIemFDOXl4K0RkeHFiRXAzNU5JelBKcXhyTU5ENkZwSGNk?=
 =?utf-8?B?STJKTlAwaitmdmtzK1orQU45S1Z5Wm1IbkhJTDRWekE4L3k2TmpHc2krOFFC?=
 =?utf-8?B?Umx4VVRGZ0ExbzFnamdHQVp5UkhCR0ZNT1pZWlVoKzlOM3p6emExUjVWbHFX?=
 =?utf-8?B?dXc4QW1vS3ZqdUx0aVVBTlg3OXFtRmZibERIWk5WSkp0RjV2UG8rVC9yaEZO?=
 =?utf-8?B?QmRaaHhaTDBQakJObjloc3RPUkVMa0JWUVpXRDQ5bVZDaWJCdHNSa3o0ODFT?=
 =?utf-8?B?N3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c7a51af-34cd-49c7-965e-08dbd67a2d13
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:20:43.4824
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f525BcmEbFkEyOUM6DzMPl7hu854OVYJnB5SC1pRxkqt917+BAFWWFr7jApnOZSBw+hGkSycK/SwLhoIKiPIdSIbGs3eo5Mwh5UAMOqYl7Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7385
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:21:16 -0700 (PDT)


On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> +EXPORT_SYMBOL(phy_ethtool_set_rxnfc);
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3cc52826f18e..03e7c6352aef 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -1077,6 +1077,10 @@ struct phy_driver {
>  	int (*get_sqi)(struct phy_device *dev);
>  	/** @get_sqi_max: Get the maximum signal quality indication */
>  	int (*get_sqi_max)(struct phy_device *dev);
> +	/* Used for WAKE_FILTER programming only */

Any particular reason this comment is required? I don't see it enforced
above so I'm curious.

> +	int (*get_rxnfc)(struct phy_device *dev,
> +			 struct ethtool_rxnfc *nfc, u32 *rule_locs);
> +	int (*set_rxnfc)(struct phy_device *dev, struct ethtool_rxnfc *nfc);
>  
>  	/* PLCA RS interface */
>  	/** @get_plca_cfg: Return the current PLCA configuration */
> @@ -1989,6 +1993,10 @@ int phy_ethtool_set_plca_cfg(struct phy_device *phydev,
>  			     struct netlink_ext_ack *extack);
>  int phy_ethtool_get_plca_status(struct phy_device *phydev,
>  				struct phy_plca_status *plca_st);
> +int phy_ethtool_get_rxnfc(struct phy_device *phydev,
> +			  struct ethtool_rxnfc *nfc, u32 *rule_locs);
> +int phy_ethtool_set_rxnfc(struct phy_device *phydev,
> +			  struct ethtool_rxnfc *nfc);
>  
>  int __phy_hwtstamp_get(struct phy_device *phydev,
>  		       struct kernel_hwtstamp_config *config);